Skip to content

Conversation

@nfischer
Copy link
Member

I tried this recently in 1a1a820 and then reverted in b8b1c42. Unfortunately I'm still seeing spurious failures from codecov, so let's try the token one more time.

This time I double checked the token is provided by https://app.codecov.io/gh/shelljs/shelljs/settings. I regenerated the token for good measure.

I tried this recently in 1a1a820 and
then reverted in b8b1c42. Unfortunately
I'm still seeing spurious failures from codecov, so let's try the token
one more time.

This time I double checked the token is provided by
https://app.codecov.io/gh/shelljs/shelljs/settings. I regenerated the
token for good measure.
@nfischer nfischer added the chore label Feb 18, 2024
@codecov
Copy link

codecov bot commented Feb 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a6d1e49) 97.27% compared to head (45ffea1) 97.27%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1151   +/-   ##
=======================================
  Coverage   97.27%   97.27%           
=======================================
  Files          36       36           
  Lines        1360     1360           
=======================================
  Hits         1323     1323           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nfischer nfischer merged commit ec3e12b into master Feb 18, 2024
@nfischer nfischer deleted the chore-codecov-token branch February 18, 2024 01:39
@nfischer
Copy link
Member Author

nfischer commented Feb 18, 2024

I verified that #1150 is being diffed against the right comment for coverage purposes (the PR says "codecov/project — 97.27% (+0.00%) compared to ec3e12b"). The real test will be to land 1 more change and see if the diff base stays up-to-date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants