Skip to content

Conversation

@nfischer
Copy link
Member

It looks like 1a1a820 actually broke codecov. Codecov is currently trying to diff all PRs against the commit before that one, which leads to flagging previously-added lines of code as needing coverage in the current PR.

Let's try removing the token and see if codecov is happy again.

Fixes #1124

@nfischer nfischer added the chore label Nov 11, 2023
@codecov
Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Files Coverage Δ
shell.js 69.23% <20.00%> (-30.77%) ⬇️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!

It looks like 1a1a820 actually broke
codecov. Codecov is currently trying to diff all PRs against the commit
before that one, which leads to flagging previously-added lines of code
as needing coverage in the current PR.

Let's try removing the token and see if codecov is happy again.

Fixes #1124
@nfischer nfischer merged commit b8b1c42 into master Nov 12, 2023
@nfischer nfischer deleted the chore-fix-codecov2 branch November 12, 2023 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Codecov broken on CI

2 participants