Can you link me to documentation on the exports attribute of package.json? I'm not familiar with this. Sounds like it might be specific to ESM modules, but I'd like to make sure I understand before merging.

The related section of the official documentation: https://nodejs.org/docs/latest-v20.x/api/packages.html#package-entry-points

After rereading, can be better:

"main": "./shell.js",
"exports": {
  ".": "./shell.js"
  "./make": "./make.js",
  "./make.js": "./make.js"
},

What do you think?

That link suggests this applies to both commonjs and ESM, but your PR mentions you're running into problems with ESM specifically. Do I understand correctly that ESM doesn't respect the main attribute, but does respect exports? Or does ESM just struggle with the shelljs/make syntax (as opposed to shelljs/make.js)?

shelljs/make isn't officially supported anymore, but I'm OK with adding this as an export since that's fairly low effort.

Do you want to add a line for

"./make.js": "./make.js"

or should I merge as-is?

ESM respects the main attribute, but with only the main attribute it is not possible to include both shell.js and make.js.

The correct syntax with ESM to import from node_modules is shelljs/make without the extension (I could still import it using shelljs/make.js even if it was not correct).

I will make another PR, if I can this afternoon, to add the line "./make.js": "./make.js" since in CommonJS the correct syntax is shelljs/make.js with the extension.

shelljs/make isn't officially supported anymore, but I'm OK with adding this as an export since that's fairly low effort.

It is a pity (I will try to refactorice to use shell.js directly).

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6269733) 97.27% compared to head (a7ab844) 97.27%.

@@           Coverage Diff           @@
##           master    #1135   +/-   ##
=======================================
  Coverage   97.27%   97.27%           
=======================================
  Files          36       36           
  Lines        1360     1360           
=======================================
  Hits         1323     1323           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.