chore: fix test coverage parsing bug #1131
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason it seems like `nyc` v14 is incompatible with node v16/v18/v20. See this CI run as an example: https://github.com/shelljs/shelljs/actions/runs/5956710281/job/16287478757?pr=1129 This updates `nyc` to v15 which should fix the issue. Fixes #1130 Test: nvm use v16.20.2 Test: npm run test-with-coverage
Member
Author
|
I fixed this in #1139 instead. It's safe to close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason it seems like
nycv14 is incompatible with node v16/v18/v20. See this CI run as an example:https://github.com/shelljs/shelljs/actions/runs/5956710281/job/16287478757?pr=1129
This updates
nycto v15 which should fix the issue.Fixes #1130
Test: nvm use v16.20.2
Test: npm run test-with-coverage