nodejs v22.10.0 onward give errors: void node::fs::InternalModuleStat(const v8::FunctionCallbackInfo<v8::Value>&) #1180
Description
When creating a PR for an improvement to carry forward the exit code from a failed sync exec() to the thrown Error, CI tests in the cloud were failing for nodejs v22.31.1 on Ubuntu, OSX, and Windows.
#1179
Sample errors are below:
// From Ubuntu:
TypeError [ERR_INVALID_ARG_TYPE]: The "code" argument must be of type number. Received type string ('128SIGABRT')
at process.set [as exitCode] (node:internal/bootstrap/node:123:9)
at ChildProcess.<anonymous> (/home/runner/work/shelljs/shelljs/node_modules/foreground-child/index.js:63:22)
// From Windows:
# C:\WINDOWS\system32\cmd.exe [8364]: void __cdecl node::fs::InternalModuleStat(const class v8::FunctionCallbackInfo<class v8::Value> &) at c:\ws\src\node_file.cc:1040
# Assertion failed: (args.Length()) >= (2)
Some research showed that:
- The problems started with nodejs v22.10.0. v22.9.0 ran the shelljs tests successfully.
- There seems to be a new incompatibility between the newer nodejs signals and [email protected], where [email protected] adjusts its handling (see below).
- spawn-wrap and signal-exit may also be related, but the most obvious problem is the foreground-child and 128SIGABRT, although there it be some deeper error.
- The nyc dependency which has a new version 17.1.0 that requires newer [email protected]. But underlying that is [email protected] that has no newer version and uses the problematic [email protected]. I tried forcing some version overrides in package.json but it was still broken. And with nyc 17.1.0, the test runs were breaking on older nodejs versions as well, so there's some incompatibility there.
// [email protected] near index.js:63
child.on('close', (code, signal) => {
// Allow the callback to inspect the child’s exit code and/or modify it.
process.exitCode = signal ? 128 + signal : code
// https://github.com/tapjs/foreground-child/blob/v3.3.0/src/index.ts#L152
const childHangup = () => {
try {
child.kill('SIGHUP')
/* c8 ignore start */
} catch (_) {
// SIGHUP is weird on windows
child.kill('SIGTERM')
}
/* c8 ignore stop */
}