Merged
Conversation
Owner
|
Thank you. The builds are currently failing. Any chance you could have a look? |
This change allows binocle to work on my system. Before it was crashing with ``` [2023-10-28T12:55:23Z WARN wgpu_hal::vulkan::instance] \ create_instance: VkError(ERROR_INCOMPATIBLE_DRIVER) Error: No suitable `wgpu::Adapter` found. ``` Based off of https://github.com/parasyte/pixels/tree/main/examples/minimal-egui/src
OttoAllmendinger
force-pushed
the
update-libs
branch
from
755d5da to
2b472e3
Compare
Contributor
Author
|
I fixed the formatting now but I don't understand the build error for |
sharkdp
approved these changes
Dec 1, 2023
Owner
sharkdp
left a comment
sharkdp
left a comment
There was a problem hiding this comment.
Thank you very much. I'll disable the windows-gnu build for now. We still have the mvsc build on windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows binocle to work on my system. Before it was crashing with
Based off of https://github.com/parasyte/pixels/tree/main/examples/minimal-egui/src