You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Verify the Electron zips the release build packages against the lockfile-pinned checksums.json #363
Found in the review of #360. This predates that PR.
Today: all three thin-app builders call @electron/packager without a download or electronZipDir option:
scripts/build-thin-app.mjs (around :212);
scripts/build-linux-thin-app.mjs (around :133);
scripts/build-windows-thin-app.mjs (around :169).
Packager 20.3.0 therefore calls @electron/get 5.0.0 with no checksums. Its validateArtifact then downloads the release's live SHASUMS256.txt (bypassing the cache) and checks the zip against that.
The lockfile-pinned electron npm package ships a checksums.json, but no build step uses it. Electron 43's package has no install script, and install.js runs only when something does require('electron'), which no build step does.
Consequence: each shipped Electron zip is checked only against a hash list fetched from the same GitHub release.
That catches corruption, but if a release's zip and its SHASUMS256.txt were both replaced, the build would accept them.
Nothing ties the bytes we ship to what was reviewed when we bumped the version. The CI identity probes check version strings, not bytes.
Activity
Retarget Electron to 43.8.3, the newest 43.x release
Update Electron to 43.8.3 for its security fixes (#360)
Refuse Electron download overrides from the environment (#363 review)
Count every mention of download and electronVersion in the pin (#363)
Verify packaged Electron zips against the lockfile-pinned checksums.j…
Merge origin/main (#367) into issue-362-node-24.22.0
Move Electron to 43.8.4, which embeds Node 24.22.1 (#371) (#377)