COMPAT: Add a numpy<2 pin to install requirements for 2.0.x #1975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwtoews
reviewed
Jan 27, 2024
Member
|
It seems there is a bit of work needed for |
Member
Author
|
Did some additional fixes in #1977, will update this PR now |
Pull Request Test Coverage Report for Build 7872611538Details
💛 - Coveralls |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1972 for the details.
Current Shapely wheels for 2.0.x (and for an upcoming 2.0.3 release) are not compatible with future numpy 2.0 packages (if you install shapely now in an environment with nightly numpy, it fails to import), therefore it is recommended to add this upper pin now for releases.
We will keep the more flexible pin on the development branch, assuming by the time we release shapely 2.1, numpy 2.0 will be out and we can build shapely 2.0 to be compatible with all numpy versions.