Walkthrough

The pull request updates the shakapacker dependency in the dummy app's package.json from a local yalc reference to a published semantic version range, removing a development artifact.

Changes

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 The yalc's been packed away with care,
Now shakapacker floats in the air,
From local files to the registry's grace,
Dependencies find their proper place!

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Greptile Summary

Cleans up a yalc development artifact that was accidentally committed to spec/dummy. The file:.yalc/shakapacker dependency is replaced with the published ^9.6.1 from npm, and both package-lock.json and yarn.lock are regenerated to resolve from the registry instead of the local .yalc path.

• Replaced local file:.yalc/shakapacker with ^9.6.1 in spec/dummy/package.json
• Regenerated spec/dummy/package-lock.json — removes .yalc/shakapacker node entries and resolves [email protected] from npm with integrity hash
• Regenerated spec/dummy/yarn.lock — cleans up duplicate peer-dependency specifier ranges introduced by the yalc link and adds missing platform-specific optional dependency entries
• No functional changes to project behavior; this is a lockfile hygiene fix

Confidence Score: 5/5

• This PR is safe to merge — it's a straightforward cleanup of an accidentally committed local dependency reference.
• The change is minimal and well-scoped: a single dependency specifier fix in package.json with regenerated lockfiles. The published [email protected] version matches the root package.json version. No code logic changes, no new dependencies, no yalc references remain in the lockfiles.
• No files require special attention.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["spec/dummy/package.json"] -->|"before: file:.yalc/shakapacker"| B["Local .yalc directory\n(version 9.6.0-rc.3)"]
    A -->|"after: ^9.6.1"| C["npm registry\n([email protected])"]
    A --> D["package-lock.json\n(regenerated)"]
    A --> E["yarn.lock\n(regenerated)"]
    D --> C
    E --> C
    style B fill:#f96,stroke:#333,color:#000
    style C fill:#6f9,stroke:#333,color:#000

_{Last reviewed commit: 2286bcc}

Review

This is a clean, well-scoped fix that removes accidentally-committed yalc artifacts from the repo. The lockfile regenerations look correct — both now resolve shakapacker from the npm registry at 9.6.1 rather than a local .yalc path.

One minor concern: The spec/dummy/package.json engine requirement ("node": ">=18.0.0") is inconsistent with what [email protected] actually requires (>= 20, per the root package.json). This means CI could pass on Node 18 even though the package itself doesn't support it. Worth bumping to >=20.0.0 to stay in sync.

One workflow question (left inline): Using ^9.6.1 points spec/dummy at the published npm package, not the local source. If developers change the JS package and run bundle exec rspec, they'd be testing against the published version. Whether to use `file:../.." instead depends on the intended workflow — happy to discuss if this was a deliberate decision.

Review

Good cleanup — removing the yalc artifact is the right call.

One concern worth discussing: the PR description says it replaces the dependency with ^9.6.1 (caret range), but the actual package.json change uses 9.6.1 (exact pin, no caret). This differs from every other dependency in the file, which all use ^.

More importantly, an exact-pinned published version means:

• spec/dummy now tests against the published npm package rather than the local source. Any JS changes in this repo won't be reflected in the dummy app until a new version is published and this pin is manually bumped.
• Each new release requires a manual update here.

Suggested alternative: "shakapacker": "file:../.."} — this references the local npm package (the root package.json), which is what the yalc approach was approximating in the first place. It's cleaner and ensures spec/dummy always tests the current source.

If there's a reason the local-file reference was abandoned (e.g., CI resolution issues), it would be worth documenting that decision. If not, `file:../.." seems like the more correct fix.