Walkthrough

Modified the extract_changelog_section method in the release rake file to skip the version header line when extracting changelog content. Changed whitespace trimming from rstrip to strip for more comprehensive cleanup of surrounding whitespace.

Changes

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A snippet of code, so small yet so neat,
The header line skipped, the slice now complete,
With strip in its place, the whitespace takes flight,
The changelog extracted, precisely just right!

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Review: Strip changelog version header from GitHub release notes

Overall: LGTM with a minor note.

The change is correct and focused. Before, extract_changelog_section included the version header line (e.g. ## [v9.6.1] - March 8, 2026) in the returned string, causing it to appear as body text in GitHub releases alongside the already-displayed tag title. Skipping it is the right fix.

Behavioral observation — rstrip to strip

The switch from rstrip to strip is appropriate here. After removing the header line, the next line in the section is typically a blank newline, so strip removes that leading blank line from the notes body. Without it, the release notes would start with a blank line. Worth noting that extract_changelog_section is also used by expected_bump_type_from_changelog_section (version-policy check) and several nil-presence checks — none of those callers are sensitive to leading whitespace, so no regression there.

Missing test coverage (pre-existing gap)

extract_changelog_section has no RSpec coverage. Given this function now does slightly more nuanced work (skipping a line, applying strip), a unit test would help prevent regressions. Not a blocker since the gap is pre-existing, but worth a follow-up.

Empty-section edge case (pre-existing)

If a CHANGELOG version section has only a header and no content, strip returns an empty string. Ruby treats an empty string as truthy, so the nil-guard in prepare_github_release_context would pass and create a GitHub release with empty notes. Unrelated to this PR but worth keeping in mind.

Greptile Summary

This PR fixes a cosmetic duplication in GitHub release notes: extract_changelog_section previously included the ## [vX.Y.Z] - Date header in the returned string, causing it to render redundantly alongside GitHub's own release title. The fix is a two-line change — start slicing from start_index + 1 to skip the header, and use .strip to also remove the leading blank line that typically follows the header in the CHANGELOG.

• Skips version header: lines[(start_index + 1)...end_index] instead of lines[start_index...end_index], removing the ## [vX.Y.Z] line from release body content.
• .strip usage: Removes both leading and trailing whitespace, which is necessary because the first content line is typically preceded by a blank line after the header.
• No test coverage exists for extract_changelog_section, but this is a pre-existing gap and the logic is straightforward to verify manually via the suggested dry-run task.

Confidence Score: 5/5

• This PR is safe to merge — it is a minimal, focused fix with no risk of breakage.
• The change is two lines: shifting the slice start by one index to skip the version header, and using .strip to clean up the leading blank line that now appears at the start of the content. Both changes are correct, the logic is easy to verify by inspection against the CHANGELOG format, and the stated dry-run test plan provides a practical sanity check before the live re-sync.
• No files require special attention

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["extract_changelog_section(changelog_path, npm_version)"] --> B["Read CHANGELOG.md lines"]
    B --> C{"Find start_index\nmatching ## [vX.Y.Z]"}
    C -- "Not found" --> D["return nil"]
    C -- "Found" --> E["Find end_index\n(next ## [ header or EOF)"]
    E --> F["lines[start_index+1...end_index].join.strip\n(skip header line, strip leading/trailing whitespace)"]
    F --> G["Return section content\n(no version header)"]
    G --> H["prepare_github_release_context"]
    H --> I{"notes present?"}
    I -- "nil" --> J["abort with error"]
    I -- "content" --> K["Build release_context hash\ntag, title, notes, prerelease"]
    K --> L["publish_or_update_github_release"]
    L --> M["Write notes to Tempfile"]
    M --> N{"Release exists\non GitHub?"}
    N -- "Yes" --> O["gh release edit\n--notes-file tmp.path"]
    N -- "No" --> P["gh release create\n--notes-file tmp.path"]

_{Last reviewed commit: c643c56}