Supersede #906: entry shape test with lint-compliant matcher by justin808 · Pull Request #910 · shakacode/shakapacker

justin808 · 2026-02-15T10:45:57Z

Supersedes #906. Closes #792.

Summary

carry forward the entry-shape regression test from Add entry shape regression test for type narrowing #906
fix ESLint jest/prefer-strict-equal by using toStrictEqual for the matcher assertion

Validation

yarn test test/package/environments/base.test.js
yarn eslint test/package/environments/base.test.js --max-warnings 0

Notes

This PR does not add commits to Add entry shape regression test for type narrowing #906's existing branch.

coderabbitai · 2026-02-15T10:46:08Z

Warning

Rate limit exceeded

@justin808 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 14 minutes and 4 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch codex/supersede-906-entry-shape

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

greptile-apps · 2026-02-15T10:48:05Z

Greptile Summary

This PR adds a regression test that explicitly asserts the shape of webpack entry values produced by getEntryObject() in package/environments/base.ts. Single-file entries must be strings and multi-file entries must be arrays of strings — a contract that downstream TypeScript consumers rely on for type narrowing. The test uses toStrictEqual with expect.arrayContaining / expect.any(String) to satisfy the project's jest/prefer-strict-equal ESLint rule.

Adds "keeps entry value shapes stable for TypeScript narrowing" test in test/package/environments/base.test.js
Supersedes PR Add entry shape regression test for type narrowing #906 by switching from toEqual to toStrictEqual
Closes issue Validate type narrowing for Entry type in base.ts #792

Confidence Score: 5/5

This PR is safe to merge — it only adds a new test case with no production code changes.
The change is a single, well-scoped test addition (11 lines) that uses established Jest patterns and complies with the project's lint rules. No production code is modified. The assertions correctly validate the entry shapes documented in the source (package/environments/base.ts lines 50-86).
No files require special attention.

Important Files Changed

Filename	Overview
test/package/environments/base.test.js	Adds a new test case that explicitly asserts entry value shapes (string for single-file entries, array of strings for multi-file entries). Uses `toStrictEqual` to comply with `jest/prefer-strict-equal` lint rule. No issues found.

Flowchart

flowchart TD
    A[getEntryObject in base.ts] -->|single file| B["entries[name] = assetPath\n(string)"]
    A -->|multiple files same name| C["entries[name] = [path1, path2]\n(string[])"]
    B --> D[New shape test]
    C --> D
    D -->|asserts| E["typeof application === 'string'"]
    D -->|asserts| F["Array.isArray(multi_entry) === true"]
    D -->|asserts| G["multi_entry contains String elements"]

_{Last reviewed commit: 25442b7}

justin808 · 2026-02-15T11:14:27Z

Superseded by #919, which preserves the #910 test fix and adds the current lint-unblock commit.

Supersedes #910. Includes: - original entry-shape type narrowing regression test - strict matcher fix from #910 - .prettierignore workflow-file ignore update (with wording fix) to avoid unrelated lint failures Closes #792  --- > [!NOTE] > **Low Risk** > Adds a regression test around `baseConfig.entry` value types; no production code changes, so risk is limited to potential test brittleness across environments. > > **Overview** > Adds a new Jest regression test in `test/package/environments/base.test.js` to ensure `baseConfig.entry` values remain consistently typed as either *non-empty strings* or *arrays of strings*, preserving stable shapes for TypeScript narrowing. > > No runtime behavior is changed; this strictly tightens test coverage around entrypoint generation. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit f00999e. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup>   ## Summary by CodeRabbit * **Tests** * Added test coverage to ensure configuration type stability for improved reliability.  --------- Co-authored-by: Claude Opus 4.7 (1M context) <[email protected]>

* origin/main: (22 commits) docs: add Dependabot configuration guide (#1094) Sync address-review prompt with upstream PR #16 (#1098) Supersede #910: entry shape test with lint unblock (#919) fix: align rspack v2 peer deps and installer defaults (#1091) docs: update README and guides for Shakapacker v10 (#1092) Release 10.0.0 Update CHANGELOG.md for v10.0.0 (#1089) Release 10.0.0-rc.1 Update CHANGELOG.md for v10.0.0-rc.1 (#1087) Supersede #961 by using pack-config-diff (#973) Add final summary output to rake release (#1041) Add bin/setup to install development deps (#1039) Release 10.0.0-rc.0 Use npx release-it to avoid mise shim failures (#1040) Fix Nokogiri build failure on Ruby 3.4.6 (#1038) Update CHANGELOG.md for v10.0.0-rc.0 (#1037) Update rspack dev deps to 2.0.0-rc.0 (#1036) Fix stale and broken documentation across Shakapacker guides (#1023) Allow webpack-cli v7 in peer dependencies (#1021) refactor: simplify resolving js peer versions when installing (#1034) ... # Conflicts: # package.json

* origin/main: docs: add Dependabot configuration guide (#1094) Sync address-review prompt with upstream PR #16 (#1098) Supersede #910: entry shape test with lint unblock (#919) fix: align rspack v2 peer deps and installer defaults (#1091) docs: update README and guides for Shakapacker v10 (#1092) Release 10.0.0 Update CHANGELOG.md for v10.0.0 (#1089) Release 10.0.0-rc.1 Update CHANGELOG.md for v10.0.0-rc.1 (#1087) Supersede #961 by using pack-config-diff (#973) # Conflicts: # CHANGELOG.md # Rakefile

justin808 added 2 commits February 15, 2026 00:45

test: assert entry value shapes for type narrowing

d98277c

test: use strict equality matcher for entry shape assertion

25442b7

justin808 mentioned this pull request Feb 15, 2026

Add entry shape regression test for type narrowing #906

Closed

justin808 mentioned this pull request Feb 15, 2026

Supersede #910: entry shape test with lint unblock #919

Merged

justin808 closed this Feb 15, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Supersede #906: entry shape test with lint-compliant matcher#910

Supersede #906: entry shape test with lint-compliant matcher#910
justin808 wants to merge 2 commits intomainfrom
codex/supersede-906-entry-shape

justin808 commented Feb 15, 2026

Uh oh!

coderabbitai Bot commented Feb 15, 2026

Rate limit exceeded

Uh oh!

greptile-apps Bot commented Feb 15, 2026

Uh oh!

justin808 commented Feb 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

justin808 commented Feb 15, 2026

Summary

Validation

Notes

Uh oh!

coderabbitai Bot commented Feb 15, 2026

Rate limit exceeded

Uh oh!

greptile-apps Bot commented Feb 15, 2026

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Flowchart

Uh oh!

justin808 commented Feb 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant