Add entry shape regression test for type narrowing#906
Add entry shape regression test for type narrowing#906
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryAdded a regression test to lock in entry value shape expectations (
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: e71003b |
|
Superseded by #910, which carries the same test intent and fixes the ESLint failure on a fresh branch. |
|
Closing in favor of #910. |
|
Superseded by #910, which carries the same test intent and fixes the ESLint prefer-strict-equal failure on a fresh branch. |
Closes #792
Summary
test/package/environments/base.test.jsto verify entry value shape expectationsstringand multi-file entries staystring[]Why
package/environments/base.tsnow relies on TypeScript narrowing for existing entry values. This test locks in the runtime shape assumptions that underpin that narrowing path.Validation
yarn test test/package/environments/base.test.js