Combine workflow lint fix with privateOutputPath fix#896
Combine workflow lint fix with privateOutputPath fix#896
Conversation
Fixes the Linting CI job that has been failing on main since these workflow files were added with single-quoted strings and trailing newlines. Co-Authored-By: Claude Opus 4.6 <[email protected]>
The private_output_path feature (PR #592) added the Ruby-side method but not the JS-side computed property. This caused consumers like React on Rails to always get undefined for config.privateOutputPath, breaking config sync and producing false warnings on every build. Follows the same pattern as config.outputPath: resolves the raw YAML string to an absolute path. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Verifies privateOutputPath is undefined when private_output_path is absent from shakapacker.yml, using the same SHAKAPACKER_CONFIG override pattern as the manifestPath tests. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR combines Prettier formatting fixes from #892 with the Changes
The implementation correctly follows the pattern used for Confidence Score: 5/5
Important Files Changed
Flowchartflowchart TD
A[Load YAML Config] --> B{private_output_path set?}
B -->|Yes| C[Resolve to absolute path]
B -->|No| D[privateOutputPath = undefined]
C --> E[config.privateOutputPath = resolve path]
D --> F[Skip assignment]
E --> G[Export config]
F --> G
style C fill:#90EE90
style E fill:#90EE90
style D fill:#FFE4B5
style F fill:#FFE4B5
Last reviewed commit: 74d582b |
|
Superseded by #902. This PR failed due workflow-file validation, so the replacement keeps only the privateOutputPath fix and tests. |
|
Closing as superseded by #902. |
|
Clarification: this was superseded by #902 because workflow-file changes caused a Claude review workflow validation failure. |
2 participants
Summary
.github/workflows/claude-code-review.yml,.github/workflows/claude.yml)privateOutputPathJS config fix from fix: add privateOutputPath computed property to JS config #891This combines the two dependent PRs so the private output path fix can pass lint and merge cleanly.
Closes #890.
Supersedes #891 and #892.
Validation