Rename Webpacker instances to shakapacker#245
Merged
justin808 merged 21 commits intoshakapacker-v6.7from Mar 13, 2023
Merged
Conversation
ahangarha
force-pushed
the
webpacker-to-shakapacker
branch
2 times, most recently
from
b062c7a to
41a761f
Compare
ahangarha
changed the title
ahangarha
force-pushed
the
webpacker-to-shakapacker
branch
3 times, most recently
from
dde3fb3 to
159bd9d
Compare
vaukalak
reviewed
Feb 13, 2023
vaukalak
reviewed
Feb 13, 2023
vaukalak
reviewed
Feb 13, 2023
justin808
requested changes
Feb 14, 2023
ahangarha
force-pushed
the
webpacker-to-shakapacker
branch
2 times, most recently
from
fb5eeb2 to
ea4ddfb
Compare
vaukalak
reviewed
Feb 24, 2023
Contributor
|
Otherwise LGTM |
ahangarha
force-pushed
the
webpacker-to-shakapacker
branch
from
2776578 to
60ccf1c
Compare
ahangarha
force-pushed
the
webpacker-to-shakapacker
branch
from
756e056 to
4cc8b9f
Compare
justin808
requested changes
Mar 10, 2023
Member
justin808
left a comment
justin808
left a comment
There was a problem hiding this comment.
Make a branch called
webpacker-v6.7
otherwise this PR will then reflect all the changes on the other branch
and change base of this PR to that branch.
merge after fixes
then change other PR to be off of this new branch
then merge
then I'll push pre-release on the branch
| _Please add entries here for your pull requests that are not yet released._ | ||
|
|
||
| ### Breaking changes | ||
| - Rename Webpacker to Shakapacker in entire project including config files, binstubs, environment variables,... [PR157](https://github.com/shakacode/shakapacker/pull/157) by [ahangarha](https://github.com/ahangarha) |
Member
There was a problem hiding this comment.
But 6.x is not a breaking change.
Contributor
Author
There was a problem hiding this comment.
This PR is breaking. The other PR makes these changes non-breaking.
Some background:
We were going to make a breaking release (v7) out of this branch. Later we decided to add backward compatibility for perhaps the last v6.x.
Contributor
Author
There was a problem hiding this comment.
Changelog will get updated in the other PR.
ahangarha
changed the title
justin808
approved these changes
Mar 13, 2023
ahangarha
added a commit
that referenced
this pull request
Apr 19, 2023
* Use Shakapacker module, config files, and env variables * Update tests to use shakapacker module and config files * Rename rake files to shakapacker * rename binstubs in test app * Update rake tasks and their specs * Update shakapacker_precompile entry in config file * Fix installation scripts * Replace remaining instances of webpacker * Update JS code and tests * Update description of clean rake tasks * Update changelog * Add v7 upgrade guide * Change Webpacker reference to Shakapacker in docs * Update Readme and contribution guide for shakapacker
ahangarha
added a commit
that referenced
this pull request
Apr 27, 2023
* Rename Webpacker instances to shakapacker (#245) * Add backward compatibility (#252) * Update docs for spelling change (#263) * Fix backward compatibility for setting WEBPACKER_CONFIG in webpack.config.js (#266) * Remove redundant code for enhancing precompile task (#270) * Update webpack dev server configuration (#276) * Stop stripping top level dirs (#283) * Improve source_entry_path robustness (#284) --------- Co-authored-by: Tom Dracz <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should cover the following with backward compatibility:
config/shakapacker.yml)shakapackernamespace.Closes #157