Skip to content

Remove namespace for npm, fix need to require 'webpacker'#14

Merged
justin808 merged 1 commit intomasterfrom
justin808/fix-renaming-issue
Jan 19, 2022
Merged

Remove namespace for npm, fix need to require 'webpacker'#14
justin808 merged 1 commit intomasterfrom
justin808/fix-renaming-issue

Conversation

@justin808
Copy link
Copy Markdown
Member

Changed package name to shakapacker from @shakacode/shakapacker.

Changed package name to `shakapacker` from @shakacode/shakapacker.
@justin808 justin808 merged commit 854df7e into master Jan 19, 2022
@justin808 justin808 deleted the justin808/fix-renaming-issue branch January 19, 2022 22:09
justin808 added a commit that referenced this pull request Mar 19, 2026
…#14

Updates the address-review command with improvements from upstream:
- Add $ARGUMENTS placement to Step 2
- Add node_id fields to comment fetches for thread resolution
- Add jq -s (slurp) to paginated gh api calls for proper aggregation
- Add GraphQL query to fetch review thread metadata and thread_id
- Add filtering for already-resolved threads
- Document review summary body reply path via general PR comments
- Document GraphQL pagination limitation for review threads

Co-Authored-By: Claude Haiku 4.5 <[email protected]>
justin808 added a commit that referenced this pull request Mar 19, 2026
Syncs the address-review command with improvements from
shakacode/claude-code-commands-skills-agents#14.

**Key changes:**
- Add `node_id` fields to all comment fetches for thread resolution
- Add `jq -s` (slurp) to paginated `gh api` calls for proper multi-page
aggregation
- Add GraphQL query to fetch review thread metadata and `thread_id`
- Add filtering for already-resolved threads
- Document review summary body reply path via general PR comments
- Document GraphQL pagination limitation for review threads with >100
comments

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Low risk documentation-only changes, but they alter the prescribed
GitHub API/GraphQL workflows for fetching/replying/resolving review
threads and could affect anyone automating this process if followed
incorrectly.
> 
> **Overview**
> Updates the `address-review` command instructions to fetch richer PR
feedback data and better support thread resolution. It adds `node_id`
and proper `--paginate` aggregation (`jq -s`) to comment fetches,
introduces a GraphQL lookup to map comments to `thread_id`/`isResolved`,
and documents skipping already-resolved threads.
> 
> Clarifies reply behavior by distinguishing inline review comments
(reply via `/replies`) from review summary bodies (reply via general PR
issue comments), tightens triage/task formatting guidance, and notes the
GraphQL inner-pagination limitation for threads with >100 comments.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
614a78e. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Co-authored-by: Claude Haiku 4.5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant