Add bin/setup to install development deps#1039
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 1 minutes and 29 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4909a32840
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if [[ -x "$ROOT_DIR/bin/conductor-exec" ]]; then | ||
| "$ROOT_DIR/bin/conductor-exec" "$@" |
There was a problem hiding this comment.
Avoid unconditional conductor-exec routing
run_cmd always prefers bin/conductor-exec whenever the file exists and is executable, but bin/conductor-exec is hard-pinned to #!/bin/zsh; in environments without /bin/zsh (common in minimal Linux images), every ensure_tool probe fails and reports tools as missing even when ruby/bundle/node are installed, so bin/setup is unusable. This should fall back to direct execution when the wrapper cannot actually be run.
Useful? React with 👍 / 👎.
Greptile SummaryAdds
Confidence Score: 5/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A([bin/setup]) --> B[Set ROOT_DIR & cd to it]
B --> C{conductor-exec\nexecutable?}
C -->|yes| D[route via conductor-exec]
C -->|no| E[run command directly]
D --> F[mise exec available?]
F -->|yes| G[mise exec -- cmd]
F -->|no| H[direct exec]
B --> I[ensure_tool ruby]
I --> J[ensure_tool bundle]
J --> K[ensure_tool node]
K --> L[ensure_tool yarn]
L --> M[bundle install]
M --> N[yarn install]
N --> O([done])
style C fill:#f9f,stroke:#333
style D fill:#bbf,stroke:#333
style E fill:#bfb,stroke:#333
Reviews (1): Last reviewed commit: "Add bin/setup for development deps" | Re-trigger Greptile |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Overly broad
conductor-execrouting misreports missing tools- Updated
bin/setupto route throughbin/conductor-execonly whenmiseis available, preventing false missing-tool errors on systems without zsh.
- Updated
Or push these changes by commenting:
@cursor push c3cb956985
Preview (c3cb956985)
diff --git a/bin/setup b/bin/setup
--- a/bin/setup
+++ b/bin/setup
@@ -5,7 +5,7 @@
cd "$ROOT_DIR"
run_cmd() {
- if [[ -x "$ROOT_DIR/bin/conductor-exec" ]]; then
+ if command -v mise >/dev/null 2>&1 && [[ -x "$ROOT_DIR/bin/conductor-exec" ]]; then
"$ROOT_DIR/bin/conductor-exec" "$@"
else
"$@"You can send follow-ups to this agent here.
| "$ROOT_DIR/bin/conductor-exec" "$@" | ||
| else | ||
| "$@" | ||
| fi |
There was a problem hiding this comment.
Overly broad conductor-exec routing misreports missing tools
Medium Severity
run_cmd unconditionally routes through bin/conductor-exec whenever the file is executable, but conductor-exec requires /bin/zsh. On systems without zsh (common on Linux servers, CI, Docker), the file passes the -x check yet fails to execute. In ensure_tool, this failure is silently caught (output redirected to /dev/null) and misreported as the tool being unavailable (e.g., "ruby is not available"). The existing conductor-setup.sh avoids this by gating on VERSION_MANAGER == "mise" before routing through conductor-exec, since conductor-exec only adds value when mise is present.
Additional Locations (1)
* origin/main: (22 commits) docs: add Dependabot configuration guide (#1094) Sync address-review prompt with upstream PR #16 (#1098) Supersede #910: entry shape test with lint unblock (#919) fix: align rspack v2 peer deps and installer defaults (#1091) docs: update README and guides for Shakapacker v10 (#1092) Release 10.0.0 Update CHANGELOG.md for v10.0.0 (#1089) Release 10.0.0-rc.1 Update CHANGELOG.md for v10.0.0-rc.1 (#1087) Supersede #961 by using pack-config-diff (#973) Add final summary output to rake release (#1041) Add bin/setup to install development deps (#1039) Release 10.0.0-rc.0 Use npx release-it to avoid mise shim failures (#1040) Fix Nokogiri build failure on Ruby 3.4.6 (#1038) Update CHANGELOG.md for v10.0.0-rc.0 (#1037) Update rspack dev deps to 2.0.0-rc.0 (#1036) Fix stale and broken documentation across Shakapacker guides (#1023) Allow webpack-cli v7 in peer dependencies (#1021) refactor: simplify resolving js peer versions when installing (#1034) ... # Conflicts: # package.json



Summary
bin/setupscript for local development setup.ruby,bundle,node, andyarn, then runsbundle installandyarn install.bin/conductor-execwhen available to respect workspace-managed tool versions.Pull Request checklist
Other Information
bash -n bin/setupwas run to validate script syntax.Note
Low Risk
Adds a small dev-only setup script and a documentation update; no runtime or production code paths are affected.
Overview
Adds a new
bin/setupscript to bootstrap local development by verifyingruby,bundle,node, andyarnare available, then runningbundle installandyarn install(routing commands throughbin/conductor-execwhen present).Updates
CONTRIBUTING.mdto preferbin/setupfor installing dev dependencies, while still documenting the manualbundle install/yarn installequivalent and the optionalnpx huskyhooks step.Written by Cursor Bugbot for commit 56bfa47. This will update automatically on new commits. Configure here.