Walkthrough

The template's peer dependency version normalization logic is simplified. Instead of conditionally preserving version prefixes and extracting major versions, the new approach extracts the substring after the last || separator and treats it as the installable version, changing which dependencies are categorized as regular vs. dev dependencies.

Changes

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A version string once tangled tight,
With carets, tildes—quite a sight,
Now split at || with cleaner grace,
Much simpler rules win the race!
Dependencies sorted, logic refined—
A tidier template we now find. 🎀

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Greptile Summary

This PR simplifies the peer dependency version-resolution logic inside the install template. The original code conditionally branched on version string format — preserving the full constraint as-is for ^/~-prefixed versions, or extracting a bare major version for everything else. The new code unconditionally splits on || and takes the last (latest) constraint, stripped of whitespace.

What changed:

• The 9-line conditional block in peers.each is replaced with two lines: version.split(\"|\").last.strip and the entry assignment.
• For single-constraint versions (e.g. \"^5.76.0\"), behaviour is identical — split(\"||\") returns a one-element array so last returns the original string.
• For multi-constraint versions (e.g. \"^4.9.2 || ^5.0.0 || ^6.0.0\" for webpack-cli), the old code passed the full || range to the package manager; the new code passes only the latest constraint (^6.0.0). Both approaches result in installing the highest compatible release on a fresh install.
• Every version string present in lib/install/package.json is handled correctly by the new logic, including the no-space variant \"^9.0.0 || ^10.0.0|| ^11.0.0\" for compression-webpack-plugin (.strip handles the surrounding whitespace after splitting).

Minor note: The PR description ends mid-sentence ("I came across this while checking out bug"), and the CHANGELOG checklist item is left unchecked rather than crossed out — though per project guidelines refactors do not require changelog entries, so it should be struck through with ~…~ to match the other checklist items.

Confidence Score: 5/5

Safe to merge — the simplification is logically equivalent for all version strings in the current lib/install/package.json.

No P0/P1 issues found. The new two-line implementation correctly handles every version format present in the codebase. The only remaining remarks are a cosmetic PR-description nit and a checklist housekeeping item, both P2 at most.

No files require special attention.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["peers.each — package + version string"] --> B["version.split('||').last.strip"]
    B --> C{Single constraint?}
    C -- "e.g. '^5.76.0'" --> D["Returns full string unchanged\ne.g. '^5.76.0'"]
    C -- "e.g. '^4.9.2 || ^5.0.0 || ^6.0.0'" --> E["Returns last constraint stripped\ne.g. '^6.0.0'"]
    D --> F["entry = 'package@version'"]
    E --> F
    F --> G{Dev dependency?}
    G -- Yes --> H["dev_dependencies_to_add"]
    G -- No --> I["dependencies_to_add"]
    H --> J["manager.add! type: :dev"]
    I --> K["manager.add! type: :production"]

_{Reviews (1): Last reviewed commit: "refactor: simplify resolving js peer ver..." | Re-trigger Greptile}

Thanks @G-Rath!