Fix cross-platform path handling and YAML serialization issues

justin808 · claude · justin808 · commit 0b2275f4de80 · 2025-10-07T19:53:56.000-10:00
**Path handling fixes:** - Replace string startsWith checks with path.relative for proper cross-platform path validation - Fix makePathRelative to use path.relative instead of hardcoded "/" separator - Update validateOutputPath to use os.tmpdir() instead of hardcoded "/tmp" - Add proper isAbsolute guards to prevent false positives on Windows **YAML serialization fixes:** - Fix multiline string indentation to use dynamic indent based on nesting level - Fix array item indentation to properly indent nested objects and multiline strings - Emit array markers on separate lines for complex content with proper 2-space sub-indentation - Fix function source escaping to use serializeString helper for proper quote/special char handling **TypeScript config loading:** - Add ts-node/register/transpile-only support for loading .ts config files - Handle ES module default exports by checking for .default property - Prevent ERR_UNKNOWN_FILE_EXTENSION errors when requiring TypeScript configs All changes maintain backward compatibility and improve reliability across platforms. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
diff --git a/package/configExporter/cli.ts b/package/configExporter/cli.ts
@@ -273,9 +273,21 @@ async function loadConfigsForEnv(
   console.log(`[Config Exporter] Bundler: ${bundler}`)
 
   // Load the config
+  // Register ts-node for TypeScript config files
+  if (configFile.endsWith(".ts")) {
+    // eslint-disable-next-line @typescript-eslint/no-var-requires
+    require("ts-node/register/transpile-only")
+  }
+
   // eslint-disable-next-line @typescript-eslint/no-var-requires
   delete require.cache[require.resolve(configFile)]
-  const loadedConfig = require(configFile)
+  // eslint-disable-next-line @typescript-eslint/no-var-requires
+  let loadedConfig = require(configFile)
+
+  // Handle ES module default export
+  if (typeof loadedConfig === "object" && "default" in loadedConfig) {
+    loadedConfig = loadedConfig.default
+  }
 
   // Determine config type and split if array
   const configs: any[] = Array.isArray(loadedConfig)
diff --git a/package/configExporter/fileWriter.ts b/package/configExporter/fileWriter.ts
@@ -1,5 +1,6 @@
 import { writeFileSync, mkdirSync, existsSync } from "fs"
-import { resolve, dirname } from "path"
+import { resolve, dirname, relative, isAbsolute } from "path"
+import { tmpdir } from "os"
 import { FileOutput } from "./types"
 
 /**
@@ -73,9 +74,13 @@ export class FileWriter {
     const absPath = resolve(outputPath)
     const cwd = process.cwd()
 
-    if (!absPath.startsWith(cwd) && !absPath.startsWith("/tmp")) {
+    const isWithin = (base: string, target: string) => {
+      const rel = relative(base, target)
+      return rel === "" || (!rel.startsWith("..") && !isAbsolute(rel))
+    }
+    if (!isWithin(cwd, absPath) && !isWithin(tmpdir(), absPath)) {
       console.warn(
-        `[Config Exporter] Warning: Writing to ${absPath} which is outside current directory`
+        `[Config Exporter] Warning: Writing to ${absPath} which is outside current directory (${cwd}) or temp (${tmpdir()})`
       )
     }
   }
diff --git a/package/configExporter/yamlSerializer.ts b/package/configExporter/yamlSerializer.ts
@@ -1,5 +1,6 @@
 import { ConfigMetadata } from "./types"
 import { getDocForKey } from "./configDocs"
+import { relative, isAbsolute } from "path"
 
 /**
  * Serializes webpack/rspack config to YAML format with optional inline documentation.
@@ -59,7 +60,7 @@ export class YamlSerializer {
     }
 
     if (typeof value === "string") {
-      return this.serializeString(value)
+      return this.serializeString(value, indent)
     }
 
     if (typeof value === "function") {
@@ -81,14 +82,15 @@ export class YamlSerializer {
     return String(value)
   }
 
-  private serializeString(str: string): string {
+  private serializeString(str: string, indent: number = 0): string {
     // Make absolute paths relative for cleaner output
     const cleaned = this.makePathRelative(str)
 
     // Handle multiline strings
     if (cleaned.includes("\n")) {
       const lines = cleaned.split("\n")
-      return "|\n" + lines.map((line) => "  " + line).join("\n")
+      const lineIndent = " ".repeat(indent + 2)
+      return "|\n" + lines.map((line) => lineIndent + line).join("\n")
     }
 
     // Escape strings that need quoting
@@ -111,18 +113,19 @@ export class YamlSerializer {
     const source = fn.toString()
 
     // Compact the source: remove extra whitespace but keep it readable
-    const compacted = source
+    let compacted = source
       .split("\n")
       .map((line) => line.trim())
       .filter((line) => line.length > 0)
       .join(" ")
 
     // For very long functions, truncate with ellipsis
     if (compacted.length > 500) {
-      return `"${compacted.substring(0, 500)}..."`
+      compacted = compacted.substring(0, 500) + "..."
     }
 
-    return `"${compacted}"`
+    // Use serializeString to properly escape the function source
+    return this.serializeString(compacted)
   }
 
   private serializeArray(arr: any[], indent: number, keyPath: string): string {
@@ -132,15 +135,26 @@ export class YamlSerializer {
 
     const lines: string[] = []
     const itemIndent = " ".repeat(indent + 2)
+    const contentIndent = " ".repeat(indent + 4)
 
     arr.forEach((item, index) => {
       const itemPath = `${keyPath}[${index}]`
-      const serialized = this.serializeValue(item, indent + 2, itemPath)
+      const serialized = this.serializeValue(item, indent + 4, itemPath)
 
       if (typeof item === "object" && !Array.isArray(item) && item !== null) {
-        // For objects in arrays, use '- key: value' format
-        lines.push(`${itemIndent}- ${serialized.trim()}`)
+        // For objects in arrays, emit marker on its own line and indent content
+        lines.push(`${itemIndent}-`)
+        serialized.split("\n").forEach((line: string) => {
+          lines.push(contentIndent + line)
+        })
+      } else if (serialized.includes("\n")) {
+        // For multiline values, emit marker on its own line and indent content
+        lines.push(`${itemIndent}-`)
+        serialized.split("\n").forEach((line: string) => {
+          lines.push(contentIndent + line)
+        })
       } else {
+        // For simple values, keep on same line
         lines.push(`${itemIndent}- ${serialized}`)
       }
     })
@@ -207,16 +221,20 @@ export class YamlSerializer {
 
   private makePathRelative(str: string): string {
     if (typeof str !== "string") return str
+    if (!isAbsolute(str)) return str
 
-    // Convert absolute paths to relative paths
-    if (str.startsWith(this.appRoot + "/")) {
-      return "./" + str.substring(this.appRoot.length + 1)
-    }
+    // Convert absolute paths to relative paths using path.relative
+    const rel = relative(this.appRoot, str)
 
-    if (str === this.appRoot) {
+    if (rel === "") {
       return "."
     }
 
-    return str
+    // If path is outside appRoot or already absolute, keep original
+    if (rel.startsWith("..") || isAbsolute(rel)) {
+      return str
+    }
+
+    return "./" + rel
   }
 }
