Skip to content

Set bodyLimit to 100 MB by default to fix error 413#511

Merged
Romex91 merged 5 commits intomasterfrom
roman-kuksin/bump-fastify-body-limit
Jan 29, 2025
Merged

Set bodyLimit to 100 MB by default to fix error 413#511
Romex91 merged 5 commits intomasterfrom
roman-kuksin/bump-fastify-body-limit

Conversation

@Romex91
Copy link
Copy Markdown
Contributor

@Romex91 Romex91 commented Jan 29, 2025 •
edited by coderabbitai Bot
Loading

  • Set bodyLimit to 100 MB
  • Add fastifyServerOptions to the config to allow customization

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features

    • Enhanced server configuration with HTTP/2 support
    • Increased maximum request body size to 100 MB

  • Improvements

    • Added flexibility for Fastify server configuration options
    • Improved payload handling capabilities

  • Documentation

    • Updated CHANGELOG to reflect configuration changes, including the introduction of fastifyServerOptions and renaming of configuration options.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 29, 2025 •
edited
Loading

Walkthrough

The changes enhance the configuration capabilities of a Node.js application by introducing HTTP/2 support and increasing the body payload limit for the Fastify server. Modifications are made in three files: configBuilder.ts, worker.ts, and CHANGELOG.md. The updates allow for more flexible server configuration by adding a new fastifyServerOptions property to the configuration, which can be used to customize the Fastify server setup, with an initial default of increasing the body size limit to 100 MB.

Changes

File Change Summary
packages/node-renderer/src/shared/configBuilder.ts - Added http2 module import
- Updated Config interface with fastifyServerOptions
- Initialized fastifyServerOptions in defaultConfig as an empty object
packages/node-renderer/src/worker.ts - Added fastifyServerOptions to destructured config
- Introduced bodyLimit of 104,857,600 bytes (100 MB)
- Used spread operator to include custom server options
CHANGELOG.md - Added section for default configuration change: bodyLimit now set to 100 MB
- Renamed includeTimerPolyfills to stubTimers
- Noted enabling queueMicrotask for React 19 support

Sequence Diagram

sequenceDiagram
    participant Config as Configuration
    participant Worker as Fastify Worker
    participant Server as HTTP/2 Server

    Config->>Worker: Provide fastifyServerOptions
    Worker->>Server: Configure with options
    Server-->>Worker: Server initialized
Loading

Poem

🐰 A Rabbit's Ode to Server Might

HTTP/2 calls, with options so bright,
Payload limits soar to new height,
Fastify dances with config's delight,
A hundred megs now take their flight,
Flexibility leaps with technical might! 🚀

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between ff5bd0a and c1ec31c.

📒 Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • packages/node-renderer/src/shared/configBuilder.ts (3 hunks)

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

AbanoubGhadban
AbanoubGhadban approved these changes Jan 29, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@AbanoubGhadban AbanoubGhadban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Romex91 Romex91 merged commit d5e3463 into master Jan 29, 2025
@Romex91 Romex91 deleted the roman-kuksin/bump-fastify-body-limit branch January 29, 2025 10:00
@frullah frullah mentioned this pull request Feb 7, 2025
Closed
@claude claude Bot mentioned this pull request Feb 26, 2026
Merged
3 tasks
This was referenced Mar 8, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Mar 15, 2026
Merged
Merged
Merged
This was referenced Mar 24, 2026
Merged
Merged
Merged
This was referenced Mar 28, 2026
Closed
Merged
Merged
Merged
This was referenced Apr 18, 2026
Merged
Merged
Merged
This was referenced May 4, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AbanoubGhadban AbanoubGhadban AbanoubGhadban approved these changes

@justin808 justin808 Awaiting requested review from justin808

@alexeyr-ci alexeyr-ci Awaiting requested review from alexeyr-ci

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Romex91 @AbanoubGhadban