Remove unnecessary dependencies from released NPM package#968
Merged
justin808 merged 4 commits intoshakacode:masterfrom Nov 11, 2017
Merged
Conversation
tricknotes
changed the title
tricknotes
force-pushed
the
remove-unnecessary-dependencies-from-released-package
branch
from
c26e6cb to
33a8739
Compare
Member
|
@tricknotes Can you please rebase on top of master. Then let's see the CI results. |
tricknotes
force-pushed
the
remove-unnecessary-dependencies-from-released-package
branch
from
33a8739 to
b0697bb
Compare
Contributor
Author
|
rebased |
Contributor
Author
hmm..., some tests are timeouted :< |
tricknotes
force-pushed
the
remove-unnecessary-dependencies-from-released-package
branch
from
b0697bb to
d888926
Compare
tricknotes
changed the title
tricknotes
force-pushed
the
remove-unnecessary-dependencies-from-released-package
branch
3 times, most recently
from
6aea232 to
fab1996
Compare
tricknotes
changed the title
Contributor
Author
|
@justin808 |
Member
|
This looks solid to me. @Judahmeek? |
Contributor
|
Nice work. However, I think that |
It is necessary to inform yarn what current directory should destination root.
Without package.json in dummy app, yarn will search package.json in ancestral directories. And when running `yarn install <package-name>`, the package.json will be destructively changed.
These dependencies were injected by generator spec. They are unnecessary for released react-on-rails package.
react-on-rails no longer depends on react-redux. The template file that uses react-redux should be passed ESLint regardless its dependency.
Contributor
Author
|
Thanks for your review, @Judahmeek ! I think it may be a optional dependencies. Or I've misunderstand? |
tricknotes
force-pushed
the
remove-unnecessary-dependencies-from-released-package
branch
from
30b4a9f to
cb35cc4
Compare
Contributor
|
You're correct that it is an optional dependency. |
tricknotes
deleted the
remove-unnecessary-dependencies-from-released-package
branch
3 tasks
This was referenced Mar 8, 2026
This was referenced Mar 9, 2026
This was referenced Mar 17, 2026
This was referenced Mar 26, 2026
This was referenced Apr 18, 2026
This was referenced May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These dependencies are injected by generator spec.
However they are unnecessary for released react-on-rails package.
Even if the
dependenciessection is removed, it will back after$ rspec spec/react_on_rails/generators/install_generator_spec.rbis run.I think it is unexpected behavior.
So I removed these dependencies and fix specs.
@Judahmeek @justin808
Can you review this PR? It this a correct way?
This change is