. Ready to merge? and release? Needs a CHANGELOG and doc entry.

Reviewed 11 of 11 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

spec/dummy/package.json, line 10 at r1 (raw file):

    "lint": "cd client && yarn run lint",
    "build:clean": "rm -rf public/webpack || true",
    "build:production:client": "(cd client && yarn run build:production:client --silent)",

why did this change?

Comments from Reviewable

I'd like to get the rest of my PRs reviewed, fixed, approved, and merged before release.

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

spec/dummy/package.json, line 10 at r1 (raw file):

Because with yarn v1, the old syntax sends the --silent option to webpack, which then throws an error.

Comments from Reviewable

Why no CHANGELOG.md and doc change, @Judahmeek?

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

My bad, @justin808. For some reason, I was thinking that CHANGELOG updates were only required on release. I forgot about the unreleased section. That said, I don't think any doc changes are required since this PR simply ensured that react_component_hash actually returns a hash every time.

Btw, #957 is also ready for re-review.

Review status: 11 of 12 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

Review status: 11 of 12 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable