Conversation
|
LGTM so far.
Reviewed 25 of 25 files at r1. app/helpers/react_on_rails_helper.rb, line 324 at r1 (raw file):
should this be inside "private" Comments from Reviewable |
Judahmeek
force-pushed
the
jmeek/version-10
branch
2 times, most recently
from
694ed18 to
185d6cc
Compare
Judahmeek
force-pushed
the
jmeek/version-10
branch
from
185d6cc to
0bc60b6
Compare
Judahmeek
force-pushed
the
jmeek/version-10
branch
15 times, most recently
from
b673e6e to
8f58874
Compare
Judahmeek
force-pushed
the
jmeek/version-10
branch
from
8f58874 to
8bef861
Compare
Judahmeek
force-pushed
the
jmeek/version-10
branch
from
b794b57 to
f707420
Compare
| "homepage": "https://github.com/shakacode/react_on_rails#readme", | ||
| "dependencies": { | ||
| "react-on-rails": "^9.0.0-beta.12", | ||
| "react-on-rails": "^9.0.3", |
There was a problem hiding this comment.
Why does React on Rails version 10 require React on Rails version 9?
There was a problem hiding this comment.
@shepmaster Until we release, we can't update the version in the PR.
There was a problem hiding this comment.
Until we release
I noticed it because the 10.0 release of this package requires the 9.0 release of this package 😸
There was a problem hiding this comment.
It seems [email protected] is released.
I send a PR to update this version. #959
When I created #951, I forgot to add the useful functionality from #950 that would ensure that react_component_hash worked correctly. When there is a prerendering error, react_component_hash should return the result combined with the console logs as a hash even though every prerendering error is returned from Exec as a String. Right now, if a prerendering error occurs, react_component_hash throws its "Expected a Hash" error
4 participants
This change is