Coverage increased (+0.01%) to 97.911% when pulling 29d1df5 on danijel:i18n_yml_dir into cca1351 on shakacode:master.

@JasonYCHuang can you please review this one.

@danijel Looks great. Couple small comments.

Reviewed 8 of 8 files at r1.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

CHANGELOG.md, line 7 at r1 (raw file):

## [Unreleased]
*Please add entries here for your pull requests.*

Please don't remove this placeholder.

docs/basics/i18n.md, line 29 at r1 (raw file):
Add comment line per next comment:

Indicate what the default directory is.

lib/generators/react_on_rails/templates/base/base/config/initializers/react_on_rails.rb.tt, line 70 at r1 (raw file):

  #
  # Replace the following line to the location where you keep your client i18n yml files
  # that will source for automatic generation on translations.js & default.js

Indicate what the default directory is.

Comments from Reviewable

@justin808 Thanks for quick review.
Unreleased placeholder returned and added line about what gets loaded by default without this option.

Coverage increased (+0.01%) to 97.911% when pulling d30ca6b on danijel:i18n_yml_dir into cca1351 on shakacode:master.

tiny comment

Reviewed 3 of 3 files at r2.
Review status: all files reviewed at latest revision, 4 unresolved discussions.

CHANGELOG.md, line 8 at r2 (raw file):

## [Unreleased]
*Please add entries here for your pull requests.*
Add option to specify i18n_yml_dir in order to include only subset of locale files when generating translations.js & default.js for react-intl

Please format like the others. and blank line after placeholder.

Comments from Reviewable

@justin808 ok now?

Coverage increased (+0.01%) to 97.911% when pulling 256ad29 on danijel:i18n_yml_dir into cca1351 on shakacode:master.

one comment

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 5 unresolved discussions.

CHANGELOG.md, line 10 at r3 (raw file):

### Added
- Add option to specify i18n_yml_dir in order to include only subset of locale files when generating translations.js & default.js for react-intl

missing the PR and author.

See formatting of other entries.

Comments from Reviewable

@justin808 added

Coverage increased (+0.01%) to 97.911% when pulling 8499818 on danijel:i18n_yml_dir into cca1351 on shakacode:master.

Review status: 7 of 8 files reviewed at latest revision, 6 unresolved discussions.

CHANGELOG.md, line 10 at r4 (raw file):

### Added
- Add option to specify i18n_yml_dir in order to include only subset of locale files when generating translations.js & default.js for react-intl

period.

:-)

Comments from Reviewable

Reviewed 1 of 1 files at r4.
Review status: all files reviewed at latest revision, 6 unresolved discussions.

Comments from Reviewable

@justin808 added, damn, what's wrong with me :-)

Coverage increased (+0.01%) to 97.911% when pulling 76be2ba on danijel:i18n_yml_dir into cca1351 on shakacode:master.