Something seems to be up with TravisCI trying to install fsevents, which is not compatible with Linux. The build was green when I removed it from the npm shrinkwrap file on my fork, but of course that was a change that I didn't want to include in this pull request.

EDIT: Seems to be related to this issue npm/npm#14042, and it's apparently fixable by downgrading npm or running shinkrwrap again with npm 3.10.10+

Coverage remained the same at 82.75% when pulling 52e2915 on bbonamin:ruby20 into 93fb10b on shakacode:master.

Coverage remained the same at 82.75% when pulling 137d186 on bbonamin:ruby20 into 93fb10b on shakacode:master.

Coverage remained the same at 82.75% when pulling a458267 on bbonamin:ruby20 into 93fb10b on shakacode:master.

@samnang @mapreal19 @robwise This one looks OK to me. Ugly, but I guess some people need it.

I vote for this one. How about you guys?

@justin808 To me, it's okay if we want to support them for a while and pay attention of features that might break for this, but it shouldn't a long term because Rails 5 already drop their support. If we just trying with minimum dependency on Rails, then it might not be a problem.

@justin808 @bbonamin we could remove the duplication for those required arguments with a helper method. Take a look at this answer http://stackoverflow.com/a/15078852/2273578

I would rather see those methods like this:

def  rails_context(server_side: required) 

Review status: 0 of 7 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

lol I vote for this just the way I voted for it the last time someone did this almost a year ago, this repo really hardly uses keyword arguments so it's a no-brainer to keep it backwards compatible. I'm not sure why we keep re-introducing breaking changes:

https://github.com/shakacode/react_on_rails/blob/28776cbc36b22dc3aa91a5b1fe9f9b2b3c20fdc7/CHANGELOG.md#210---2016-01-26

@mapreal19 I've pushed a change with a DRYer approach to doing to required validation. Let me know if you think it's good 😃

Coverage increased (+0.4%) to 83.198% when pulling 7edc2d0 on bbonamin:ruby20 into 501d593 on shakacode:master.

Coverage increased (+0.02%) to 82.775% when pulling 7edc2d0 on bbonamin:ruby20 into 501d593 on shakacode:master.

Please rebase your changes on top of my latest commit.

Done 👍 ! Merry Christmas! 🎄

Coverage increased (+0.006%) to 99.292% when pulling ab689f0 on bbonamin:ruby20 into 8bcaa34 on shakacode:master.

Small suggestions @bbonamin.

Looking good!

Reviewed 4 of 7 files at r1, 3 of 3 files at r2, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

app/helpers/react_on_rails_helper.rb, line 263 at r3 (raw file):

  def server_rendered_react_component_html(
    props, react_component_name, dom_id, prerender: required("prerender"),
    trace: required("trace"), raise_on_prerender_error: required("raise_on_prerender_error")

We should do these one per param per line. Easier to read.

lib/react_on_rails/test_helper/webpack_assets_status_checker.rb, line 14 at r3 (raw file):

      def initialize(
        generated_assets_dir: raise(ArgumentError, "generated_assets_dir is required"),
        client_dir: raise(ArgumentError, "client_dir is required"),

can we use the helper required here?

Comments from Reviewable

Review status: all files reviewed at latest revision, 3 unresolved discussions.

CHANGELOG.md, line 9 at r3 (raw file):

*Please add entries here for your pull requests.*
##### Fixed
- Added support for Ruby 2.0.

Please see the other changelog entries and make consistent.

Comments from Reviewable

Please put your changelog comments under 6.3.3.

Coverage increased (+0.008%) to 99.294% when pulling 14488d2 on bbonamin:ruby20 into ccd970a on shakacode:master.

Coverage increased (+0.008%) to 99.294% when pulling 14488d2 on bbonamin:ruby20 into ccd970a on shakacode:master.

Thanks @bbonamin!

Reviewed 1 of 7 files at r1, 2 of 3 files at r2, 1 of 1 files at r3, 5 of 5 files at r4.
Review status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks broke.

Comments from Reviewable