Automatically generate i18n javascript files for react-intl when the serve starts up.#642
Merged
justin808 merged 1 commit intoshakacode:masterfrom Jan 12, 2017
Merged
Conversation
Member
|
we want this pr to include i18n.rake Reviewed 3 of 3 files at r1. Comments from Reviewable |
Member
|
@JasonYCHuang How's this PR going? |
Contributor
Author
|
@justin808 I am occupied recently, and will finish this during Xmas or New year holidays. |
JasonYCHuang
force-pushed
the
i18n
branch
3 times, most recently
from
fdff007 to
c367290
Compare
2 similar comments
Member
|
@JasonYCHuang Looks potentially super amazing! We need updates to the docs and a CHANGELOG.md, as well as tests that demonstrate and verify locals_to_js.rb. This is really a huge addition to the project! 👏 🎉 Reviewed 2 of 5 files at r2. Comments from Reviewable |
Contributor
Author
|
No problem, will update it later. Review status: 2 of 5 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
JasonYCHuang
changed the title
JasonYCHuang
changed the title
JasonYCHuang
force-pushed
the
i18n
branch
2 times, most recently
from
d2188f1 to
95d8a08
Compare
1 similar comment
JasonYCHuang
force-pushed
the
i18n
branch
4 times, most recently
from
ffacf2c to
2870647
Compare
2 similar comments
Contributor
Author
|
Update Readme, changelog, and add test Review status: 2 of 8 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
ryanbelke
pushed a commit
to ryanbelke/rails-react-yourtime
that referenced
this pull request
Jan 4, 2019
… time. (#340) Demonstrates use of i18n (internationalization) with React on Rails. Docs: https://github.com/shakacode/react_on_rails/blob/master/docs/basics/i18n.md Relevant PRs from React on Rails: * shakacode/react_on_rails#642 * shakacode/react_on_rails#717
joseph0919
pushed a commit
to joseph0919/React_Webpack_Rails_Tutorial
that referenced
this pull request
May 3, 2019
… time. (#340) Demonstrates use of i18n (internationalization) with React on Rails. Docs: https://github.com/shakacode/react_on_rails/blob/master/docs/basics/i18n.md Relevant PRs from React on Rails: * shakacode/react_on_rails#642 * shakacode/react_on_rails#717
jimmydev996
pushed a commit
to jimmydev996/React-Webpack-Rails-Tutorial
that referenced
this pull request
Oct 30, 2025
… time. (#340) Demonstrates use of i18n (internationalization) with React on Rails. Docs: https://github.com/shakacode/react_on_rails/blob/master/docs/basics/i18n.md Relevant PRs from React on Rails: * shakacode/react_on_rails#642 * shakacode/react_on_rails#717
3 tasks
This was referenced Mar 8, 2026
This was referenced Mar 15, 2026
This was referenced Mar 24, 2026
This was referenced Apr 18, 2026
This was referenced May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for shakacode/react-webpack-rails-tutorial#340
We need i18n_dir & default_locale in ReactOnRails configuration.
This change is