Don't assume ActionMailer is available#608
Merged
justin808 merged 1 commit intoshakacode:masterfrom Nov 30, 2016
tuzz:dont-assume-actionmailer
Merged
Don't assume ActionMailer is available#608justin808 merged 1 commit intoshakacode:masterfrom tuzz:dont-assume-actionmailer
justin808 merged 1 commit intoshakacode:masterfrom
tuzz:dont-assume-actionmailer
Conversation
Member
|
Reviewed 1 of 1 files at r1. app/helpers/react_on_rails_helper.rb, line 405 at r1 (raw file):
this is not easy to read please return a specific value Comments from Reviewable |
Member
|
please update per my suggestion Review status: all files reviewed at latest revision, 1 unresolved discussion. Comments from Reviewable |
If the Rails app that uses this gem doesn't include the ActionMailer railtie, the gem raises this error: `uninitialized constant ReactOnRailsHelper::ActionMailer` This change introduces a check that the ActionMailer constant is defined before setting the 'inMailer' option. I'm not quite sure how to test this, so if anyone has ideas, that would be helpful.
Contributor
Author
|
@justin808: updated as per your suggestion |
Member
|
Please provide a changelog entry: https://github.com/shakacode/react_on_rails/blob/master/CONTRIBUTING.md#summary Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion. Comments from Reviewable |
3 tasks
This was referenced Mar 8, 2026
This was referenced Mar 15, 2026
This was referenced Mar 26, 2026
This was referenced Apr 18, 2026
This was referenced May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the Rails app that uses this gem doesn't include the
ActionMailer railtie, the gem raises this error:
uninitialized constant ReactOnRailsHelper::ActionMailerThis change introduces a check that the ActionMailer
constant is defined before setting the 'inMailer' option.
I'm not quite sure how to test this, so if anyone has
ideas, that would be helpful.
This change is