handle error where react-on-rails package entry missing#602
handle error where react-on-rails package entry missing#602justin808 merged 1 commit intoshakacode:masterfrom
Conversation
|
Nice work @benjiwheeler! Could you add a simple rspec test? I'll merge right after that. |
|
Reviewed 1 of 1 files at r1. Comments from Reviewable |
|
@benjiwheeler you have lint errors: https://travis-ci.org/shakacode/react_on_rails/builds/174902848 try cd client Offenses: Tasks: TOP => default => lint => lint:lint => lint:rubocop (See full trace by running task with --trace) |
|
Having trouble running rspec with this Gem bundle... getting:
|
|
@benjiwheeler Did you try running bundle install? you might need to cd spec/dummy and run bundle install there too! |
|
yes, ran bundle install on app dir and spec/dummy both... tried changing ruby version and rerunning... now getting mini_racer error... reinstalling xcode commandline utils etc... |
|
Reviewed 2 of 2 files at r2. .delete_by, line 1 at r2 (raw file):
what is this file? Comments from Reviewable |
|
@benjiwheeler Let's get this in the next release coming up soon! Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed. Comments from Reviewable |
| @@ -0,0 +1 @@ | |||
| 20170101 | |||
There was a problem hiding this comment.
@benjiwheeler Can you please remove this file from the PR.
|
removed .delete_by |
|
Reviewed 1 of 1 files at r3. Comments from Reviewable |
|
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed. Comments from Reviewable |
This change is