Skip to content

handle error where react-on-rails package entry missing#602

Merged
justin808 merged 1 commit intoshakacode:masterfrom
benjiwheeler:master
Dec 6, 2016
Merged

handle error where react-on-rails package entry missing#602
justin808 merged 1 commit intoshakacode:masterfrom
benjiwheeler:master

Conversation

@benjiwheeler
Copy link
Copy Markdown
Contributor

@benjiwheeler benjiwheeler commented Nov 10, 2016

This change is Reviewable

@justin808
Copy link
Copy Markdown
Member

Nice work @benjiwheeler! Could you add a simple rspec test? I'll merge right after that.

@justin808
Copy link
Copy Markdown
Member

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@justin808
Copy link
Copy Markdown
Member

@benjiwheeler you have lint errors: https://travis-ci.org/shakacode/react_on_rails/builds/174902848

try

cd client
npm run lint -- --fix

Offenses:
lib/react_on_rails/version_checker.rb:62:36: C: Style/PreferredHashMethods: Use Hash#key? instead of Hash#has_key?.
if parsed_package_contents.has_key?("dependencies") &&
^^^^^^^^
lib/react_on_rails/version_checker.rb:63:10: C: Style/MultilineOperationIndentation: Align the operands of a condition in an if statement spanning multiple lines.
parsed_package_contents["dependencies"].has_key?("react-on-rails")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/react_on_rails/version_checker.rb:63:50: C: Style/PreferredHashMethods: Use Hash#key? instead of Hash#has_key?.
parsed_package_contents["dependencies"].has_key?("react-on-rails")
^^^^^^^^
93 files inspected, 3 offenses detected
rake aborted!
Command failed with status (1): [cd /home/travis/build/shakacode/react_on_r...]
/home/travis/build/shakacode/react_on_rails/rakelib/task_helpers.rb:20:in block in sh_in_dir' /home/travis/build/shakacode/react_on_rails/rakelib/task_helpers.rb:20:ineach'
/home/travis/build/shakacode/react_on_rails/rakelib/task_helpers.rb:20:in sh_in_dir' /home/travis/build/shakacode/react_on_rails/rakelib/lint.rake:7:inblock (2 levels) in <top (required)>'
/home/travis/.rvm/gems/ruby-2.3.1/gems/rake-11.2.2/exe/rake:27:in <top (required)>' /home/travis/.rvm/gems/ruby-2.3.1/bin/ruby_executable_hooks:15:ineval'
/home/travis/.rvm/gems/ruby-2.3.1/bin/ruby_executable_hooks:15:in `

'
Tasks: TOP => default => lint => lint:lint => lint:rubocop
(See full trace by running task with --trace)

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.06%) to 82.927% when pulling 8f77015 on benjiwheeler:master into 447c4eb on shakacode:master.

@benjiwheeler
Copy link
Copy Markdown
Contributor Author

Having trouble running rspec with this Gem bundle... getting:

Your bundle is locked to activejob (4.2.3), but that version could not be found in any of the sources listed in your Gemfile. If you haven't changed sources, that means the author of activejob (4.2.3) has removed it.

@justin808
Copy link
Copy Markdown
Member

@benjiwheeler Did you try running bundle install? you might need to cd spec/dummy and run bundle install there too!

See https://github.com/shakacode/react_on_rails/blob/master/CONTRIBUTING.md

@benjiwheeler
Copy link
Copy Markdown
Contributor Author

yes, ran bundle install on app dir and spec/dummy both... tried changing ruby version and rerunning... now getting mini_racer error... reinstalling xcode commandline utils etc...

@justin808
Copy link
Copy Markdown
Member

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


.delete_by, line 1 at r2 (raw file):

20170101

what is this file?


Comments from Reviewable

@justin808
Copy link
Copy Markdown
Member

@benjiwheeler Let's get this in the next release coming up soon!


Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


Comments from Reviewable

@justin808 justin808 modified the milestones: 6.2, 6.3.0 Nov 19, 2016
Comment thread .delete_by Outdated
@@ -0,0 +1 @@
20170101
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benjiwheeler Can you please remove this file from the PR.

@benjiwheeler
Copy link
Copy Markdown
Contributor Author

removed .delete_by

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.06%) to 83.051% when pulling ed35494 on benjiwheeler:master into 7f859e1 on shakacode:master.

@justin808
Copy link
Copy Markdown
Member

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.


Comments from Reviewable

@justin808
Copy link
Copy Markdown
Member

:lgtm:


Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.


Comments from Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants