@robwise @jbhatab @Judahmeek I'd like to get your feedback on this one. I'm going to create a sample repo with a PR generated from the generator.

@robwise @jbhatab @Judahmeek @nostophilia I created: shakacode/react_on_rails-test-new-redux-generation#1

Let's comment on the code there and here.

@nostophilia

1. Please see: Run generator redux updated with lint react_on_rails-test-new-redux-generation#2. We need to generate code that passes linting.
2. We can cleanup the comments. We should remove the revision dates from the generated files. The more doc references we provide the better.

Overall, I think this looks great. Just needs a bit of cleanup!

Thanks for your contributions.

I'd like to get this merged in the next day or so. If you cannot get to it, please let me know. I'd prefer to have you make the changes so that your name is in the commit history with one big commit.

Coverage remained the same at 82.987% when pulling 8175de8 on nostophilia:hello-world-revision into 4df498a on shakacode:master.

@justin808 @robwise
I revised my code together with the syntax suggestions. Please let me know what else should I do before merging these commits into a single one. (I'm also in favor of leaving async middleware out as Rob mentioned. Maybe you guys can discuss this later)

Coverage remained the same at 82.987% when pulling fb48387 on nostophilia:hello-world-revision into 4df498a on shakacode:master.

Coverage remained the same at 82.987% when pulling 3682d4f on nostophilia:hello-world-revision into 7fecce1 on shakacode:master.

@nostophilia Please let me know when you're ready. Please confirm if you got all the requested changes and if linting passes using the linter 13.0.0.

npm i --save-dev [email protected] after running the generator.

@justin808
It's ready except this violation

Coverage remained the same at 82.987% when pulling df77edb on nostophilia:hello-world-revision into 60d9f7f on shakacode:master.

Coverage remained the same at 82.987% when pulling d8c1900 on nostophilia:hello-world-revision into cd2038d on shakacode:master.

shakacode/react_on_rails-test-new-redux-generation#8

So close! Just need to fix the lint errors on what's generated.

BE SURE to use the linters in this commit:

shakacode/react_on_rails-test-new-redux-generation@ef1bde4

You can cherry-pick this!

Coverage remained the same at 82.987% when pulling d815093 on nostophilia:hello-world-revision into 3a84802 on shakacode:master.

@nostophilia when will you push v6 to https://github.com/shakacode/react_on_rails-test-new-redux-generation/ ? I'd like to get this change into the next release coming maybe this weekend.

Coverage remained the same at 82.987% when pulling e47256e on nostophilia:hello-world-revision into add8aa8 on shakacode:master.

AMAZING JOB! Great teamwork! Big improvement!

I'm shipping this!

Reviewed 18 of 19 files at r1, 3 of 3 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable