Skip to content

Fixed assets symlinking for Heroku#446

Merged
justin808 merged 1 commit intoshakacode:masterfrom
alexeuler:hotfix/assets_heroku
Jun 7, 2016
Merged

Fixed assets symlinking for Heroku#446
justin808 merged 1 commit intoshakacode:masterfrom
alexeuler:hotfix/assets_heroku

Conversation

@alexeuler
Copy link
Copy Markdown
Contributor

@alexeuler alexeuler commented Jun 6, 2016 •
edited by justin808
Loading

The problem with Heroku was that it built the app in a tmp folder and then moved in the release folder. Symlinks were created with absolute path, so this process broke symlinks target. This fix creates relative symlinks instead.

This change is Reviewable

@alexeuler alexeuler force-pushed the hotfix/assets_heroku branch from e5268c9 to 72f004a Compare June 7, 2016 06:31
@justin808
Copy link
Copy Markdown
Member

justin808 commented Jun 7, 2016

Nice change to use relative symlinks.

:lgtm:

Previously, alleycat-at-git (Alexey) wrote…

Fixed assets symlinking for Heroku

The problem with Heroku was that it built the app in a tmp folder and then moved in the release folder. Symlinks were created with absolute path, so this process broke symlinks target. This fix creates relative symlinks instead.

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@alexeuler alexeuler force-pushed the hotfix/assets_heroku branch 2 times, most recently from c8d337c to 71d668e Compare June 7, 2016 06:39
@coveralls
Copy link
Copy Markdown

coveralls commented Jun 7, 2016

Coverage Status

Coverage remained the same at 82.305% when pulling 71d668e on alleycat-at-git:hotfix/assets_heroku into e462223 on shakacode:master.

@alexeuler alexeuler force-pushed the hotfix/assets_heroku branch from 71d668e to eb7d710 Compare June 7, 2016 06:49
@justin808
Copy link
Copy Markdown
Member

justin808 commented Jun 7, 2016

:lgtm:

Previously, coveralls wrote…

Coverage Status

Coverage remained the same at 82.305% when pulling 71d668e on alleycat-at-git:hotfix/assets_heroku into e462223 on shakacode:master.

Reviewed 1 of 1 files at r2, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 7, 2016

Coverage Status

Coverage remained the same at 82.305% when pulling eb7d710 on alleycat-at-git:hotfix/assets_heroku into e462223 on shakacode:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 7, 2016

Coverage Status

Coverage remained the same at 82.305% when pulling eb7d710 on alleycat-at-git:hotfix/assets_heroku into e462223 on shakacode:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 7, 2016

Coverage Status

Coverage remained the same at 82.305% when pulling eb7d710 on alleycat-at-git:hotfix/assets_heroku into e462223 on shakacode:master.

@justin808 justin808 merged commit 118cd06 into shakacode:master Jun 7, 2016
@varyonic varyonic mentioned this pull request Sep 9, 2016
Closed
@claude claude Bot mentioned this pull request Feb 26, 2026
Merged
3 tasks
This was referenced Mar 8, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Mar 15, 2026
Merged
Merged
Merged
This was referenced Mar 24, 2026
Merged
Merged
Merged
This was referenced Mar 28, 2026
Closed
Merged
Merged
Merged
This was referenced Apr 18, 2026
Merged
Merged
Merged
This was referenced May 4, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexeuler @justin808 @coveralls