Skip to content

added old rails manifest.json support#436

Merged
justin808 merged 1 commit intoshakacode:masterfrom
alexeuler:hotfix/assets_symlinks
May 27, 2016
Merged

added old rails manifest.json support#436
justin808 merged 1 commit intoshakacode:masterfrom
alexeuler:hotfix/assets_symlinks

Conversation

@alexeuler
Copy link
Copy Markdown
Contributor

@alexeuler alexeuler commented May 26, 2016

This change is Reviewable

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 82.449% when pulling 42f310b on alleycat-at-git:hotfix/assets_symlinks into 4f05cf4 on shakacode:master.

@justin808
Copy link
Copy Markdown
Member

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


lib/tasks/assets.rake, line 34 [r1] (raw file):

          next
        end
        manifest_path = manifest_glob.first

@alleycat-at-git If somebody upgraded, is it possible they could have both files? Seems that the code would get the first file, being the new format.


Comments from Reviewable

@justin808
Copy link
Copy Markdown
Member

:lgtm: I'd day ready to release.

Previously, coveralls wrote…

Coverage Status

Coverage remained the same at 82.449% when pulling 42f310b on alleycat-at-git:hotfix/assets_symlinks into 4f05cf4 on shakacode:master.


Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@alexeuler
Copy link
Copy Markdown
Contributor Author

Theoretically it could be, but the code will take the new format file and it will be right in this case

On 27 May 2016, at 10:05, Justin Gordon [email protected] wrote:

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

lib/tasks/assets.rake, line 34 [r1](raw file):

      next
    end
    manifest_path = manifest_glob.first

@alleycat-at-git If somebody upgraded, is it possible they could have both files? Seems that the code would get the first file, being the new format.

Comments from Reviewable


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@justin808
Copy link
Copy Markdown
Member

:lgtm: @alleycat-at-git I'll take care of the CHANGELOG.md

Previously, alleycat-at-git (Alexey) wrote…

Theoretically it could be, but the code will take the new format file and it will be right in this case


Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@justin808 justin808 merged commit 077aa5d into shakacode:master May 27, 2016
@justin808
Copy link
Copy Markdown
Member

Fixed #435.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants