Update README.md#419
Merged
justin808 merged 1 commit intoshakacode:masterfrom May 13, 2016
Merged
Conversation
typo
Member
|
Thanks @mcfiredrill |
AbanoubGhadban
pushed a commit
that referenced
this pull request
Sep 25, 2025
This is a follow-up PR for shakacode/react_on_rails_pro#415 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Updated the global declaration of `ReactOnRails` in `vm.ts` for compatibility with node 16+. - **Documentation** - Added a note in `basics.md` about `react-on-rails` installation for `global.ReactOnRails` types. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
AbanoubGhadban
pushed a commit
that referenced
this pull request
Sep 26, 2025
This is a follow-up PR for shakacode/react_on_rails_pro#415 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Updated the global declaration of `ReactOnRails` in `vm.ts` for compatibility with node 16+. - **Documentation** - Added a note in `basics.md` about `react-on-rails` installation for `global.ReactOnRails` types. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
3 tasks
justin808
added a commit
that referenced
this pull request
Apr 19, 2026
…les (#3158) ## Summary - Adds `performance` to the default globals injected into the node renderer's VM context when `supportModules: true`. - React 19's development build of `React.lazy` calls `performance.now()` inside `lazyInitializer`, which threw `ReferenceError: performance is not defined` without this — making `React.lazy` unusable in dev unless users manually passed `performance` via `additionalContext`. - Updates the `Config` JSDoc, the `js-configuration.md` docs, and the `CHANGELOG`, and adds a regression test. Fixes #3154. ## Notes The reporter also raised a broader question about the recommended pattern for `React.lazy` with streaming SSR and `LimitChunkCountPlugin({ maxChunks: 1 })` (intermittent Suspense resolution causing hydration mismatches / React error #419). That's a separate, larger discussion and is not addressed here — this PR only fixes the concrete `performance` VM-context bug the reporter identified and worked around. ## Test plan - [x] `pnpm --filter react-on-rails-pro-node-renderer exec jest vm.test` — all 27 tests pass, including the new assertions that `performance` and `performance.now` are defined in the VM when `supportModules` is enabled. - [x] `pnpm exec prettier --check` on the modified files — passes. - [x] `pnpm -w run eslint` on the modified source files — passes. Generated with Claude Code (https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: adds one additional global (`performance`) to the VM context behind the existing `supportModules` flag, plus doc/test updates; main behavioral change is potential nondeterministic SSR output if app code embeds `performance.now()` values. > > **Overview** > Fixes React 19 dev SSR crashes by adding the host `performance` object to the node renderer VM globals when `supportModules: true`, alongside existing injected Node globals. > > Updates docs and JSDoc to reflect the new default global set and to clarify that `stubTimers` does not stub `performance` (with guidance for overriding via `additionalContext`), and extends VM tests to assert `performance`/`performance.now` presence when enabled (and absence when disabled). > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 54b4aaf. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Restored React 19 dev compatibility by ensuring the renderer VM includes the performance global when module support is enabled, preventing ReferenceError in lazy-loaded code. * **Documentation** * Clarified that performance is included in the VM globals when module support is enabled and noted behavior relative to timer stubbing and SSR determinism. * **Tests** * Updated tests to assert performance and performance.now availability in the VM sandbox. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Claude Opus 4.7 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typo
greate->greater
This change is