Skip to content

Address failure to sanitize console messages#366

Merged
justin808 merged 1 commit intomasterfrom
fix-sanitization-server-console-messages
Apr 4, 2016
Merged

Address failure to sanitize console messages#366
justin808 merged 1 commit intomasterfrom
fix-sanitization-server-console-messages

Conversation

@justin808
Copy link
Copy Markdown
Member

  • Only happened with server rendering.
  • Fix is to escape for closing script tag

This change is Reviewable

* Only happened with server rendering.
* Fix is to escape for closing script tag
@justin808
Copy link
Copy Markdown
Member Author

@descentintomael, any chance that you can take a quick look at this.

@justin808
Copy link
Copy Markdown
Member Author

@alexfedoseev @samnang Good enough to just escape the closing </script> tag?

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 87.396% when pulling 2cafba2 on fix-sanitization-server-console-messages into da9d525 on master.

@justin808 justin808 merged commit 791e3cc into master Apr 4, 2016
@justin808
Copy link
Copy Markdown
Member Author

I'm going to release this one without review. However, I'd like to get this one still reviewed!

@robwise robwise deleted the fix-sanitization-server-console-messages branch April 5, 2016 00:15
@justin808
Copy link
Copy Markdown
Member Author

AbanoubGhadban pushed a commit that referenced this pull request Sep 25, 2025
AbanoubGhadban pushed a commit that referenced this pull request Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants