Skip to content

docs: remove defunct guavapass.com reference#3199

Merged
justin808 merged 1 commit intomainfrom
jg-conductor/remove-guavapass-docs
Apr 23, 2026
Merged

docs: remove defunct guavapass.com reference#3199
justin808 merged 1 commit intomainfrom
jg-conductor/remove-guavapass-docs

Conversation

@justin808
Copy link
Copy Markdown
Member

@justin808 justin808 commented Apr 23, 2026

Summary

  • Remove GuavaPass entry from PROJECTS.md — the site is no longer reachable and was breaking the markdown link checker.
  • Drop the companion guavapass.com exclusion from .lychee.toml, which is no longer needed.

Test plan

  • lefthook pre-push markdown link check passes (0 errors)
  • Check Markdown Links CI workflow passes on this branch

🤖 Generated with Claude Code


Note

Low Risk
Low risk: documentation-only change plus a small update to .lychee.toml exclusions; no runtime code paths affected.

Overview
Removes the GuavaPass entry from PROJECTS.md because the site is no longer reachable.

Cleans up .lychee.toml by dropping the guavapass.com exclude pattern that was only needed to silence link-check failures.

Reviewed by Cursor Bugbot for commit f84806b. Bugbot is set up for automated code reviews on this repo. Configure here.

Summary by CodeRabbit

  • Documentation

    • Removed GuavaPass reference from the commercial products section.
  • Chores

    • Updated link checking configuration to include GuavaPass URLs in validation scans.

The guavapass.com domain is failing link checks in CI. Remove the
entry from PROJECTS.md and drop the now-unneeded lychee exclusion.

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a7a0bce3-e32c-4773-a4fc-f710bb8ea185

📥 Commits

Reviewing files that changed from the base of the PR and between efe3503 and f84806b.

📒 Files selected for processing (2)
  • .lychee.toml
  • PROJECTS.md
💤 Files with no reviewable changes (2)
  • PROJECTS.md
  • .lychee.toml

Walkthrough

Removal of GuavaPass project reference from project documentation and its associated URL pattern exclusion from the link checker configuration, streamlining both files to remove the commercial product entry.

Changes

Cohort / File(s) Summary
Configuration
.lychee.toml
Deleted URL exclusion pattern for guavapass.com, making link checks now attempt to verify URLs associated with that domain.
Documentation
PROJECTS.md
Removed GuavaPass entry from the "Commercial Products Live" section, including its associated link and coaching client description.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A hop, skip, and deletion spree,
GuavaPass bids farewell with glee,
Link checks now roam wild and free,
Config and docs, both cleaner to see! 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'docs: remove defunct guavapass.com reference' directly and clearly summarizes the main change: removing a defunct guavapass.com reference from documentation files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jg-conductor/remove-guavapass-docs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Apr 23, 2026

Greptile Summary

This PR removes the defunct guavapass.com entry from PROJECTS.md and drops its corresponding link-checker exclusion from .lychee.toml, resolving a broken-link CI failure. The changes are minimal and correct.

Confidence Score: 5/5

Safe to merge — documentation-only cleanup with no functional impact.

Both changes are trivially correct: the broken project entry is removed from the docs and its corresponding link-checker exclusion is cleaned up. No logic, code, or configuration is affected.

No files require special attention.

Important Files Changed

Filename Overview
PROJECTS.md Removes the defunct GuavaPass entry — straightforward doc cleanup, no issues.
.lychee.toml Drops the guavapass.com link-checker exclusion that is no longer needed after the PROJECTS.md removal.

Reviews (1): Last reviewed commit: "docs: remove defunct guavapass.com refer..." | Re-trigger Greptile

@justin808 justin808 merged commit 80242fe into main Apr 23, 2026
11 checks passed
@justin808 justin808 deleted the jg-conductor/remove-guavapass-docs branch April 23, 2026 02:02
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Apr 23, 2026

Code Review

Summary: Minimal, low-risk documentation cleanup. Removes the defunct GuavaPass entry from PROJECTS.md and drops the now-unnecessary lychee exclusion from .lychee.toml.

Correctness

  • Verified: grep -ri guavapass finds zero remaining references across all .md, .toml, .yml, and .txt files in the repo. Removing the lychee exclude rule is therefore safe — there are no other guavapass.com URLs that would now surface as link-check errors.
  • The two-line diff is internally consistent: one line removes the link, the other removes the rule that was suppressing failures on that link.

Lychee exclude comment (minor)

The removed lychee rule carried the comment "TLS handshake fails from GitHub Actions (bot filter)", but the PR description says the site is now fully unreachable, not just bot-filtering. That distinction doesn't affect correctness here, but it's worth keeping in mind: if guavapass.com ever came back and someone re-added a link, the old comment text would no longer accurately describe the reason for an exclusion.

Conclusion

Change is correct, complete, and appropriately scoped. No runtime code paths are affected.

LGTM — ready to merge once the Check Markdown Links CI workflow passes.

justin808 added a commit that referenced this pull request Apr 23, 2026
…ging' into jg/3122-rolling-deploy-adapter

* origin/jg/3122-unify-renderer-cache-staging: (39 commits)
  fix(specs): boot dummy specs without readline and drop redundant pnpm workspace (#3190)
  docs: add RSC migration success stories page (#1985) (#3162)
  Fix Bencher reporting permanently broken on pushes to main (#3148)
  docs: add example migrations guide (#3126)
  docs: remove defunct guavapass.com reference (#3199)
  chore: remove redundant --rsc-pro install generator flag (#3105)
  ci: warn (don't fail) on Bencher main regression (#3168)
  test: enable RSpec --profile to surface slowest package tests (#3176)
  fix(node-renderer): expose performance in VM context when supportModules (#3158)
  docs: remove stale immediate_hydration references (#3139) (#3159)
  docs: restore absolute URL for node-renderer testing example (#3179)
  Bump Rspack dependencies to v2 (^2.0.0-0) (#3084)
  chore: remove obsolete webpack <5.106.0 pin (#3175)
  Move Node Renderer entry point to renderer/ directory (#3165)
  docs: address RSC pitfalls review follow-ups (#3155) (#3156)
  docs: remove fabricated DevConsole reference, link verified RSC tools (#2527) (#3163)
  Scaffold CI workflow and build scripts for first-run consistency (#3097)
  Add OPTIONAL triage tier and fix recommendations to /address-review (#3161)
  chore: sync Gemfile.lock with term-ansicolor 1.11.3 (#3164)
  Simplify the docs sidebar and Pro landing pages (#3119)
  ...
justin808 added a commit that referenced this pull request Apr 23, 2026
* origin/main:
  fix(specs): boot dummy specs without readline and drop redundant pnpm workspace (#3190)
  docs: add RSC migration success stories page (#1985) (#3162)
  Fix Bencher reporting permanently broken on pushes to main (#3148)
  docs: add example migrations guide (#3126)
  docs: remove defunct guavapass.com reference (#3199)
  chore: remove redundant --rsc-pro install generator flag (#3105)
  ci: warn (don't fail) on Bencher main regression (#3168)
  test: enable RSpec --profile to surface slowest package tests (#3176)
  fix(node-renderer): expose performance in VM context when supportModules (#3158)
  docs: remove stale immediate_hydration references (#3139) (#3159)
  docs: restore absolute URL for node-renderer testing example (#3179)
  Bump Rspack dependencies to v2 (^2.0.0-0) (#3084)
  chore: remove obsolete webpack <5.106.0 pin (#3175)
  Move Node Renderer entry point to renderer/ directory (#3165)
  docs: address RSC pitfalls review follow-ups (#3155) (#3156)

# Conflicts:
#	CHANGELOG.md
justin808 added a commit that referenced this pull request May 4, 2026
…rn/npm-security-dd6aeadc3f

* origin/main: (34 commits)
  fix(pro-dummy): make manual node-renderer validation reliable (#3200)
  [codex] Add Markdown Prettier CI check (#3242)
  Add /stress-test Claude Code command for adversarial QA (#3207)
  Document examples catalog and naming plan (#3191)
  test(dummy): enable StrictMode in OSS and Pro dummies (#3206)
  ci: exclude bot-blocking URLs from lychee link check (#3214)
  Remove stale Coveralls integration (#3204)
  docs: normalize external GitHub repo slugs in links and generators (#3198)
  docs: add Example Migrations page (#3125) (#3197)
  docs: warn about react_component helper collision with react-rails (#3143) (#3160)
  docs: legacy Webpacker and migration-fit guidance (#3138) (#3157)
  fix(specs): boot dummy specs without readline and drop redundant pnpm workspace (#3190)
  docs: add RSC migration success stories page (#1985) (#3162)
  Fix Bencher reporting permanently broken on pushes to main (#3148)
  docs: add example migrations guide (#3126)
  docs: remove defunct guavapass.com reference (#3199)
  chore: remove redundant --rsc-pro install generator flag (#3105)
  ci: warn (don't fail) on Bencher main regression (#3168)
  test: enable RSpec --profile to surface slowest package tests (#3176)
  fix(node-renderer): expose performance in VM context when supportModules (#3158)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant