prevent concatenation of rake lint params to npm lint params#299
Merged
justin808 merged 1 commit intoshakacode:masterfrom Feb 27, 2016
Merged
prevent concatenation of rake lint params to npm lint params#299justin808 merged 1 commit intoshakacode:masterfrom
justin808 merged 1 commit intoshakacode:masterfrom
Conversation
Contributor
mpugach
commented
Feb 26, 2016
mpugach
commented
| if (err) console.error(err); | ||
| console.log( | ||
| '=> 🔥 Webpack development server is running on port ' + PORT | ||
| `=> 🔥 Webpack development server is running on port ${PORT}` |
Contributor
Author
There was a problem hiding this comment.
now this is spotted by linters
Member
|
Reviewed 2 of 2 files at r1. lib/generators/react_on_rails/templates/base/base/client/server.js, line 67 [r1] (raw file): Comments from the review on Reviewable.io |
justin808
added a commit
that referenced
this pull request
Feb 27, 2016
prevent concatenation of rake lint params to npm lint params
Member
|
Merged. Thanks @mpugach! |
AbanoubGhadban
pushed a commit
that referenced
this pull request
Sep 25, 2025
Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2. - [Release notes](https://github.com/isaacs/minimatch/releases) - [Commits](isaacs/minimatch@v3.0.4...v3.1.2) --- updated-dependencies: - dependency-name: minimatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
AbanoubGhadban
pushed a commit
that referenced
this pull request
Sep 26, 2025
Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2. - [Release notes](https://github.com/isaacs/minimatch/releases) - [Commits](isaacs/minimatch@v3.0.4...v3.1.2) --- updated-dependencies: - dependency-name: minimatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
3 tasks
This was referenced Mar 8, 2026
This was referenced Mar 15, 2026
This was referenced Mar 24, 2026
4 tasks
This was referenced Apr 18, 2026
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.