Skip to content

fix build comment in generator#284

Merged
justin808 merged 1 commit intoshakacode:masterfrom
ttrmw:generator-comment-fix
Feb 20, 2016
Merged

fix build comment in generator#284
justin808 merged 1 commit intoshakacode:masterfrom
ttrmw:generator-comment-fix

Conversation

@ttrmw
Copy link
Copy Markdown

@ttrmw ttrmw commented Feb 19, 2016

Pretty sure this comment was meant to include :client?

Review on Reviewable

@aaronvb
Copy link
Copy Markdown
Member

aaronvb commented Feb 19, 2016

@ttrmw You are correct, npm run build:dev is not a valid run command. The client webpack should be run with npm run build:dev:client.

justin808 added a commit that referenced this pull request Feb 20, 2016
@justin808 justin808 merged commit 0f14e47 into shakacode:master Feb 20, 2016
@justin808
Copy link
Copy Markdown
Member

Thanks @ttrmw

AbanoubGhadban pushed a commit that referenced this pull request Sep 25, 2025
AbanoubGhadban pushed a commit that referenced this pull request Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants