Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Review Summary

The PR is a clean, focused addition that wires --pro through all the right layers (types, CLI parsing, generator args, gem installation, step counting, log messages). The core logic is correct and the test coverage for the happy path is solid.

A few issues worth addressing:

Minor issues

1. Redundant help text entry (index.ts line 121): The --pro URL listed in the help text is identical to the default (hello_world). This could mislead users into thinking the flag does nothing visible. See inline comment.

2. Silent flag suppression when --pro + --rsc are both set (index.ts line 48): The precedence logic is correct, but users who accidentally pass both flags get no feedback that --pro was ignored. A single logInfo warning would prevent confusion. See inline comment.

3. Long ternary chain in log message (index.ts line 80): Already getting unwieldy; extracting a modeDesc variable would improve readability. See inline comment.

Test coverage gaps (create-app.test.ts line 289)

• No createApp test for the --pro --rsc combination — buildGeneratorArgs has this covered but the full createApp call sequence (gem install order, generator flags) is untested for that combination.
• No --rspack --pro combined test analogous to the existing RSC all-flags test.

No security or performance concerns with this change.

Greptile Summary

This PR adds a --pro CLI flag to create-react-on-rails-app, allowing users to scaffold a React on Rails Pro setup without also enabling React Server Components (--rsc). It correctly threads pro through CliOptions, buildGeneratorArgs (with --rsc taking precedence over --pro when both are set), and createApp (shared proRequested / proModeLabel guards), and extends test coverage for the new flag.

Key changes:

• types.ts: pro: boolean added to CliOptions
• create-app.ts: buildGeneratorArgs emits --pro only when pro && !rsc; createApp installs react_on_rails_pro for both --pro and --rsc via the shared proRequested flag
• index.ts: New --pro Commander option, updated info messages and help text; help text contains a duplicate URL entry for --pro (same hello_world route as default)
• tests/create-app.test.ts: New generator-args and full createApp flow tests for --pro, plus --rsc-over---pro precedence test; existing tests for local gem path, missing gem path, and install failure only exercise --rsc, leaving the equivalent --pro branches untested

Confidence Score: 4/5

• PR is safe to merge; all logic is correct and the primary user path is well-tested.
• The implementation is clean and the precedence logic (--rsc over --pro) is correctly enforced in both buildGeneratorArgs and createApp. The only gaps are a minor help-text redundancy and missing sibling tests for the --pro-only variants of three existing edge-case tests (local gem path, missing path exit, install-failure cleanup) — none of which affect correctness in production.
• tests/create-app.test.ts — three existing edge-case tests cover the shared code path only via --rsc; --pro equivalents are missing.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[npx create-react-on-rails-app my-app] --> B{Flags provided?}
    B -->|--pro| C[proRequested = true\nproModeLabel = '--pro']
    B -->|--rsc| D[proRequested = true\nproModeLabel = '--rsc']
    B -->|--pro + --rsc| E[proRequested = true\nproModeLabel = '--rsc'\nrsc takes precedence]
    B -->|none| F[proRequested = false]

    C --> G[Step 1: rails new]
    D --> G
    E --> G
    F --> G

    G --> H[Step 2: bundle add react_on_rails]

    H --> I{proRequested?}
    I -->|Yes| J[Step 3: bundle add react_on_rails_pro]
    I -->|No| K[Step 3: run generator]

    J --> L[Step 4: run generator\nwith --pro or --rsc flag]

    K --> M{options.rsc?}
    L --> M

    M -->|Yes| N[Visit /hello_server]
    M -->|No| O[Visit /hello_world]

_{Reviews (1): Last reviewed commit: "Document create-react-on-rails-app --pro..." | Re-trigger Greptile}

size-limit report 📦

Addressed review feedback in latest push:

• Added explicit user-facing note when both --pro and --rsc are provided (--rsc precedence).
• Refactored creation summary mode suffix into a dedicated variable for readability.
• Clarified help text route line to hello_world (default and --pro).
• Added maintainer comment in generator arg builder explaining why --rsc supersedes --pro.
• Expanded tests for requested combinations:
  • buildGeneratorArgs: --rspack --pro
  • createApp: --pro --rsc integration path (ensures generator gets --rsc)
  • createApp: --pro parity tests for local pro gem path, missing pro gem path, and pro gem add failure cleanup.

Local verification:

• pnpm --filter create-react-on-rails-app test
• pnpm --filter create-react-on-rails-app type-check
• pnpm exec prettier --check packages/create-react-on-rails-app/src/index.ts packages/create-react-on-rails-app/src/create-app.ts packages/create-react-on-rails-app/tests/create-app.test.ts

Follow-up push applied: added explicit --rspack --pro command example in CLI help text so --pro parity is visible alongside --rsc combinations.

Re-verified locally:

• pnpm exec prettier --check packages/create-react-on-rails-app/src/index.ts
• pnpm --filter create-react-on-rails-app test
• pnpm --filter create-react-on-rails-app type-check

Overall this is a clean, focused implementation that correctly threads the --pro flag through option parsing, generator arg building, and app creation. The Rails generator already had --pro support, so the CLI now correctly maps to it. Test coverage is solid.

A few things worth noting (inline comments posted separately):

proModeLabel computed unconditionally — when neither flag is set, this variable evaluates to '--pro' which is technically wrong (though harmless since it is only used inside if (proRequested)). Moving it inside the guarded block would make the intent clearer.

Cleanup messages when both --rsc and --pro are set — failure messages will say "rerun with --rsc", which may surprise a user who explicitly typed both flags. A small clarification in the message text would help.

Missing --pro --rspack help text example — --rspack --rsc is shown but not --pro --rspack, despite the code and tests supporting it.

No createApp integration test for --pro --rspack — there is a buildGeneratorArgs test for this combo but no end-to-end createApp test. Low risk given other coverage, but worth adding.

Help text does not explain what --pro adds vs default — new users won't know when to choose --pro without a brief description of what Pro features are enabled.

All of these are nits or suggestions. The core logic is correct and the important paths are well-tested.

Follow-up push (9af72eb) addresses the remaining thread about proModeLabel lifecycle:

• createApp now computes proModeLabel only when Pro mode is actually requested.
• This keeps the variable semantics aligned with control flow while preserving existing runtime behavior.

Re-verified locally:

• pnpm --filter create-react-on-rails-app test
• pnpm --filter create-react-on-rails-app type-check

Review: Add --pro support to create-react-on-rails-app CLI

Overall this is a clean, well-structured PR. The implementation correctly threads --pro through the CLI, CliOptions, and generator arg building, and the test coverage is solid — happy paths, error/cleanup paths, local gem path override, and precedence behavior are all exercised.

Confirmed: The underlying Rails generator already accepts --pro (declared as class_option :pro in install_generator.rb), so there's no risk of a runtime flag rejection.

One minor wording issue flagged inline — see comment on index.ts.