Skip to content

Added errors if a null component is registered#273

Merged
justin808 merged 4 commits intomasterfrom
better-errors
Feb 14, 2016
Merged

Added errors if a null component is registered#273
justin808 merged 4 commits intomasterfrom
better-errors

Conversation

@justin808
Copy link
Copy Markdown
Member

Review on Reviewable

@justin808
Copy link
Copy Markdown
Member Author

@robwise @jbhatab or @alexfedoseev, please review so I can merge.

* Update CHANGELOG.md
* rackt => reactjs for github
* update nvm and ruby
* Update dependencies
@justin808
Copy link
Copy Markdown
Member Author

@robwise There's an error with auto-rebuilding of the server rendering file:

Repro:

rake examples:gen_basic-server-rendering
cd gen-examples/examples/basic-server-rendering
rspec

But if you then run: foreman start -f Procfile.dev and then run rspec, tests pass.

@justin808
Copy link
Copy Markdown
Member Author

@alexfedoseev Please review.

@justin808
Copy link
Copy Markdown
Member Author

@robwise Looks like it was a transient issue.

@alex35mil
Copy link
Copy Markdown
Member

Looks good! 👍

@jbhatab
Copy link
Copy Markdown
Member

jbhatab commented Feb 14, 2016

LGTM

justin808 added a commit that referenced this pull request Feb 14, 2016
Added errors if a null component is registered
@justin808 justin808 merged commit 59dda39 into master Feb 14, 2016
@robwise robwise deleted the better-errors branch February 15, 2016 04:36
AbanoubGhadban pushed a commit that referenced this pull request Sep 25, 2025
AbanoubGhadban pushed a commit that referenced this pull request Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants