Fix missing v prefix in changelog compare links by justin808 · Pull Request #2628 · shakacode/react_on_rails

justin808 · 2026-03-16T01:57:35Z

Summary

Fix update_changelog_links to include the v prefix in generated compare URLs. Previously it produced broken links like .../compare/v16.3.0...16.4.0.rc.10 instead of .../compare/v16.3.0...v16.4.0.rc.10.
Fix cleanup_collapsed_prerelease_links to correctly detect prerelease versions that have a v prefix when determining the stable "from" version.
Fix existing broken links in CHANGELOG.md for the 16.4.0.rc.10 entry.
Fix documentation in .claude/commands/update-changelog.md — clarify that compare link URLs must use the v prefix (only changelog headers omit it).
Add test for v-prefixed prerelease links in cleanup function.

Test plan

All 27 update_changelog_rake_helpers_spec.rb tests pass
New test verifies cleanup handles v-prefixed prerelease compare links
RuboCop clean
Verify fixed CHANGELOG link works: v16.3.0...v16.4.0.rc.10

🤖 Generated with Claude Code

Note

Low Risk
Low risk: only adjusts changelog link generation/cleanup logic and related documentation/tests; no runtime library behavior changes.

Overview
Fixes changelog compare URLs to consistently use the git-tag v prefix (while keeping changelog headers unprefixed), preventing broken GitHub compare links.

Updates the update_changelog rake helpers to generate v-prefixed [unreleased] and version links and to correctly detect stable “from” versions when prerelease compare links include a v prefix; adds regression coverage for this case and corrects existing broken links in CHANGELOG.md plus clarifying guidance in .claude/commands/update-changelog.md.

^{Written by Cursor Bugbot for commit 0ce48dc. Configure here.}

Summary by CodeRabbit

Documentation
- Updated changelog guidance for consistent version tag formatting in links.
Chores
- Improved changelog link accuracy and version tag consistency.
- Enhanced changelog link generation for better reliability.
Tests
- Added test coverage for version tag handling in changelog links.

The update_changelog_links function generated compare URLs without the v prefix on git tags, producing broken links like .../compare/v16.3.0...16.4.0.rc.10 instead of .../compare/v16.3.0...v16.4.0.rc.10. Also fix cleanup_collapsed_prerelease_links to handle v-prefixed versions when detecting prereleases, and correct the existing broken links in CHANGELOG.md and documentation examples. Co-Authored-By: Claude Opus 4.6 <[email protected]>

coderabbitai · 2026-03-16T01:57:52Z

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)

react_on_rails_pro/Gemfile.lock is excluded by !**/*.lock
react_on_rails_pro/spec/dummy/Gemfile.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: dc363417-99d3-47d7-83ce-8225c767f92f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Walkthrough

Updates changelog management to consistently handle v-prefixed git tags in compare links while maintaining v-free headers. Modifies the update_changelog rake task to process v-prefixed versions and generate appropriately formatted links. Updates tests and documentation to reflect the new version prefix handling behavior.

Changes

Cohort / File(s)	Summary
Documentation & Guidance `.claude/commands/update-changelog.md`	Clarifies that compare links must preserve v-prefixed git tags, while changelog headers should strip the v prefix. Expands examples to show mixed usage: headers without v, bottom links with v.
Changelog Updates `CHANGELOG.md`	Updates anchor links for `[unreleased]` and `[16.4.0.rc.10]` to reference v-prefixed compare ranges (v16.4.0.rc.10...master and v16.3.0...v16.4.0.rc.10).
Implementation & Tests `react_on_rails/rakelib/update_changelog.rake`, `react_on_rails/spec/react_on_rails/update_changelog_rake_helpers_spec.rb`	Rake task now strips leading v-prefix when detecting stable versions in prerelease cleanup, and generates v-prefixed compare links. Spec expanded with test scenario for v-prefixed prerelease versions and updated assertions for v-prefixed URLs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Fix version link formatting in CHANGELOG.md #2263: Modifies CHANGELOG version-compare link formatting and v-prefix handling in version tags, overlapping with this PR's version normalization work.

Suggested labels

review-needed

Poem

🐰 A changelog grows with every v tag,
Where prefixes dance—some stay, some lag!
Headers shine bare, while links wear their v,
Version control clarity, as it should be! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: fixing missing v prefixes in changelog compare links, which aligns with the core objectives of the PR.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch jg/fix-changelog-v-prefix

📝 Coding Plan

Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

claude · 2026-03-16T01:59:48Z

-  new_unreleased_link = "#{compare_link_prefix}/#{version}...master"
-  new_version_link = "#{anchor}: #{compare_link_prefix}/#{prev_version}...#{version}"
+  new_unreleased_link = "#{compare_link_prefix}/v#{version}...master"
+  new_version_link = "#{anchor}: #{compare_link_prefix}/#{prev_version}...v#{version}"


Minor edge case: prev_version is captured verbatim from the existing [unreleased] line, so if the CHANGELOG was written with the old (no-v) format, the generated link will be 16.x.x...v16.y.y — inconsistent but still functional on GitHub.

This is only a concern for changelogs that haven't been updated through this PR's fix yet. Once the [unreleased] line is correct (i.e. compare/v...master), all subsequent calls will produce fully-consistent links.

If you ever want to make this bulletproof:

Suggested change

new_version_link = "#{anchor}: #{compare_link_prefix}/#{prev_version}...v#{version}"

new_version_link = "#{anchor}: #{compare_link_prefix}/v#{prev_version.delete_prefix("v")}...v#{version}"

Not strictly necessary since normalize_version_string guarantees version is always prefix-free, but it would make prev_version handling symmetrical.

claude · 2026-03-16T01:59:53Z

-[16.4.0.rc.10]: https://github.com/shakacode/react_on_rails/compare/v16.3.0...16.4.0.rc.10
+[unreleased]: https://github.com/shakacode/react_on_rails/compare/v16.4.0.rc.10...master
+[16.4.0.rc.10]: https://github.com/shakacode/react_on_rails/compare/v16.3.0...v16.4.0.rc.10
 [16.3.0]: https://github.com/shakacode/react_on_rails/compare/v16.2.1...v16.3.0


While you're fixing v-prefix consistency, there's a pre-existing inconsistency a few lines below:

[16.2.0]: https://github.com/shakacode/react_on_rails/compare/16.1.1...v16.2.0

16.1.1 is missing its v prefix. Not a blocker for this PR (it's historical and out of scope), but worth a follow-up or one-liner fix here.

greptile-apps · 2026-03-16T01:59:54Z

Greptile Summary

This PR fixes a bug where the update_changelog_links helper generated broken GitHub compare URLs by omitting the v prefix on the new version tag (e.g., .../compare/v16.3.0...16.4.0.rc.10 instead of .../compare/v16.3.0...v16.4.0.rc.10). It also fixes cleanup_collapsed_prerelease_links to correctly identify stable "from" versions even when compare links already include the v prefix.

Adds v prefix to both the unreleased link and version link in update_changelog_links
Strips v prefix via delete_prefix("v") before matching against the prerelease pattern in cleanup_collapsed_prerelease_links
Fixes the two broken compare links for the 16.4.0.rc.10 entry in CHANGELOG.md
Updates documentation in .claude/commands/update-changelog.md to clarify that compare link URLs must use the v prefix while changelog headers should not
Adds a new test case for v-prefixed prerelease links and updates existing test expectations to match the corrected behavior

Confidence Score: 5/5

This PR is safe to merge — it fixes a clear bug with correct logic and good test coverage.
The changes are minimal, targeted, and well-tested. The two code fixes (v prefix in URL generation and delete_prefix("v") in prerelease detection) are both straightforward and correct. The existing test suite covers the behavior, and a new test specifically validates the v-prefixed prerelease scenario. No risk of regression.
No files require special attention.

Important Files Changed

Filename	Overview
react_on_rails/rakelib/update_changelog.rake	Correctly adds `v` prefix to generated compare URLs and strips `v` prefix before matching prerelease patterns in cleanup function.
react_on_rails/spec/react_on_rails/update_changelog_rake_helpers_spec.rb	Adds new test for v-prefixed prerelease links and updates existing test expectations to match the corrected v-prefixed URLs.
CHANGELOG.md	Fixes broken compare links for 16.4.0.rc.10 entry by adding missing `v` prefix to version references in URLs.
.claude/commands/update-changelog.md	Clarifies documentation to distinguish that changelog headers omit the `v` prefix but compare link URLs must include it.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["update_changelog_links(changelog, version, anchor)"] --> B["Match existing [unreleased] compare link"]
    B --> C["Extract prev_version from URL"]
    C --> D["Build new unreleased link:\n.../compare/v{version}...master"]
    C --> E["Build new version link:\n.../compare/{prev_version}...v{version}"]
    D --> F["Replace old link with new unreleased + version links"]
    E --> F

    G["cleanup_collapsed_prerelease_links(changelog, base_version)"] --> H["Scan prerelease compare links"]
    H --> I["For each from_version:\ndelete_prefix('v') before matching prerelease pattern"]
    I --> J{"Is from_version\na stable version?"}
    J -->|Yes| K["Set stable_from = from_version\n(preserves 'v' prefix)"]
    J -->|No| H
    K --> L["Update [unreleased] link to use stable_from"]
    L --> M["Remove all prerelease link lines"]

_{Last reviewed commit: 0ce48dc}

claude · 2026-03-16T02:00:16Z

Review

The fix is correct and well-scoped. Here's a quick summary of what I verified:

Logic correctness ✅

cleanup_collapsed_prerelease_links: The old code compared from_version (e.g., v16.4.0.rc.0) directly against a pattern that doesn't account for the leading v, causing v16.4.0.rc.0 to be misidentified as a stable version. delete_prefix("v") before matching is the right fix.

update_changelog_links: Hardcoding v#{version} is safe here because all call sites pass changelog_version through normalize_version_string, which always strips the v prefix (line 29 of the rake file). No risk of double-v.

stable_from roundtrip: The captured value (e.g., v16.3.0) is substituted back into the [unreleased] link as-is, so the v prefix is correctly preserved in the output.

Tests ✅

The new test exercises exactly the scenario that was broken — v-prefixed prerelease compare links — and the existing update_changelog_links test expectations are updated to match the corrected output.

Minor notes (see inline comments)

prev_version in update_changelog_links is taken verbatim from the existing CHANGELOG, so a legacy no-v entry would produce a slightly inconsistent new link. Not a bug in practice but worth knowing.
[16.2.0] in CHANGELOG.md has a pre-existing 16.1.1 (no v) — out of scope here but easy to clean up as a follow-on.

Overall: LGTM. Root cause correctly diagnosed, minimal fix applied in the right places, regression coverage added.

Co-Authored-By: Claude Opus 4.6 <[email protected]>

claude · 2026-03-16T02:28:14Z

Code Review: The core logic changes are correct and well-tested.

Correctness

cleanup_collapsed_prerelease_links fix: Stripping the v via delete_prefix('v') before matching against prerelease_pattern is the right fix. Without it, a from_version of v16.4.0.rc.0 would not match the pattern (which expects a 16.4.0 prefix, not v16.4.0), so it would be incorrectly treated as a stable version.

update_changelog_links fix: Hardcoding v prefix is safe because all call sites pass version strings through normalize_version_string which always strips the v -- no risk of double-prefix.

stable_from roundtrip: The captured value (e.g., v16.3.0) is substituted directly into the [unreleased] link, so the v prefix is correctly preserved.

Minor observations

prev_version not normalized (update_changelog.rake line 434): prev_version is taken verbatim from the existing [unreleased] link. If a CHANGELOG still uses a no-v unreleased link, the new version link will be inconsistent (e.g., compare/16.3.0...v16.4.0). Mitigated by the CHANGELOG.md fix in this PR.
Pre-existing CHANGELOG inconsistency: [16.2.0] still uses 16.1.1 (no v) in its compare URL -- easy to clean up as a follow-on.
Unrelated Gemfile.lock changes: react_on_rails_pro/Gemfile.lock includes dependency bumps unrelated to this fix -- notably commonmarker 1.1.4 to 2.7.0 (major version bump) and ffi 1.17.0 to 1.17.3. Worth confirming these are intentional or separating them.

Tests: The new test directly exercises the broken scenario (v-prefixed prerelease compare links) and updated expectations match the corrected output.

Overall: LGTM -- root cause correctly diagnosed, minimal targeted fix, regression coverage added.

claude · 2026-03-16T02:28:28Z

-  new_unreleased_link = "#{compare_link_prefix}/#{version}...master"
-  new_version_link = "#{anchor}: #{compare_link_prefix}/#{prev_version}...#{version}"
+  new_unreleased_link = "#{compare_link_prefix}/v#{version}...master"
+  new_version_link = "#{anchor}: #{compare_link_prefix}/#{prev_version}...v#{version}"


Note: prev_version is captured verbatim from the existing [unreleased] link in the CHANGELOG. After this PR's CHANGELOG.md fix the value will be v16.4.0.rc.10 (with v), giving a correct compare/v16.4.0.rc.10...v16.4.0 link. However, if this function were ever called against a legacy CHANGELOG where the [unreleased] line had no v prefix, prev_version would be 16.4.0.rc.10 and the output would be an inconsistent compare/16.4.0.rc.10...v16.4.0. Not a bug in this PR's scope, but something to keep in mind if the function is reused elsewhere.

claude · 2026-03-16T02:28:36Z

@@ -140,9 +140,9 @@ GEM
    cgi (0.5.1)
    childprocess (5.0.0)
    coderay (1.1.3)


This is a significant major version bump (commonmarker 1.1.4 → 2.7.0). The PR description doesn't mention this change — was this intentional (e.g., from running bundle update)? If so, it might be cleaner to land it in a separate commit or PR so that any breakage from the commonmarker API change can be isolated from the changelog link fix.

## Summary - **Fix `update_changelog_links`** to include the `v` prefix in generated compare URLs. Previously it produced broken links like `.../compare/v16.3.0...16.4.0.rc.10` instead of `.../compare/v16.3.0...v16.4.0.rc.10`. - **Fix `cleanup_collapsed_prerelease_links`** to correctly detect prerelease versions that have a `v` prefix when determining the stable "from" version. - **Fix existing broken links** in CHANGELOG.md for the 16.4.0.rc.10 entry. - **Fix documentation** in `.claude/commands/update-changelog.md` — clarify that compare link URLs must use the `v` prefix (only changelog headers omit it). - **Add test** for `v`-prefixed prerelease links in cleanup function. ## Test plan - [x] All 27 `update_changelog_rake_helpers_spec.rb` tests pass - [x] New test verifies cleanup handles `v`-prefixed prerelease compare links - [x] RuboCop clean - [ ] Verify fixed CHANGELOG link works: v16.3.0...v16.4.0.rc.10 🤖 Generated with [Claude Code](https://claude.com/claude-code)  --- > [!NOTE] > **Low Risk** > Low risk: only adjusts changelog link generation/cleanup logic and related documentation/tests; no runtime library behavior changes. > > **Overview** > Fixes changelog compare URLs to consistently use the git-tag `v` prefix (while keeping changelog headers unprefixed), preventing broken GitHub compare links. > > Updates the `update_changelog` rake helpers to generate `v`-prefixed `[unreleased]` and version links and to correctly detect stable “from” versions when prerelease compare links include a `v` prefix; adds regression coverage for this case and corrects existing broken links in `CHANGELOG.md` plus clarifying guidance in `.claude/commands/update-changelog.md`. > > Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 0ce48dc. Configure [here](https://cursor.com/dashboard?tab=bugbot).   ## Summary by CodeRabbit * **Documentation** * Updated changelog guidance for consistent version tag formatting in links. * **Chores** * Improved changelog link accuracy and version tag consistency. * Enhanced changelog link generation for better reliability. * **Tests** * Added test coverage for version tag handling in changelog links.  --------- Co-authored-by: Claude Opus 4.6 <[email protected]>

## Summary Syncs recent improvements from shakacode/react_on_rails (PRs [#2596](shakacode/react_on_rails#2596), [#2608](shakacode/react_on_rails#2608), [#2628](shakacode/react_on_rails#2628)) into the `/update-changelog` command. **Changes to `.claude/commands/update-changelog.md`:** - **Explicit version argument**: `/update-changelog 9.7.0.rc.10` now stamps the exact version provided, skipping auto-computation - **Git-tags-only RC index**: RC/beta index computation now uses only git tags, not changelog headers (headers are drafts, tags are shipped versions) - **Ambiguous bump explanation**: Version confirmation step now explains reasoning when bump type is ambiguous and asks user to confirm/override - **Tag reconciliation step**: New Step 2 catches missing version sections by comparing git tags against changelog headers (the #1 source of errors when skipped) - **Auto-commit/push/PR**: When stamping versions (`release`/`rc`/`beta`/explicit), automatically creates branch, commits, pushes, and opens PR - **Heading consolidation**: Prerelease collapse now consolidates duplicate category headings (e.g., two `### Fixed` become one) - **Orphaned link cleanup**: Prerelease collapse removes leftover compare links for collapsed prerelease sections - **v prefix clarity**: Explicit note that compare links must use `v` prefix to match git tags - **Header placement rule**: New version header must go immediately after `## [Unreleased]` **No changes to `rakelib/release.rake` or `docs/releasing.md`** — react_on_rails had no changes to those files in the last 3 days. ## Test plan - [ ] Run `/update-changelog` and verify the new tag reconciliation step (Step 2) runs before adding entries - [ ] Run `/update-changelog rc` and verify RC index is computed from git tags only - [ ] Run `/update-changelog 9.7.0` and verify explicit version stamps correctly - [ ] Run `/update-changelog release` and verify it auto-commits, pushes, and opens PR 🤖 Generated with [Claude Code](https://claude.com/claude-code)  --- > [!NOTE] > **Low Risk** > Low risk because this PR only updates the `.claude/commands/update-changelog.md` documentation/workflow guidance and does not change runtime code paths. > > **Overview** > Updates the `/update-changelog` command guide to support *explicit version stamping* and to clarify that RC/beta increments must be derived **only from git tags** (not draft changelog headers), with improved user confirmation when version bump type is ambiguous. > > Reworks the process steps to add an upfront **tag-vs-changelog reconciliation** phase for missing release sections, clarifies compare-link `v`-prefix requirements and header placement, and expands prerelease-collapsing rules (merge duplicate category headings, remove orphaned diff links). When stamping versions (`release`/`rc`/`beta`/explicit), the guide now instructs auto-creating a branch, committing, pushing, and opening a PR. > > Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit b116cc2. Configure [here](https://cursor.com/dashboard?tab=bugbot).   ## Summary by CodeRabbit * **Documentation** * Added explicit-version option and validation requiring it to be newer than existing tags. * Updated 5-step workflow with a reconciliation step that creates/moves version sections and consolidates prereleases. * Enforced v-prefix for bottom compare links and expanded formatting/verification guidance, plus CRITICAL insertion position note. * **New Features** * Shows computed version with confirmation prompt, explains ambiguous bumps, and summarizes actions taken. * Optional auto-commit/PR creation limited to CHANGELOG.md.  --------- Co-authored-by: Claude Opus 4.6 <[email protected]>

## Summary Recent commits (15f6cfc, 078a8b0, 97f4625) updated `update_changelog.rake` and `update-changelog.md` with significant improvements (orphaned prerelease link cleanup, v prefix fix for compare links, consolidate/deduplicate blocks, explicit version support, auto-commit/push/PR). However `releasing.md` was not updated to match, leaving stale instructions. - **releasing.md**: Update step 1 to reflect `/update-changelog` now supports explicit versions, collapses prereleases with dedup, and auto-commits/pushes/opens a PR (removes manual "commit and push CHANGELOG.md" step) - **releasing.md**: Add note about `v` prefix requirement in CHANGELOG compare links (per #2628 fix) - **releasing.md**: Update Option A post-release instructions to match new auto-PR behavior - **update-changelog.md**: Fix stale description saying version computed from "changelog headings and git tags" -- prerelease index is now determined solely from git tags No changes to `release.rake` -- it was not affected by the recent changes. ## Test plan - [ ] Verify `releasing.md` step 1 accurately describes current `/update-changelog` behavior - [ ] Verify compare link `v` prefix note matches actual `update_changelog_links()` behavior - [ ] Verify `update-changelog.md` description matches `compute_auto_version()` logic 🤖 Generated with [Claude Code](https://claude.com/claude-code)  --- > [!NOTE] > **Low Risk** > Documentation-only updates that align release/changelog instructions with current automation behavior; no runtime code paths or release tooling logic changed. > > **Overview** > Aligns release and changelog docs with the updated `/update-changelog` automation: explicit version support, skipping auto-versioning when provided, prerelease section collapse/dedup, and auto commit/push/PR creation. > > Clarifies versioning/link rules (prerelease index derived from git tags only; CHANGELOG compare links must use `v`-prefixed tags), updates instructions from `master` to `main`, and refreshes post-release catch-up steps to use the new auto-PR flow. > > Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit a48394a. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).   ## Summary by CodeRabbit * **Documentation** * Added support for explicit prerelease/versions (e.g., 16.5.0.rc.10); auto-version computation is skipped when explicit version provided * Clarified prerelease changelog handling: collapse prior prerelease sections, deduplicate entries, and derive prerelease index from git tags * Documented automated workflow: command can automatically commit, push, and open a PR (now requires working on main) * Require changelog compare links to use v-prefixed tag names and compare against main  --------- Co-authored-by: Claude Opus 4.6 <[email protected]>

## Summary - **Fix `update_changelog_links`** to include the `v` prefix in generated compare URLs. Previously it produced broken links like `.../compare/v16.3.0...16.4.0.rc.10` instead of `.../compare/v16.3.0...v16.4.0.rc.10`. - **Fix `cleanup_collapsed_prerelease_links`** to correctly detect prerelease versions that have a `v` prefix when determining the stable "from" version. - **Fix existing broken links** in CHANGELOG.md for the 16.4.0.rc.10 entry. - **Fix documentation** in `.claude/commands/update-changelog.md` — clarify that compare link URLs must use the `v` prefix (only changelog headers omit it). - **Add test** for `v`-prefixed prerelease links in cleanup function. ## Test plan - [x] All 27 `update_changelog_rake_helpers_spec.rb` tests pass - [x] New test verifies cleanup handles `v`-prefixed prerelease compare links - [x] RuboCop clean - [ ] Verify fixed CHANGELOG link works: v16.3.0...v16.4.0.rc.10 🤖 Generated with [Claude Code](https://claude.com/claude-code)  --- > [!NOTE] > **Low Risk** > Low risk: only adjusts changelog link generation/cleanup logic and related documentation/tests; no runtime library behavior changes. > > **Overview** > Fixes changelog compare URLs to consistently use the git-tag `v` prefix (while keeping changelog headers unprefixed), preventing broken GitHub compare links. > > Updates the `update_changelog` rake helpers to generate `v`-prefixed `[unreleased]` and version links and to correctly detect stable “from” versions when prerelease compare links include a `v` prefix; adds regression coverage for this case and corrects existing broken links in `CHANGELOG.md` plus clarifying guidance in `.claude/commands/update-changelog.md`. > > Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 0ce48dc. Configure [here](https://cursor.com/dashboard?tab=bugbot).   ## Summary by CodeRabbit * **Documentation** * Updated changelog guidance for consistent version tag formatting in links. * **Chores** * Improved changelog link accuracy and version tag consistency. * Enhanced changelog link generation for better reliability. * **Tests** * Added test coverage for version tag handling in changelog links.  --------- Co-authored-by: Claude Opus 4.6 <[email protected]>

## Summary Recent commits (15f6cfc, 078a8b0, 97f4625) updated `update_changelog.rake` and `update-changelog.md` with significant improvements (orphaned prerelease link cleanup, v prefix fix for compare links, consolidate/deduplicate blocks, explicit version support, auto-commit/push/PR). However `releasing.md` was not updated to match, leaving stale instructions. - **releasing.md**: Update step 1 to reflect `/update-changelog` now supports explicit versions, collapses prereleases with dedup, and auto-commits/pushes/opens a PR (removes manual "commit and push CHANGELOG.md" step) - **releasing.md**: Add note about `v` prefix requirement in CHANGELOG compare links (per #2628 fix) - **releasing.md**: Update Option A post-release instructions to match new auto-PR behavior - **update-changelog.md**: Fix stale description saying version computed from "changelog headings and git tags" -- prerelease index is now determined solely from git tags No changes to `release.rake` -- it was not affected by the recent changes. ## Test plan - [ ] Verify `releasing.md` step 1 accurately describes current `/update-changelog` behavior - [ ] Verify compare link `v` prefix note matches actual `update_changelog_links()` behavior - [ ] Verify `update-changelog.md` description matches `compute_auto_version()` logic 🤖 Generated with [Claude Code](https://claude.com/claude-code)  --- > [!NOTE] > **Low Risk** > Documentation-only updates that align release/changelog instructions with current automation behavior; no runtime code paths or release tooling logic changed. > > **Overview** > Aligns release and changelog docs with the updated `/update-changelog` automation: explicit version support, skipping auto-versioning when provided, prerelease section collapse/dedup, and auto commit/push/PR creation. > > Clarifies versioning/link rules (prerelease index derived from git tags only; CHANGELOG compare links must use `v`-prefixed tags), updates instructions from `master` to `main`, and refreshes post-release catch-up steps to use the new auto-PR flow. > > Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit a48394a. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).   ## Summary by CodeRabbit * **Documentation** * Added support for explicit prerelease/versions (e.g., 16.5.0.rc.10); auto-version computation is skipped when explicit version provided * Clarified prerelease changelog handling: collapse prior prerelease sections, deduplicate entries, and derive prerelease index from git tags * Documented automated workflow: command can automatically commit, push, and open a PR (now requires working on main) * Require changelog compare links to use v-prefixed tag names and compare against main  --------- Co-authored-by: Claude Opus 4.6 <[email protected]>

## Summary - **Fix `update_changelog_links`** to include the `v` prefix in generated compare URLs. Previously it produced broken links like `.../compare/v16.3.0...16.4.0.rc.10` instead of `.../compare/v16.3.0...v16.4.0.rc.10`. - **Fix `cleanup_collapsed_prerelease_links`** to correctly detect prerelease versions that have a `v` prefix when determining the stable "from" version. - **Fix existing broken links** in CHANGELOG.md for the 16.4.0.rc.10 entry. - **Fix documentation** in `.claude/commands/update-changelog.md` — clarify that compare link URLs must use the `v` prefix (only changelog headers omit it). - **Add test** for `v`-prefixed prerelease links in cleanup function. ## Test plan - [x] All 27 `update_changelog_rake_helpers_spec.rb` tests pass - [x] New test verifies cleanup handles `v`-prefixed prerelease compare links - [x] RuboCop clean - [ ] Verify fixed CHANGELOG link works: v16.3.0...v16.4.0.rc.10 🤖 Generated with [Claude Code](https://claude.com/claude-code)  --- > [!NOTE] > **Low Risk** > Low risk: only adjusts changelog link generation/cleanup logic and related documentation/tests; no runtime library behavior changes. > > **Overview** > Fixes changelog compare URLs to consistently use the git-tag `v` prefix (while keeping changelog headers unprefixed), preventing broken GitHub compare links. > > Updates the `update_changelog` rake helpers to generate `v`-prefixed `[unreleased]` and version links and to correctly detect stable “from” versions when prerelease compare links include a `v` prefix; adds regression coverage for this case and corrects existing broken links in `CHANGELOG.md` plus clarifying guidance in `.claude/commands/update-changelog.md`. > > Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 0ce48dc. Configure [here](https://cursor.com/dashboard?tab=bugbot).   ## Summary by CodeRabbit * **Documentation** * Updated changelog guidance for consistent version tag formatting in links. * **Chores** * Improved changelog link accuracy and version tag consistency. * Enhanced changelog link generation for better reliability. * **Tests** * Added test coverage for version tag handling in changelog links.  --------- Co-authored-by: Claude Opus 4.6 <[email protected]>

## Summary Recent commits (15f6cfc, 078a8b0, 97f4625) updated `update_changelog.rake` and `update-changelog.md` with significant improvements (orphaned prerelease link cleanup, v prefix fix for compare links, consolidate/deduplicate blocks, explicit version support, auto-commit/push/PR). However `releasing.md` was not updated to match, leaving stale instructions. - **releasing.md**: Update step 1 to reflect `/update-changelog` now supports explicit versions, collapses prereleases with dedup, and auto-commits/pushes/opens a PR (removes manual "commit and push CHANGELOG.md" step) - **releasing.md**: Add note about `v` prefix requirement in CHANGELOG compare links (per #2628 fix) - **releasing.md**: Update Option A post-release instructions to match new auto-PR behavior - **update-changelog.md**: Fix stale description saying version computed from "changelog headings and git tags" -- prerelease index is now determined solely from git tags No changes to `release.rake` -- it was not affected by the recent changes. ## Test plan - [ ] Verify `releasing.md` step 1 accurately describes current `/update-changelog` behavior - [ ] Verify compare link `v` prefix note matches actual `update_changelog_links()` behavior - [ ] Verify `update-changelog.md` description matches `compute_auto_version()` logic 🤖 Generated with [Claude Code](https://claude.com/claude-code)  --- > [!NOTE] > **Low Risk** > Documentation-only updates that align release/changelog instructions with current automation behavior; no runtime code paths or release tooling logic changed. > > **Overview** > Aligns release and changelog docs with the updated `/update-changelog` automation: explicit version support, skipping auto-versioning when provided, prerelease section collapse/dedup, and auto commit/push/PR creation. > > Clarifies versioning/link rules (prerelease index derived from git tags only; CHANGELOG compare links must use `v`-prefixed tags), updates instructions from `master` to `main`, and refreshes post-release catch-up steps to use the new auto-PR flow. > > Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit a48394a. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).   ## Summary by CodeRabbit * **Documentation** * Added support for explicit prerelease/versions (e.g., 16.5.0.rc.10); auto-version computation is skipped when explicit version provided * Clarified prerelease changelog handling: collapse prior prerelease sections, deduplicate entries, and derive prerelease index from git tags * Documented automated workflow: command can automatically commit, push, and open a PR (now requires working on main) * Require changelog compare links to use v-prefixed tag names and compare against main  --------- Co-authored-by: Claude Opus 4.6 <[email protected]>

claude Bot reviewed Mar 16, 2026

View reviewed changes

coderabbitai Bot added the review-needed label Mar 16, 2026

coderabbitai Bot approved these changes Mar 16, 2026

View reviewed changes

Update react_on_rails_pro lockfiles

67a55eb

Co-Authored-By: Claude Opus 4.6 <[email protected]>

justin808 merged commit 078a8b0 into master Mar 16, 2026
19 of 20 checks passed

justin808 deleted the jg/fix-changelog-v-prefix branch March 16, 2026 02:23

claude Bot reviewed Mar 16, 2026

View reviewed changes

This was referenced Mar 16, 2026

Port update-changelog improvements from react_on_rails shakacode/shakapacker#982

Merged

Sync release docs with recent changelog automation changes #2634

Merged

justin808 mentioned this pull request Mar 18, 2026

Fix missing v prefix in changelog compare links #2735

Closed

justin808 mentioned this pull request Apr 4, 2026

Fix missing v prefix in changelog compare links #2989

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix missing v prefix in changelog compare links#2628

Fix missing v prefix in changelog compare links#2628
justin808 merged 2 commits intomasterfrom
jg/fix-changelog-v-prefix

justin808 commented Mar 16, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Mar 16, 2026 •

edited

Loading

Review skipped

Uh oh!

claude Bot Mar 16, 2026

Uh oh!

claude Bot Mar 16, 2026

Uh oh!

greptile-apps Bot commented Mar 16, 2026

Uh oh!

claude Bot commented Mar 16, 2026

Uh oh!

Uh oh!

claude Bot commented Mar 16, 2026

Uh oh!

claude Bot Mar 16, 2026

Uh oh!

claude Bot Mar 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	new_version_link = "#{anchor}: #{compare_link_prefix}/#{prev_version}...v#{version}"
	new_version_link = "#{anchor}: #{compare_link_prefix}/v#{prev_version.delete_prefix("v")}...v#{version}"

Uh oh!

Conversation

justin808 commented Mar 16, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Poem

Uh oh!

claude Bot Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

claude Bot Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot commented Mar 16, 2026

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Flowchart

Uh oh!

claude Bot commented Mar 16, 2026

Review

Logic correctness ✅

Tests ✅

Minor notes (see inline comments)

Uh oh!

Uh oh!

claude Bot commented Mar 16, 2026

Uh oh!

claude Bot Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

claude Bot Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

justin808 commented Mar 16, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Mar 16, 2026 •

edited

Loading