Skip to content

Fix Bootstrap Sass Append to Gemfile#262

Merged
justin808 merged 1 commit intoshakacode:masterfrom
aaronvb:fix_generator_append_to_gemfile
Feb 9, 2016
Merged

Fix Bootstrap Sass Append to Gemfile#262
justin808 merged 1 commit intoshakacode:masterfrom
aaronvb:fix_generator_append_to_gemfile

Conversation

@aaronvb
Copy link
Copy Markdown
Member

@aaronvb aaronvb commented Feb 8, 2016

Fixes #256

If the gemfile does not have an empty line at the end, append_to_file will append ‘gem bootstrap-sass’ to the last line.

  • Added a line break to the beginning of ‘gem bootstrap-sass’ to ensure it’s on a new line.

Review on Reviewable

If the gemfile does not have an empty line at the end, append_to_file will append ‘gem bootstrap-sass’ to the last line.

- Added a line break to the beginning of ‘gem bootstrap-sass’ to ensure it’s on a new line.

def add_bootstrap_sprockets_to_gemfile
append_to_file("Gemfile", "gem 'bootstrap-sass'\n")
append_to_file("Gemfile", "\ngem 'bootstrap-sass'\n")
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

justin808 added a commit that referenced this pull request Feb 9, 2016
@justin808 justin808 merged commit 3724f3f into shakacode:master Feb 9, 2016
@justin808
Copy link
Copy Markdown
Member

Thanks @aaronvb!

AbanoubGhadban pushed a commit that referenced this pull request Sep 25, 2025
Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4.
- [Release notes](https://github.com/caolan/async/releases)
- [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md)
- [Commits](caolan/async@v2.6.3...v2.6.4)

---
updated-dependencies:
- dependency-name: async
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
AbanoubGhadban pushed a commit that referenced this pull request Sep 26, 2025
Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4.
- [Release notes](https://github.com/caolan/async/releases)
- [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md)
- [Commits](caolan/async@v2.6.3...v2.6.4)

---
updated-dependencies:
- dependency-name: async
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants