Raise docs version floor to 16.4.0 in install/demo guidance#2610
Raise docs version floor to 16.4.0 in install/demo guidance#2610
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThis PR updates documentation across multiple React on Rails guides to reflect version 16.4.0 as the new minimum required version, replacing previous references to 16.0, 16.2, and pre-release versions. Version specifications in dependency manifests (Gemfile, package.json) are also updated to align with this release. Changes
Poem
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e2e23e1c56
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Greptile SummaryDocs-only PR that raises the minimum recommended version floor from various older versions (16.0, 16.2, 16.3, and legacy alpha/RC versions) to 16.4.0 across 13 documentation files covering install guides, quick starts, streaming SSR prerequisites, upgrade instructions, and troubleshooting.
Confidence Score: 4/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[PR: Raise docs version floor to 16.4.0] --> B[OSS Getting Started]
A --> C[OSS Building Features]
A --> D[OSS Deployment / Upgrading]
A --> E[Pro Docs]
B --> B1["quick-start.md\n16.0+ → 16.4.0+"]
B --> B2["pro-quick-start.md\n⚠️ placeholders instead of versions"]
C --> C1["streaming-server-rendering.md\nv16.0.0 / v4.0.0.rc.5 → v16.4.0"]
C --> C2["i18n.md\n16.2+ → 16.4.0+"]
C --> C3["extensible-precompile-pattern.md\n16.2+ → 16.4.0+"]
C --> C4["testing-configuration.md\n>= 16.0 → >= 16.4.0"]
D --> D1["troubleshooting-build-errors.md\n⚠️ fix version inconsistency"]
D --> D2["upgrading-react-on-rails.md\n~> 16.0 → ~> 16.4"]
E --> E1["installation.md\n16.0.0 → 16.4.0"]
E --> E2["streaming-server-rendering.md\nv15.0.0-alpha / v4.0.0 → v16.4.0"]
E --> E3["create-without-ssr.md\nalpha versions → 16.4.0"]
E --> E4["updating.md\n16.2 → 16.4"]
E --> E5["generator-details.md\n16.3.0 → 16.4.0"]
style B2 fill:#fff3cd,stroke:#ffc107
style D1 fill:#fff3cd,stroke:#ffc107
|
|
Review: Raise docs version floor to 16.4.0 -- Thanks for cleaning up these stale version references. Four issues noted (inline comments posted for the first three): (1) troubleshooting-build-errors.md has a factual contradiction: the section title and body both say the duplicate-build fix landed in 16.2.0, but the solution block now says 16.4.0+. (2) pro-quick-start.md lines 30-31 introduced non-functional placeholder strings as gem version constraints -- bundle install will fail if pasted verbatim. (3) extensible-precompile-pattern.md says the API has been available since i18n support was added, but then requires 16.4.0+ -- the previous 16.2+ was likely correct. (4) Minor: updating.md now says 'Upgrading to 16.4.0+' but the audience bullet still says '16.2.0-beta.x or earlier', leaving a gap for stable 16.2.0-16.3.x users. |
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/pro/updating.md (1)
119-132:⚠️ Potential issue | 🟡 MinorAdd
pnpmto the reinstall commands for end-user docs parity.This block now updates dependency versions, but the follow-up install command lists only npm/yarn. Please include pnpm here too for package-manager-agnostic docs consistency.
Proposed doc fix
Then reinstall: ```bash npm install # or yarn install +# or +pnpm install</details> Based on learnings: "In all end-user documentation under docs/, ensure package-manager-agnostic installation instructions include npm, yarn, and pnpm. Reserve the pnpm-only policy for internal development files (package.json, scripts, CI configs, developer guides like CLAUDE.md/WARP.md)." <details> <summary>🤖 Prompt for AI Agents</summary>Verify each finding against the current code and only fix it if needed.
In
@docs/pro/updating.mdaround lines 119 - 132, Update the reinstall command
block that currently lists only "npm install" and "yarn install" to include
"pnpm install" as a third option so the docs are package-manager-agnostic;
modify the code block containing the three install commands (the one after the
dependency JSON snippet) to add a line "# or" followed by "pnpm install"
mirroring the existing pattern.</details> </blockquote></details> </blockquote></details>🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed. Inline comments: In `@docs/oss/getting-started/pro-quick-start.md`: - Around line 30-31: The Gemfile snippet uses unresolved placeholders for versions in the gem lines ("react_on_rails" and "react_on_rails_pro"); replace those placeholders with an explicit, runnable version string and ensure both gem entries use the identical concrete version (e.g., set both to the same X.Y.Z release) so the example can be copy/pasted without failing; update the two lines that begin with gem "react_on_rails" and gem "react_on_rails_pro" accordingly. In `@docs/pro/react-server-components/create-without-ssr.md`: - Around line 13-16: The install snippet only shows Yarn and Bundler; add npm and pnpm equivalents so the commands are package-manager-agnostic: include npm install --save [email protected] [email protected] and pnpm add [email protected] [email protected] alongside the existing yarn add line, and keep the existing bundle add [email protected] [email protected] line for Ruby users; update the fenced code block in create-without-ssr.md to include all four command variants referencing the same package names ([email protected], [email protected], [email protected], [email protected]). - Around line 14-15: Update the pinned package versions to the published RC releases: replace the npm/yarn installs for react-on-rails and react-on-rails-pro to use 16.4.0-rc.9 and replace the Ruby bundle adds for react_on_rails and react_on_rails_pro to use 16.4.0.rc.9 (i.e., change the version strings in the two lines referencing react-on-rails/react-on-rails-pro and react_on_rails/react_on_rails_pro). --- Outside diff comments: In `@docs/pro/updating.md`: - Around line 119-132: Update the reinstall command block that currently lists only "npm install" and "yarn install" to include "pnpm install" as a third option so the docs are package-manager-agnostic; modify the code block containing the three install commands (the one after the dependency JSON snippet) to add a line "# or" followed by "pnpm install" mirroring the existing pattern.🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID:
b4b2096d-7be5-4c05-aff6-bc616732eef5📒 Files selected for processing (13)
docs/oss/api-reference/generator-details.mddocs/oss/building-features/extensible-precompile-pattern.mddocs/oss/building-features/i18n.mddocs/oss/building-features/streaming-server-rendering.mddocs/oss/building-features/testing-configuration.mddocs/oss/deployment/troubleshooting-build-errors.mddocs/oss/getting-started/pro-quick-start.mddocs/oss/getting-started/quick-start.mddocs/oss/upgrading/upgrading-react-on-rails.mddocs/pro/installation.mddocs/pro/react-server-components/create-without-ssr.mddocs/pro/streaming-server-rendering.mddocs/pro/updating.md
|
Addressed review comments in commit d185d4e. I switched updated Gemfile and package snippets to exact 16.4.0 pins (no range operators) in generator-details, testing-configuration, pro-quick-start, upgrading-react-on-rails, pro/updating, and troubleshooting-build-errors. Please re-review when convenient. |
Review: Raise docs version floor to 16.4.0Good direction overall. A few issues worth addressing before merging. 1. Pervasive exact-version pinning (most impactful) The most widespread problem is replacing flexible version constraints with exact pins throughout installation/setup guidance. Users copying these snippets literally will be locked to exactly 16.4.0 and will not pick up patch-level fixes. The correct pattern is Files affected: testing-configuration.md, troubleshooting-build-errors.md, upgrading-react-on-rails.md, generator-details.md, pro-quick-start.md, pro/updating.md. 2. Timing: 16.4.0 is not yet released Both version.rb files currently show 3. Potentially inaccurate min-version bumps
4. Confusing placeholder versions in pro-quick-start.md The older-versions Gemfile example now contains 5. Pro version scheme change needs explanation (streaming-server-rendering.md) The old prerequisite was |
Review: Raise docs version floor to 16.4.0Overall this is a clean, well-scoped docs-only PR. The version bumps are consistent across the guides and the removal of the stale alpha warning in the RSC doc is a good cleanup. A few issues worth addressing: 1. Ambiguous multi-package-manager code block In 2. Inline note in streaming prerequisites should be a callout block Both streaming SSR prerequisite lists now contain a bare 3. Gap in the audience definition in The guide still says 'On version 16.2.0-beta.x or earlier' while the upgrade target is now 16.4.0. Users on 16.2.0 stable or 16.3.x who are not on the old GitHub Packages system may incorrectly skip this guide, even though Step 3 (adding |
| ``` | ||
|
|
||
| **Note:** This workaround is not recommended for production. Upgrade to 16.2.0+ for the proper fix. | ||
| **Note:** This workaround is not recommended for production. Upgrade to 16.4.0+ for the proper fix. |
There was a problem hiding this comment.
This note is now inconsistent with the workaround code directly above it. The guard in the snippet checks ReactOnRails::VERSION < '16.2.0', meaning the proper fix was introduced in 16.2.0, not 16.4.0. Telling users "Upgrade to 16.4.0+" overstates the minimum requirement for the fix.
| **Note:** This workaround is not recommended for production. Upgrade to 16.4.0+ for the proper fix. | |
| **Note:** This workaround is not recommended for production. Upgrade to 16.2.0+ for the proper fix. |
| - Previously using GitHub Packages authentication (private distribution) | ||
| - On version 16.2.0-beta.x or earlier | ||
| - Upgrading to version 16.2.0 or higher | ||
| - On any version before 16.4.0 | ||
| - Upgrading to version 16.4.0 or higher |
There was a problem hiding this comment.
This scope change is too broad and may send users on 16.2.x–16.3.x down the wrong path. The guide is specifically about migrating away from GitHub Packages authentication (private → public distribution), which happened with 16.2.0. Users already on 16.2.x or 16.3.x have already completed that migration and should not be told this guide applies to them.
The original framing (16.2.0-beta.x or earlier) correctly scoped the audience to those who never did the PAT/.npmrc migration. Consider keeping the original or being more precise:
| - Previously using GitHub Packages authentication (private distribution) | |
| - On version 16.2.0-beta.x or earlier | |
| - Upgrading to version 16.2.0 or higher | |
| - On any version before 16.4.0 | |
| - Upgrading to version 16.4.0 or higher | |
| - Previously using GitHub Packages authentication (private distribution) | |
| - On version 16.1.x or earlier (pre-public distribution) | |
| - Upgrading to version 16.2.0 or higher (public distribution) |
| **Prerequisites:** | ||
|
|
||
| - Add `gem 'react_on_rails_pro', '>= 16.3.0'` to your Gemfile and run `bundle install` | ||
| - Add `gem 'react_on_rails_pro', '16.4.0'` (or later — pin to the exact version you want) to your Gemfile and run `bundle install` |
There was a problem hiding this comment.
The phrasing "pin to the exact version you want" after showing '16.4.0' is a bit confusing — it reads as "use this exact version" while the parenthetical says "or later". Using a minimum-version constraint is more conventional for Gemfile prerequisites and won't go stale as new patch releases come out:
| - Add `gem 'react_on_rails_pro', '16.4.0'` (or later — pin to the exact version you want) to your Gemfile and run `bundle install` | |
| - Add `gem 'react_on_rails_pro', '>= 16.4.0'` to your Gemfile and run `bundle install` |
Review: Raise docs version floor to 16.4.0Documentation-only PR — clean in scope. A few issues worth fixing before merge: Issues1. Contradictory versions in 2. Exact version pins in Gemfile examples are too restrictive Affected:
3. Feature minimum-version claims may now be inaccurate Minor
|
| **Prerequisites:** | ||
|
|
||
| - Add `gem 'react_on_rails_pro', '>= 16.3.0'` to your Gemfile and run `bundle install` | ||
| - Add `gem 'react_on_rails_pro', '16.4.0'` (or later — pin to the exact version you want) to your Gemfile and run `bundle install` |
There was a problem hiding this comment.
The phrasing here is self-contradictory. In Bundler, '16.4.0' is an exact version constraint — it will only match exactly 16.4.0 and will reject any higher patch/minor version. Saying "or later" alongside an exact pin is misleading.
Either use a range constraint if you want "or later" semantics:
| - Add `gem 'react_on_rails_pro', '16.4.0'` (or later — pin to the exact version you want) to your Gemfile and run `bundle install` | |
| - Add `gem 'react_on_rails_pro', '>= 16.4.0'` to your Gemfile and run `bundle install` |
or drop the "or later" clause and just say "pin to your target version":
| - Add `gem 'react_on_rails_pro', '16.4.0'` (or later — pin to the exact version you want) to your Gemfile and run `bundle install` | |
| - Add `gem 'react_on_rails_pro', '16.4.0'` (update the version pin as new releases arrive) to your Gemfile and run `bundle install` |
| ## Compatibility | ||
|
|
||
| This pattern requires **React on Rails 16.2+** and works with any version of Shakapacker. The `ReactOnRails::Locales.compile` API has been available since React on Rails introduced i18n support and is the same method used internally by the `react_on_rails:locale` rake task. | ||
| This pattern requires **React on Rails 16.4.0+** and works with any version of Shakapacker. The `ReactOnRails::Locales.compile` API has been available since React on Rails introduced i18n support and is the same method used internally by the `react_on_rails:locale` rake task. |
There was a problem hiding this comment.
Raising the minimum from 16.2+ to 16.4.0+ may be factually incorrect if this feature was genuinely introduced in 16.2. Anyone on 16.2.x or 16.3.x reading this will incorrectly conclude the pattern is unavailable to them.
If the intent is to recommend 16.4.0 for new installs while keeping the accurate minimum, consider:
| This pattern requires **React on Rails 16.4.0+** and works with any version of Shakapacker. The `ReactOnRails::Locales.compile` API has been available since React on Rails introduced i18n support and is the same method used internally by the `react_on_rails:locale` rake task. | |
| This pattern requires **React on Rails 16.2.0+** (16.4.0+ recommended) and works with any version of Shakapacker. The `ReactOnRails::Locales.compile` API has been available since React on Rails introduced i18n support and is the same method used internally by the `react_on_rails:locale` rake task. |
If 16.4.0 genuinely introduced a breaking change or required API, please add a brief note about what changed.
| ``` | ||
|
|
||
| **Note:** This workaround is not recommended for production. Upgrade to 16.2.0+ for the proper fix. | ||
| **Note:** This workaround is not recommended for production. Upgrade to 16.4.0+ for the proper fix. |
There was a problem hiding this comment.
This note now says "Upgrade to 16.4.0+" but the Solution section heading directly above (line 225, unchanged) still says "Upgrade to React on Rails 16.2.0 or later" with a ~> 16.2 Gemfile snippet. The two are contradictory in the same section.
Suggest one of:
- Update the Solution heading/gem example to 16.4.0 and add a parenthetical noting the bug was fixed in 16.2.0:
The issue is fixed in version 16.2.0 (PR #2052). We recommend upgrading to 16.4.0+ as the current minimum.
- Revert this line back to
16.2.0+since that is factually the version containing the fix — the troubleshooting context is about a specific bug, not general install guidance.
| The locale generation is idempotent - it will skip generation if files are already up-to-date. This makes it safe to call multiple times without duplicate work. | ||
|
|
||
| **Recommended: Use Shakapacker's precompile_hook with bin/dev** (React on Rails 16.2+, Shakapacker 9.3+) | ||
| **Recommended: Use Shakapacker's precompile_hook with bin/dev** (React on Rails 16.4.0+, Shakapacker 9.3+) |
There was a problem hiding this comment.
Same concern as extensible-precompile-pattern.md: if Shakapacker's precompile_hook support was added in React on Rails 16.2, bumping the stated minimum to 16.4.0+ overstates the requirement and silently excludes 16.2/16.3 users who have a working feature. Please verify the actual version this was introduced and document accordingly — or use the "X.Y+ (16.4.0+ recommended)" pattern if the goal is purely install guidance.
| ```ruby | ||
| # Gemfile | ||
| gem "react_on_rails", ">= 16.0" # Not in a specific group | ||
| gem "react_on_rails", "16.4.0" # Not in a specific group |
There was a problem hiding this comment.
Exact version pin "16.4.0" will lock users to exactly that release — they won't get patch fixes automatically with bundle update. Use the pessimistic constraint instead, consistent with how pro-quick-start.md handles it:
| gem "react_on_rails", "16.4.0" # Not in a specific group | |
| gem "react_on_rails", "~> 16.4" # Not in a specific group |
| ```ruby | ||
| # Gemfile | ||
| gem "react_on_rails", ">= 16.0" # Not in a specific group | ||
| gem "react_on_rails", "16.4.0" # Not in a specific group |
There was a problem hiding this comment.
Using an exact pin ("16.4.0") in this example is likely to be copy-pasted verbatim by users troubleshooting test setup. An exact pin in a Gemfile locks the project to that precise version and blocks security/patch updates without a manual bump.
For a "this gem must be in the test environment" snippet the conventional form is a lower-bound constraint:
| gem "react_on_rails", "16.4.0" # Not in a specific group | |
| gem "react_on_rails", ">= 16.4.0" # Not in a specific group |
If the project's upgrade-preflight guidance ("avoid ^, ~, or *") applies here too, a comment to that effect would help readers understand why the pin looks different from their own Gemfile.
|
test comment - please ignore |
| - gem "react_on_rails_pro", "16.1.1" | ||
| - end | ||
| + gem "react_on_rails_pro", "~> 16.2" | ||
| + gem "react_on_rails_pro", "16.4.0" |
There was a problem hiding this comment.
Same exact-pin concern: "16.4.0" locks users to one patch level. The previous value "~> 16.2" used the pessimistic constraint correctly. Consider:
| + gem "react_on_rails_pro", "16.4.0" | |
| + gem "react_on_rails_pro", "~> 16.4" |
This matches the style in pro-quick-start.md and allows patch releases.
Documentation GuideReact on Rails is one product with two tiers: open source for Rails + React integration, and Pro when you need higher SSR throughput, deeper RSC support, or maintainer-backed help. Choose the path that matches your appStarting a new Rails + React appAdding React to an existing Rails appAlready using React on Rails OSS?Evaluating Rails + React optionsDive deeper when you need itPro features
Friendly evaluation policy
Need more help? |
|
Review summary posted as inline comments. See individual file threads for details. |
|
test2 |
Review: Raise docs version floor to 16.4.0Overall this is a reasonable docs-only cleanup, but I found a few issues worth addressing before merging. Bugs / Inconsistenciestroubleshooting-build-errors.md — The note now says “Upgrade to 16.4.0+ for the proper fix,” but the workaround code immediately above guards on docs/pro/updating.md — The guide is specifically about migrating away from GitHub Packages (private to public distribution), which shipped with 16.2.0. Changing the scope from “16.2.0-beta.x or earlier” to “any version before 16.4.0” means users already on 16.2.x-16.3.x (who completed the PAT migration long ago) will now think this guide applies to them. See inline comment. Style / Best Practicestesting-configuration.md — Example Gemfile uses an exact pin generator-details.md — Showing What Looks Good
|
## Summary - replace dead `https://pro.reactonrails.com` links with the live canonical Pro docs landing page at `https://reactonrails.com/docs/pro/` - update the one user-facing runtime warning in `ReactOnRails::Utils` to stop sending users to the failing subdomain - keep the scope limited to non-overlapping files outside the active docs PRs ## Scope notes - Supports shakacode/reactonrails.com#59 - Intentionally does not touch `react_on_rails/lib/generators/react_on_rails/pro_setup.rb`, which is already tracked by #2575 - Intentionally does not touch the stale `/pro` page content / `docs/pro/react-on-rails-pro.md`, which is tracked by #2838 - Intentionally excludes files already being modified in active PRs: #2610, #2651, #2675, #2831, and #2850 ## Validation Passed: - `bundle exec rubocop react_on_rails/lib/react_on_rails/utils.rb` - `git diff --check` - `git diff --name-only origin/main...HEAD | rg '\.md$' | xargs pnpm dlx [email protected] --check` - custom local relative-link scan across the changed markdown files - `curl -I -L` checks showing: - `https://reactonrails.com/docs/pro/` -> `200` - `https://pro.reactonrails.com` -> `500` <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: changes are documentation link updates plus a single user-facing warning string, with no behavioral impact beyond directing users to a new URL. > > **Overview** > Updates documentation to replace references to the dead `https://pro.reactonrails.com` site with the canonical Pro landing page at `https://reactonrails.com/docs/pro/` across the README and multiple OSS docs. > > Also updates the `ReactOnRails::Utils.immediate_hydration_pro_install_warning` message to point users at the new Pro docs URL when `immediate_hydration: true` is used without the Pro gem. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 457f7d5. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Updated React on Rails Pro documentation links across the README, API references, feature guides, configuration documentation, migration guides, release notes, and installation messages to consistently direct users to the new centralized Pro documentation hub for improved navigation and accessibility. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Summary This docs cleanup pass aligns repo docs and user-facing help output with the current published docs structure. Changes in this PR: - replace stale docs-route references in runtime/help output with the current docs paths - replace legacy Pro wiki links and stale external references in OSS docs - document current `ReactOnRails.render` return behavior for React 18+ vs React 16/17 - update internal contributor guidance to point at the canonical Pro docs home ## Scope notes - Closes #2839 - Partial #2838 - Intentionally excludes files already being modified in active docs PRs: #2610, #2651, #2675, and #2831 ## Validation Passed: - `bundle exec rubocop react_on_rails/lib/react_on_rails/configuration.rb react_on_rails/lib/react_on_rails/doctor.rb react_on_rails/lib/react_on_rails/packer_utils.rb react_on_rails/lib/react_on_rails/packs_generator.rb react_on_rails/lib/react_on_rails/server_rendering_js_code.rb react_on_rails/lib/tasks/generate_packs.rake react_on_rails/spec/dummy/spec/packs_generator_spec.rb` - `git diff --name-only origin/main...HEAD | rg '\.md$' | xargs pnpm dlx [email protected] --check` - `git diff --check` - custom local relative-link scan across the changed markdown files - `curl -I -L` checks for `https://invite.reactrails.com`, `https://jsdoc.app/`, and `https://reactonrails.com/docs/pro/` Not run: - `bundle exec rspec react_on_rails/spec/dummy/spec/packs_generator_spec.rb` - blocked in this clean worktree because the dummy-app spec loads `rails_helper` from the dummy app environment and that bundle/setup is not present here <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: changes are limited to documentation text and user-facing help/error message URLs, with no behavioral code changes. > > **Overview** > Updates docs and in-tool messaging to match the reorganized `reactonrails.com` documentation structure, replacing legacy wiki/old guide URLs across OSS guides, Pro references, and generator docs. > > Clarifies the `ReactOnRails.render` API docs to reflect React 18+ root return behavior vs React 16/17, and adds guidance warning that repeated calls on the same DOM node are not deduplicated. > > Refreshes community/support links (Slack invite, JSDoc) and updates several runtime error/help messages and corresponding specs to point at the new canonical doc routes. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 296ecc1. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Updated many guide links to the reorganized documentation site (including Pro docs and upgrade/migration paths). * Clarified API docs for render behavior across React versions and added guidance about repeated renders. * Replaced community Slack invite/link and updated external JSDoc reference. * Adjusted error/help message and test links to point to the correct docs. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
…olve-2833 * origin/main: docs: fix profiling node renderer command (#2863) generators: point Pro install fallback to upgrade guide (#2868) Add RSC Flight payload optimization guide (Article 7) (#2827) Migrate from deprecated Async::Variable to Async::Promise (#2832) docs: turn pro quick start into a gateway (#2862) Fix upload-assets endpoint duplicating bundles across directories (#2768) docs: fix stale docs links and help URLs (#2850) docs: replace dead pro.reactonrails.com links (#2851) docs: refresh generator and helper URLs (#2852) Add standalone RSC upgrade guide for existing Pro apps (#2831) Raise docs version floor to 16.4.0 in install/demo guidance (#2610) # Conflicts: # CHANGELOG.md
…olve-2849 * origin/main: docs: fix profiling node renderer command (#2863) generators: point Pro install fallback to upgrade guide (#2868) Add RSC Flight payload optimization guide (Article 7) (#2827) Migrate from deprecated Async::Variable to Async::Promise (#2832) docs: turn pro quick start into a gateway (#2862) Fix upload-assets endpoint duplicating bundles across directories (#2768) docs: fix stale docs links and help URLs (#2850) docs: replace dead pro.reactonrails.com links (#2851) docs: refresh generator and helper URLs (#2852) Add standalone RSC upgrade guide for existing Pro apps (#2831) Raise docs version floor to 16.4.0 in install/demo guidance (#2610) # Conflicts: # CHANGELOG.md
…olve-2835 * origin/main: (21 commits) docs: fix profiling node renderer command (#2863) generators: point Pro install fallback to upgrade guide (#2868) Add RSC Flight payload optimization guide (Article 7) (#2827) Migrate from deprecated Async::Variable to Async::Promise (#2832) docs: turn pro quick start into a gateway (#2862) Fix upload-assets endpoint duplicating bundles across directories (#2768) docs: fix stale docs links and help URLs (#2850) docs: replace dead pro.reactonrails.com links (#2851) docs: refresh generator and helper URLs (#2852) Add standalone RSC upgrade guide for existing Pro apps (#2831) Raise docs version floor to 16.4.0 in install/demo guidance (#2610) Fix release script: require changelog, fix RC version computation (#2848) Bump version to 16.5.0 Bump version to 16.5.0.rc.0 Update CHANGELOG.md for 16.5.0.rc.0 (#2847) Docs: add memory leak prevention guide for Node Renderer SSR (#2845) Docs: fix RSC migration gaps found during real-world migration (#2842) Add common mistakes sections to RSC migration guides (#2826) fix: preserve runtime env vars across Bundler.with_unbundled_env (#2836) Skip Pro CI workflows for Dependabot PRs (#2825) ... # Conflicts: # CHANGELOG.md
## Summary - Stamped `### [16.5.1] - 2026-03-27` with two Pro fixes (PRs #2872, #2768) - Removed the `### [16.5.0.rc.0]` section (was already released as 16.5.0 stable) - Consolidated the 16.5.0 section with full entries (previously just said "no changes from rc.0") - Updated diff links at bottom of file ## Skipped PRs (docs/internal only) #2856, #2860, #2857, #2859, #2864, #2870, #2863, #2868, #2827, #2862, #2850, #2851, #2852, #2831, #2610, #2848 ## Test plan - [ ] Verify CHANGELOG.md formatting and diff links are correct - [ ] Run `rake release` (no args) after merge to publish 16.5.1 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: changes are limited to `CHANGELOG.md` release notes and version/compare links with no runtime code modifications. > > **Overview** > Documents the `16.5.1` release by adding a new section under *Unreleased* with two **[Pro]** fixes (missing packaged rake tasks and avoiding duplicated bundles during remote renderer asset uploads). > > Cleans up the `16.5.0` entry by removing the `16.5.0.rc.0` section and updating the compare-link footer so `unreleased` now starts from `v16.5.1` and `16.5.0` compares from `v16.4.0`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 9a6b224. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Updated changelog to document version 16.5.1 release with consolidated version history and updated comparison links. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: Claude Opus 4.6 (1M context) <[email protected]>
## Summary - Stamped `### [16.5.1] - 2026-03-27` with two Pro fixes (PRs #2872, #2768) - Removed the `### [16.5.0.rc.0]` section (was already released as 16.5.0 stable) - Consolidated the 16.5.0 section with full entries (previously just said "no changes from rc.0") - Updated diff links at bottom of file ## Skipped PRs (docs/internal only) #2856, #2860, #2857, #2859, #2864, #2870, #2863, #2868, #2827, #2862, #2850, #2851, #2852, #2831, #2610, #2848 ## Test plan - [ ] Verify CHANGELOG.md formatting and diff links are correct - [ ] Run `rake release` (no args) after merge to publish 16.5.1 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: changes are limited to `CHANGELOG.md` release notes and version/compare links with no runtime code modifications. > > **Overview** > Documents the `16.5.1` release by adding a new section under *Unreleased* with two **[Pro]** fixes (missing packaged rake tasks and avoiding duplicated bundles during remote renderer asset uploads). > > Cleans up the `16.5.0` entry by removing the `16.5.0.rc.0` section and updating the compare-link footer so `unreleased` now starts from `v16.5.1` and `16.5.0` compares from `v16.4.0`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 9a6b224. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Updated changelog to document version 16.5.1 release with consolidated version history and updated comparison links. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: Claude Opus 4.6 (1M context) <[email protected]>
Summary
Scope
This change focuses on actionable setup instructions and demo commands, not historical release-note content.
Verification
Note
Low Risk
Low risk documentation-only changes; main risk is users on older versions being incorrectly told to pin/upgrade to 16.4.0.
Overview
Updates docs to treat React on Rails 16.4.0+ as the minimum supported version in actionable setup guidance, replacing older
>=16.x/16.2+references across Quick Start, i18n/precompile patterns, testing setup, generator Pro prerequisites, and build troubleshooting notes.Refreshes React on Rails Pro installation/upgrade examples to use explicit
16.4.0pins (gem and npm) and modernizes the Server Components “create without SSR” commands to install[email protected]plus strict gem version adds.Written by Cursor Bugbot for commit 92f7ff3. This will update automatically on new commits. Configure here.
Summary by CodeRabbit
Documentation