Exclude broken external URLs from markdown link checker by justin808 · Pull Request #2495 · shakacode/react_on_rails

justin808 · 2026-02-27T03:34:12Z

Summary

Exclude 4 external URLs that have been causing the markdown link checker CI job to fail on every single run
solargraph.org — SSL HandshakeFailure
coveralls.io — Returns 503 for automated requests
shakacode.controlplane.com — Connection refused from CI
storybook.js.org — Intermittent connection resets from CI

These follow the existing pattern in .lychee.toml for excluding unreliable external sites that are not under our control.

Test plan

Verify the markdown link checker CI job passes after merge
Confirm no legitimate link breakage is being masked (all 4 URLs are third-party sites with known CI-unfriendly behavior)

🤖 Generated with Claude Code

Note

Low Risk
Low risk config-only change; the main downside is potentially masking future breakage for the newly excluded third-party domains.

Overview
Updates .lychee.toml to expand the Lychee exclude list with several CI-unreliable third-party domains (SSL handshake failure, 503s, connection refused, intermittent resets) so the markdown link checker workflow stops failing on those external URLs.

Also tweaks/clarifies comment grouping (e.g., badge/CI services and 5xx from CI) to reflect the broader set of excluded sites.

^{Written by Cursor Bugbot for commit 526ac0c. Configure here.}

Summary by CodeRabbit

Chores
- Updated link validation configuration to exclude additional services from checks, including coveralls.io, shakacode.controlplane.com, and storybook.js.org.
- Reorganized service categorization headers for improved clarity in configuration.

The lychee link checker CI job has been failing on every run due to 4 external URLs that are consistently unreachable from CI: - solargraph.org: SSL HandshakeFailure - coveralls.io: Returns 503 for automated requests - shakacode.controlplane.com: Connection refused from CI - storybook.js.org: Intermittent connection resets from CI Add these to the .lychee.toml exclude list, following the existing pattern for unreliable external sites. Co-Authored-By: Claude Opus 4.6 <[email protected]>

coderabbitai · 2026-02-27T03:34:33Z

Walkthrough

Configuration updates to .lychee.toml that enhance link-checking exclusion rules. Adds new SSL and CI-related site exclusions, renames section headers to better reflect their scope, and adjusts coverage-related failure codes.

Changes

Cohort / File(s)	Summary
Configuration Updates `.lychee.toml`	Adds SSL HandshakeFailure exclusion for solargraph.org, includes coveralls.io with 503 errors, and expands CI exclusions (shakacode.controlplane.com, storybook.js.org). Updates section headers from "BADGE SERVICES" to "BADGE AND CI SERVICES" and "504 FROM CI" to "5xx FROM CI".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Hoppy times with configs true,
Exclusions list gets quite a few,
SSL slips and CI threads,
Five-hundred errors in the spreads,
A rabbit's cheer—the links now flow! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding URL exclusions to the markdown link checker configuration to prevent CI failures.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch jg/fix-markdown-link-checker

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

greptile-apps · 2026-02-27T03:36:14Z

Greptile Summary

Adds four external URLs to Lychee's exclusion list to prevent false positives in CI:

solargraph.org (SSL HandshakeFailure)
coveralls.io (503 responses)
shakacode.controlplane.com (connection refused)
storybook.js.org (intermittent connection resets)

Also updates section comments for clarity ("BADGE AND CI SERVICES" and "SITES THAT RETURN 5xx FROM CI"). All exclusions follow existing patterns for unreliable external sites. The regex patterns are correctly formatted with escaped dots.

Confidence Score: 5/5

This PR is safe to merge with minimal risk
Config-only change adding URL exclusions for external sites with documented CI failures. Regex patterns are correct, categorization is appropriate, and this follows established patterns in the file. No functional logic changes.
No files require special attention

Important Files Changed

Filename	Overview
.lychee.toml	Adds four CI-unreliable third-party URLs to exclusion list with appropriate categorization and updated section comments

_{Last reviewed commit: 526ac0c}

coderabbitai

🧹 Nitpick comments (1)

.lychee.toml (1)

55-62: Optional hardening: www variants are not currently used in documentation.

The verification shows no www-prefixed variants of coveralls.io or storybook.js.org appear in any markdown files. The documentation exclusively uses non-www URLs. While adding optional www matching would be defensive hardening to future-proof against doc changes, it is not necessary to prevent current failures.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.lychee.toml around lines 55 - 62, Update the host-blocking regexes to
optionally match "www" variants so future docs using www are also covered:
modify the existing patterns '^https://coveralls\.io' and
'^https://storybook\.js\.org' (and any similar entries like
'^https://reactrails\.com' or '^https://shakacode\.controlplane\.com' if
desired) to allow an optional "www." prefix (e.g., using a non-capturing
optional group like (?:www\.)?), or add separate '^https://www\.…' entries next
to the current ones; ensure the changed strings in .lychee.toml replace or
supplement the exact regex literals shown in the diff.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.lychee.toml:
- Around line 55-62: Update the host-blocking regexes to optionally match "www"
variants so future docs using www are also covered: modify the existing patterns
'^https://coveralls\.io' and '^https://storybook\.js\.org' (and any similar
entries like '^https://reactrails\.com' or
'^https://shakacode\.controlplane\.com' if desired) to allow an optional "www."
prefix (e.g., using a non-capturing optional group like (?:www\.)?), or add
separate '^https://www\.…' entries next to the current ones; ensure the changed
strings in .lychee.toml replace or supplement the exact regex literals shown in
the diff.

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8d201b8 and 526ac0c.

📒 Files selected for processing (1)

.lychee.toml

claude · 2026-02-27T03:40:14Z

Review: Exclude Broken External URLs from Markdown Link Checker

Overall: LGTM — clean, low-risk config change following established patterns.

Verified

All 4 newly excluded domains are actually referenced in the codebase (README.md, docs/contributor-info/rbs-type-signatures.md, docs/migrating/angular-js-integration-migration.md), so no dead documentation is being silently hidden.
Regex patterns use anchors (^) and proper escaping — consistent with existing entries.
The daily scheduled job (cron: '0 3 * * *') means any future breakage of these links will still be detected if they ever start behaving (because cached results expire in 1d).

Minor Nit

The section heading was updated from "SITES THAT RETURN 504 FROM CI" to "SITES THAT RETURN 5xx FROM CI", but neither of the two new entries actually produce an HTTP 5xx response:

shakacode.controlplane.com → Connection refused (TCP-level failure, no HTTP response at all)
storybook.js.org → Connection reset (also TCP-level)

A more accurate heading would be something like "SITES UNRELIABLE FROM CI" or "SITES WITH CI CONNECTIVITY ISSUES". Not blocking, but worth noting for future maintainability.

No security, performance, or correctness concerns.

claude · 2026-02-27T03:40:19Z


  # ============================================================================
-  # SITES THAT RETURN 504 FROM CI
+  # SITES THAT RETURN 5xx FROM CI


Minor: shakacode.controlplane.com (connection refused) and storybook.js.org (connection reset) don't actually return HTTP 5xx responses — these are TCP-level failures. The section heading is slightly inaccurate for these two new entries.

Consider renaming the section to something like SITES WITH CI CONNECTIVITY ISSUES or SITES UNRELIABLE FROM CI to cover both HTTP 5xx errors and TCP-level failures under one umbrella.

## Summary - Exclude 4 external URLs that have been causing the markdown link checker CI job to fail on **every single run** - `solargraph.org` — SSL HandshakeFailure - `coveralls.io` — Returns 503 for automated requests - `shakacode.controlplane.com` — Connection refused from CI - `storybook.js.org` — Intermittent connection resets from CI These follow the existing pattern in `.lychee.toml` for excluding unreliable external sites that are not under our control. ## Test plan - [ ] Verify the markdown link checker CI job passes after merge - [ ] Confirm no legitimate link breakage is being masked (all 4 URLs are third-party sites with known CI-unfriendly behavior) 🤖 Generated with [Claude Code](https://claude.com/claude-code)  --- > [!NOTE] > **Low Risk** > Low risk config-only change; the main downside is potentially masking future breakage for the newly excluded third-party domains. > > **Overview** > Updates `.lychee.toml` to expand the Lychee exclude list with several CI-unreliable third-party domains (SSL handshake failure, 503s, connection refused, intermittent resets) so the markdown link checker workflow stops failing on those external URLs. > > Also tweaks/clarifies comment grouping (e.g., **badge/CI services** and **5xx from CI**) to reflect the broader set of excluded sites. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 526ac0c. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup>   ## Summary by CodeRabbit * **Chores** * Updated link validation configuration to exclude additional services from checks, including coveralls.io, shakacode.controlplane.com, and storybook.js.org. * Reorganized service categorization headers for improved clarity in configuration.  Co-authored-by: Claude Opus 4.6 <[email protected]>

coderabbitai Bot reviewed Feb 27, 2026

View reviewed changes

coderabbitai Bot approved these changes Feb 27, 2026

View reviewed changes

claude Bot reviewed Feb 27, 2026

View reviewed changes

justin808 merged commit 11034a5 into master Feb 27, 2026
40 checks passed

justin808 deleted the jg/fix-markdown-link-checker branch February 27, 2026 08:09

coderabbitai Bot mentioned this pull request Mar 7, 2026

Skip flaky external URLs in lychee checks #2547

Merged

justin808 mentioned this pull request Mar 18, 2026

Exclude broken external URLs from markdown link checker #2699

Closed

justin808 mentioned this pull request Apr 4, 2026

Exclude broken external URLs from markdown link checker #2953

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Exclude broken external URLs from markdown link checker#2495

Exclude broken external URLs from markdown link checker#2495
justin808 merged 1 commit intomasterfrom
jg/fix-markdown-link-checker

justin808 commented Feb 27, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Feb 27, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot commented Feb 27, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

claude Bot commented Feb 27, 2026

Uh oh!

claude Bot Feb 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

justin808 commented Feb 27, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

greptile-apps Bot commented Feb 27, 2026

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

claude Bot commented Feb 27, 2026

Review: Exclude Broken External URLs from Markdown Link Checker

Verified

Minor Nit

Uh oh!

claude Bot Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

justin808 commented Feb 27, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Feb 27, 2026 •

edited

Loading