Fix silent error absorption in RSC payload injection#2486
Merged
AbanoubGhadban merged 6 commits into2402-streaming-hang-on-errorfrom Feb 27, 2026
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
injectRSCPayload.tswhere three error handlers (htmlStream.on('error', () => {}),catch {}instartRSC, and.catch(() => endResultStream())) swallowed errors, preventing them from reachingerrorReporter/SentrysafePipeutility that replaces the scattered pipe+close boilerplate with a single function handling the Node.jspipe()gap (destination not ended on source destroy) and optionalonErrorcallback for non-fatal error reportingtransformRSCNodeStream.tsthat PR Fix streaming SSR hangs and silent error absorption in RSC payload injection #2407 did not coverHow it works
Errors emitted on
resultStreaminsideinjectRSCPayloadpropagate throughsafePipe'sonErrorat thepipeToTransformsite →emitError()→readableStream→handleStreamError→errorReporter. The pipe stays intact, data continues flowing, and Fastify never sees the errors.Test plan
injectRSCPayload.test.ts— 7 tests passstreamServerRenderedReactComponent.test.jsx— 16 tests passRSCRequestTracker.test.ts— 8 tests passstreamBackpressure.e2e.test.tsx— 4 tests passhandleStreamError.test.ts— 6 tests passstreamErrorHang.test.ts— 3 tests passCloses #2450
🤖 Generated with Claude Code