No actionable comments were generated in the recent review. 🎉

Walkthrough

The generator now installs @babel/preset-react for non‑SWC transpiler configurations via a new constant and helper methods; SWC installation flow remains intact and @babel/preset-react is skipped when SWC or rspack is used.

Changes

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐇 I sniffed the build and found a missing treat,
A little preset hidden where Babel and webpack meet,
I planted @babel/preset-react when SWC sleeps tight,
Now builds wake cheerful in the morning light,
Hoppity‑hop—no more missing-package fright.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Greptile Summary

This PR fixes a missing dependency issue where the generator creates a babel.config.js file that requires @babel/preset-react, but wasn't installing it for non-SWC setups.

Key Changes:

• Adds BABEL_REACT_DEPENDENCIES constant containing @babel/preset-react
• Creates new add_babel_react_dependencies method following the existing error handling pattern
• Updates add_js_dependencies to conditionally install either SWC dependencies OR Babel preset based on using_swc? check
• Extends test coverage to verify the preset is installed for Babel setups and skipped for SWC setups
• Adds add_npm_dependencies_calls tracking to test mock for better assertion capabilities

Why This Matters:
The generated babel.config.js template references @babel/preset-react on line 11, which would cause build failures if the package isn't installed. This fix ensures the dependency is present when needed.

Confidence Score: 5/5

• This PR is safe to merge with no identified risks
• The implementation follows established patterns in the codebase, includes comprehensive test coverage, and addresses a legitimate bug where generated files would reference missing dependencies. The conditional logic properly handles both SWC and Babel paths without breaking existing functionality.
• No files require special attention

Important Files Changed

Flowchart

flowchart TD
    A[Generator starts] --> B[add_js_dependencies called]
    B --> C{using_swc?}
    C -->|true| D[add_swc_dependencies]
    C -->|false| E[add_babel_react_dependencies]
    D --> F[Install @swc/core and swc-loader as devDependencies]
    E --> G[Install @babel/preset-react as devDependency]
    F --> H[Continue with other dependencies]
    G --> H
    H --> I[babel.config.js template requires @babel/preset-react]
    I --> J{SWC path?}
    J -->|Yes| K[No babel.config.js needed - SWC handles transpilation]
    J -->|No| L[babel.config.js uses @babel/preset-react preset]

_{Last reviewed commit: ff49925}

PR top-level review: see inline comments below for specific line-level feedback.

Summary of issues found:

1. RSPACK BUG: Rspack users will incorrectly get @babel/preset-react installed. The condition only checks using_swc? but not using_rspack?. Rspack has its own built-in SWC and does not use babel.config.js at all. The guard in add_js_dependencies should be changed from the current if/else to: add_swc_dependencies if using_swc? followed by add_babel_react_dependencies if !using_swc? && !using_rspack?

2. MISSING TEST: The rescue StandardError branch in add_babel_react_dependencies has no test coverage, unlike every other add_* method in the module which tests both the return-false and the exception paths.

3. UNTESTED: PR is self-described as untested locally due to a Ruby version mismatch. Since this changes installer behavior for all non-SWC non-rspack users, verifying specs pass before merge is important.

4. MINOR: A comment on BABEL_REACT_DEPENDENCIES explaining why only the preset is needed (Shakapacker already handles babel-loader and @babel/core for Babel setups) would help future maintainers.

Review Summary

The direction is correct — fixing #2281 by explicitly installing @babel/preset-react for Babel-based setups is the right approach. The test coverage for the new method is good. However there is one meaningful correctness issue to address before merging.

Bug: esbuild transpiler incorrectly triggers Babel preset installation

The condition in add_transpiler_dependencies relies on the assumption that 'not SWC and not rspack' means 'Babel'. But using_swc? returns false for any non-SWC transpiler, including esbuild and none. A user with javascript_transpiler: 'esbuild' in their shakapacker.yml will have @babel/preset-react unnecessarily installed into their project. Inline comment posted with details.

Other notes:

• @babel/core not listed in BABEL_REACT_DEPENDENCIES — works because Shakapacker's babel-loader brings it in transitively, but a brief comment explaining the omission would help future readers.
• Tests are unrun by the author (acknowledged in the PR) — the specs look structurally sound but should be validated in CI before merge. The PR notes it is blocked by a local Ruby version mismatch.
• Minor: the BABEL_REACT_DEPENDENCIES constant for a single package is slightly over-engineered but is consistent with the module's existing patterns.