Skip to content

Document React on Rails 16.3.0 release in CHANGELOG#2358

Merged
justin808 merged 2 commits intomasterfrom
jg/get-latest
Feb 6, 2026
Merged

Document React on Rails 16.3.0 release in CHANGELOG#2358
justin808 merged 2 commits intomasterfrom
jg/get-latest

Conversation

@justin808
Copy link
Copy Markdown
Member

@justin808 justin808 commented Feb 6, 2026

Summary

Added changelog entry for React on Rails 16.3.0 (released 2026-02-05) documenting all user-visible changes:

Changed:

Fixed:

Updated version comparison links at the bottom of the file.

Pull Request checklist

  • Update CHANGELOG file

Summary by CodeRabbit

  • Changed

    • Simplified handling of Shakapacker version (16.3.0)
  • Bug Fixes

    • Fixed environment/application behavior not being applied consistently
    • Fixed precompile hook when assets are pre-installed
    • Fixed route handling in the development command

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 6, 2026

Walkthrough

Adds a new 16.3.0 entry to CHANGELOG.md under Unreleased with "Changed" and "Fixed" subsections, lists three fixes, and updates the Unreleased footer/version comparison links to reference 16.3.0.

Changes

Cohort / File(s) Summary
Changelog Updates
CHANGELOG.md
Insert [16.3.0] release block under Unreleased with one "Changed" item (Shakapacker version/Pro handling) and three "Fixed" items (Rspack env/apply behavior, Shakapacker precompile hook config, bin/dev route arg handling). Update footer/unreleased compare links to include 16.3.0.

Sequence Diagram(s)

(omitted)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • AbanoubGhadban

Poem

🐰 I hopped through lines of changelog cheer,

Sixteen-dot-three now quietly appears,
Rspack, hooks, and dev routes set right,
I nibble a carrot and wink at night,
Version tidy, my ears twitch with delight. 🥕

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely describes the main change: documenting the React on Rails 16.3.0 release in the CHANGELOG file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jg/get-latest

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Feb 6, 2026

Greptile Overview

Greptile Summary

This PR updates CHANGELOG.md by adding a new 16.3.0 release section (Changed + Fixed entries with PR links/authors) and updating the comparison links at the bottom to point Unreleased at 16.3.0...master and add a 16.3.0 compare link.

Main issue: the Unreleased section no longer contains any placeholder/body text; it’s effectively empty because the next header is the 16.3.0 release. The changelog’s own guidance and typical Keep a Changelog structure expect Unreleased to remain a real section for upcoming changes, with releases listed below it.

Confidence Score: 4/5

  • Safe to merge after fixing minor changelog structure issue.
  • Changes are documentation-only and low risk, but the Unreleased section is left empty (header immediately followed by the 16.3.0 header), which breaks expected changelog structure and should be corrected before merging.
  • CHANGELOG.md

Important Files Changed

Filename Overview
CHANGELOG.md Adds a 16.3.0 release section and updates bottom comparison links; currently leaves the Unreleased section empty (header immediately followed by the new release), which breaks expected changelog structure.

Sequence Diagram

sequenceDiagram
  participant Author as PR Author
  participant Changelog as CHANGELOG.md
  participant Reader as Release Notes Reader

  Author->>Changelog: "Add 16.3.0 section"
  Author->>Changelog: "Update compare links"

  Reader->>Changelog: "Read Unreleased"
  Changelog-->>Reader: "Unreleased header only"

  Reader->>Changelog: "Read 16.3.0"
  Changelog-->>Reader: "Shows Changed and Fixed"

  Reader->>Changelog: "Follow compare links"
  Changelog-->>Reader: "Compares to master and prior version"
Loading

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Comment thread CHANGELOG.md
Comment on lines 22 to 25
### [Unreleased]

Changes since the last non-beta release.
### [16.3.0] - 2026-02-05

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreleased section removed

### [Unreleased] is now immediately followed by ### [16.3.0] - 2026-02-05, and the prior placeholder text (“Changes since the last non-beta release.”) was removed. This breaks the documented convention at the top of the changelog (and the typical Keep a Changelog structure) where Unreleased is a real section containing upcoming entries; please restore the Unreleased placeholder/content and keep release entries below it.

Prompt To Fix With AI
This is a comment left during a code review.
Path: CHANGELOG.md
Line: 22:25

Comment:
**Unreleased section removed**

`### [Unreleased]` is now immediately followed by `### [16.3.0] - 2026-02-05`, and the prior placeholder text (“Changes since the last non-beta release.”) was removed. This breaks the documented convention at the top of the changelog (and the typical Keep a Changelog structure) where *Unreleased* is a real section containing upcoming entries; please restore the Unreleased placeholder/content and keep release entries below it.

How can I resolve this? If you propose a fix, please make it concise.

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Feb 6, 2026

Code Review: CHANGELOG for React on Rails 16.3.0

✅ Strengths

  1. Accurate Version Information: The version number (16.3.0) matches the VERSION constant in react_on_rails/lib/react_on_rails/version.rb.

  2. Proper PR References: All referenced PRs (Fix Unify minimum Shakapacker versions #2225 #2247, Fix rspack configuration not applying to all environments #2275, fix: configure precompile_hook when Shakapacker is pre-installed #2280, Fix bin/dev failing with 'Unknown argument' when using --route flag #2273) are verified as merged and properly linked with correct formatting.

  3. Clear User-Facing Changes: The changelog correctly focuses on user-visible changes:

    • 1 Changed entry (Shakapacker version handling)
    • 3 Fixed entries (rspack config, precompile hook, bin/dev route flag)
  4. Correct Link Format: Version comparison links are properly updated:

    • [unreleased] now points to 16.3.0...master
    • [16.3.0] correctly compares 16.2.1...16.3.0
  5. Consistent Formatting: Follows the established format with:

    • Bold titles for each entry
    • PR links without hash symbols (✅ [PR 2247] not [PR #2247])
    • Author attribution with GitHub links

📝 Observations

  1. Release Date: Listed as 2026-02-05, which appears to be yesterday. Confirm this is the intended release date.

  2. Entry Detail Level: The entries are appropriately detailed:

    • The rspack configuration entry provides good technical context about YAML handling
    • The precompile hook entry explains the production deployment impact
    • The bin/dev entry is concise and clear

✨ Minor Style Notes

All entries follow the project's changelog guidelines correctly. The formatting is consistent with previous releases (16.2.1, 16.2.0, etc.).

🎯 Recommendation

APPROVE - This changelog entry is well-written, accurate, and follows all project conventions. It properly documents the 16.3.0 release with appropriate user-facing changes.

The PR is ready to merge.

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Feb 6, 2026

Code Review: Document React on Rails 16.3.0 release in CHANGELOG

✅ Overall Assessment

This is a well-structured changelog entry that follows the project's conventions. All referenced PRs are merged and the formatting is correct. However, there are a few important issues to address.


🔴 Critical Issues

1. Pro Feature Incorrectly Placed in Open-Source Changelog

The "Frictionless trial" feature (PR #2324, #2334, #2339) is documented in the open-source CHANGELOG.md, but it's a Pro-only feature.

According to CLAUDE.md:

IMPORTANT: This is a monorepo with TWO separate changelogs:

  • Open Source: /CHANGELOG.md - for react_on_rails gem and npm package
  • Pro: /CHANGELOG_PRO.md - for react_on_rails_pro gem and npm packages

When making changes, update the appropriate changelog(s):

  • Pro-only features/fixes → Update /CHANGELOG_PRO.md

The Pro changelog (react_on_rails_pro/CHANGELOG.md) already documents this feature correctly in the Unreleased section. It should be removed from the open-source changelog or moved to a separate entry that explains how it affects open-source users (if applicable).

Action Required: Remove the frictionless trial bullet point from CHANGELOG.md or clarify if there's an open-source aspect to this change.


⚠️ Minor Issues

2. PR Description Doesn't Match Actual Changes

The PR description states:

Changed:

However, the actual changelog includes:

  • A Pro feature (frictionless trial) in the Changed section
  • The Shakapacker change is correctly listed

Recommendation: Update the PR description to accurately reflect what's in the changelog, or remove the Pro feature from the changelog.


3. Formatting Consistency Check

The changelog entries follow the correct format with bold headers and PR links. Good work! However, consider these style points:

  • ✅ PR link format is correct: [PR 2247](URL) (no hash)
  • ✅ Author attribution is correct: by [username](URL)
  • ✅ Bold headers for feature names
  • ✅ Version comparison links updated correctly

📋 Additional Recommendations

4. Beta Changelog Curation (Future Reference)

This is a stable release (16.3.0), not a beta consolidation, so this doesn't apply now. However, CLAUDE.md mentions:

When consolidating beta versions into a stable release, carefully curate entries to include only user-facing changes

This is good guidance for future releases. The current entries appear to be legitimate user-facing fixes, which is appropriate.


5. Verify PR Merge Dates

I verified all referenced PRs are merged:

All PRs were merged before or on the release date (2026-02-05), which is correct.


🎯 Summary

Must Fix Before Merge:

  1. Remove the Pro-only "Frictionless trial" feature from open-source CHANGELOG.md, or clarify if there's an open-source component

Nice to Have:

  1. Update PR description to match actual changelog content

Positive Points:

  • ✅ Correct markdown formatting
  • ✅ All PRs verified as merged
  • ✅ Version comparison links updated correctly
  • ✅ Follows project changelog guidelines
  • ✅ Only includes user-facing changes (no internal/dev changes)

Let me know if you'd like me to make these changes directly!

Added changelog entry for 16.3.0 release (2026-02-05) with entries for three bug fixes:
- PR #2275: Fix rspack configuration not applying to all environments
- PR #2280: Fix precompile hook when Shakapacker is pre-installed
- PR #2273: Fix bin/dev failing with --route flag

Also includes PR #2247 (Simplified Shakapacker version handling) under Changed section.

Updated version comparison links at bottom of changelog.

Co-Authored-By: Claude Opus 4.6 <[email protected]>
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Feb 6, 2026

PR Review: Document React on Rails 16.3.0 Release

Summary

This PR documents the 16.3.0 release in the CHANGELOG, which is appropriate for a release documentation PR. Overall, the changelog entries are well-written and follow the project conventions.


Issues Identified

🚨 CRITICAL: Pro-only feature in wrong changelog

The "React on Rails Pro: Frictionless trial" entry (PRs #2324, #2334, #2339) should be in the Pro changelog (/react_on_rails_pro/CHANGELOG.md), not the main open-source CHANGELOG.

According to CLAUDE.md:

Pro-only features/fixes → Update /CHANGELOG_PRO.md

  • Changes affecting both → Update BOTH changelogs

The licensing system is a Pro-only feature and is already documented in the Pro changelog at react_on_rails_pro/CHANGELOG.md lines 22-28. It should be removed from the main changelog.

Evidence:


⚠️ Version Link Inconsistency

Line 1899: The unreleased link uses without the v prefix:

[unreleased]: https://github.com/shakacode/react_on_rails/compare/16.3.0...master

Line 1900: The 16.3.0 link uses without the v prefix:

[16.3.0]: https://github.com/shakacode/react_on_rails/compare/16.2.1...16.3.0

However, line 1901 uses v16.2.1:

[16.2.1]: https://github.com/shakacode/react_on_rails/compare/v16.2.0...v16.2.1

Recommendation: Check which tag format exists in the repository and use it consistently. Recent versions appear to use tags without the v prefix (16.2.1, 16.1.1), but some older ones use v prefix (v16.2.0).

# Check actual tag format
git tag --list '16.*' | head -5

What's Done Well ✅

  1. Excellent entry structure: Clear bold titles, detailed explanations, and technical specifics
  2. Proper PR attribution: Follows format [PR 2275](url) by [username](url)
  3. User-focused descriptions: Explains the bug, the impact, and the fix
  4. Appropriate categorization: "Changed" and "Fixed" sections are correctly used
  5. Version date included: ### [16.3.0] - 2026-02-05

Minor Suggestions (Optional)

  1. Consistency in technical details: Some entries explain the technical implementation ("regex replacement", "producer-consumer pattern") while others stay high-level. Consider standardizing the level of technical detail.

  2. Precompile hook entry: The title could be more specific about the impact:

    • Current: "Precompile hook not configured when Shakapacker is pre-installed"
    • Suggested: "Precompile hook not configured when Shakapacker is pre-installed, causing missing bundles in production"

Recommended Actions

  1. REMOVE the Pro licensing entry from this changelog (first bullet under "Changed")
  2. Verify and fix version link format for consistency
  3. Consider whether this version should also update the Pro changelog (if any Pro fixes are included)

Verification Checklist

  • Remove Pro licensing entry from main CHANGELOG.md
  • Fix version link formatting (16.2.1 reference)
  • Verify no other Pro-only features are listed
  • Ensure all PR numbers are accurate (verified ✓)
  • Run bundle exec rubocop before committing

Note: This is a straightforward changelog update PR. The main issue is the Pro feature being in the wrong file, which is a common mistake in monorepo changelogs.

- Remove "React on Rails Pro: Frictionless trial" entry from open-source
  CHANGELOG (it belongs only in CHANGELOG_PRO.md)
- Fix version comparison links to use actual git tag names (v16.3.0,
  v16.2.1) which have the v prefix since 16.2.0

Co-Authored-By: Claude Opus 4.6 <[email protected]>
@justin808 justin808 merged commit 91af758 into master Feb 6, 2026
2 of 3 checks passed
@justin808 justin808 deleted the jg/get-latest branch February 6, 2026 05:09
justin808 added a commit that referenced this pull request Feb 8, 2026
### Summary

Added changelog entry for React on Rails 16.3.0 (released 2026-02-05)
documenting all user-visible changes:

**Changed:**
- PR #2247: Simplified Shakapacker version handling

**Fixed:**
- PR #2275: Fix rspack configuration not applying to all environments
(fixes `bin/switch-bundler` crash and `--rspack` flag only updating
default section)
- PR #2280: Fix precompile hook when Shakapacker is pre-installed (fixes
missing component bundles in production)
- PR #2273: Fix `bin/dev` failing with `--route` flag

Updated version comparison links at the bottom of the file.

### Pull Request checklist

- [x] Update CHANGELOG file

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Changed**
  * Simplified handling of Shakapacker version (16.3.0)

* **Bug Fixes**
* Fixed environment/application behavior not being applied consistently
  * Fixed precompile hook when assets are pre-installed
  * Fixed route handling in the development command
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Claude Opus 4.6 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant