Skip to content

Make ReactOnRails.render return a reference to the component's backing instance#234

Merged
justin808 merged 2 commits intomasterfrom
return-react-element
Jan 28, 2016
Merged

Make ReactOnRails.render return a reference to the component's backing instance#234
justin808 merged 2 commits intomasterfrom
return-react-element

Conversation

@robwise
Copy link
Copy Markdown
Contributor

@robwise robwise commented Jan 27, 2016

Review on Reviewable

@robwise robwise force-pushed the return-react-element branch from 94f3d6d to 7cb9f21 Compare January 27, 2016 03:35
@robwise robwise force-pushed the return-react-element branch from 7cb9f21 to 599e579 Compare January 27, 2016 03:39
@robwise
Copy link
Copy Markdown
Contributor Author

robwise commented Jan 27, 2016

Finish up @DimaZab's PR: #213

@justin808
Copy link
Copy Markdown
Member

LGTM


Reviewed 4 of 5 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks broke.


Comments from the review on Reviewable.io

@justin808
Copy link
Copy Markdown
Member

@robwise This will go in 2.2.0 probably.

@justin808 justin808 added this to the 2.2 milestone Jan 27, 2016
justin808 added a commit that referenced this pull request Jan 28, 2016
Make ReactOnRails.render return a reference to the component's backing instance
@justin808 justin808 merged commit 81213f3 into master Jan 28, 2016
@justin808 justin808 deleted the return-react-element branch January 28, 2016 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants