Fix bin/dev route argument format by K4sku · Pull Request #2309 · shakacode/react_on_rails

K4sku · 2026-01-17T22:12:54Z

Summary

Fix --route argument in bin/dev template to use single argument format (--route=value) instead of two separate arguments

Problem

When running ./bin/dev without arguments, the DEFAULT_ROUTE value (hello_world) was being treated as a standalone command rather than the value for --route, causing:

Unknown argument: hello_world
Run 'dev help' for usage information

Solution

Changed from:

argv_with_defaults.push("--route", DEFAULT_ROUTE)

To:

argv_with_defaults.push("--route=#{DEFAULT_ROUTE}")

Test plan

Run ./bin/dev without arguments - should no longer error
Run ./bin/dev --route=custom_route - should still work with custom routes

Summary by CodeRabbit

Chores
- Simplified development environment configuration formatting for improved consistency with standard conventions.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Pass --route as a single argument with = instead of two separate arguments. Without this, the DEFAULT_ROUTE value is treated as a standalone command rather than the value for --route, causing "Unknown argument: hello_world" error.

greptile-apps

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

coderabbitai · 2026-01-17T22:13:08Z

Walkthrough

The bin/dev script was modified to pass the default route argument using a combined format --route=<DEFAULT_ROUTE> instead of two separate arguments. The conditional logic for applying the default route remains unchanged and only activates when no existing --route argument is present.

Changes

Cohort / File(s)	Summary
Route argument format update `react_on_rails/lib/generators/react_on_rails/templates/base/base/bin/dev`	Changed default route argument format from two separate arguments to single combined argument: `["--route", "<DEFAULT_ROUTE>"]` → `["--route=<DEFAULT_ROUTE>"]`

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Fix spec/dummy bin/dev to use correct route #2029: Adds a wrapper script that invokes the base dev script with the combined --route=/ argument format that this PR now expects

Suggested labels

bug, review-needed

Poem

🐰 Hops over the route with glee,
One argument's now the key,
No more splitting pairs in two,
The dev script zips right through! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Fix bin/dev route argument format' is clear, specific, and directly summarizes the main change: fixing how the --route argument is formatted in the bin/dev file.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

justin808 · 2026-01-18T21:25:04Z

@claude review this PR.

claude · 2026-01-18T21:25:19Z

Claude encountered an error —— View job

Command failed: git fetch origin --depth=20 fix-bin-dev-route-argument

I'll analyze this and get back to you.

justin808 · 2026-01-18T21:37:12Z

@K4sku big thanks! perfect!

- Add [16.2.1] section with release date 2026-01-18 - Add PR #2309 fix for bin/dev route argument parsing - Move PR #1868 benchmarking entry to 16.2.1 - Update version links at bottom of file Co-Authored-By: Claude Opus 4.5 <[email protected]>

## Summary - Add [16.2.1] section with release date 2026-01-18 - Add PR #2309 fix for bin/dev route argument parsing under Fixed - Move PR #1868 benchmarking entry to 16.2.1 under Developer (Contributors Only) - Update version links at bottom of file ## Test plan - [x] Pre-commit hooks pass - [x] Changelog formatting follows conventions - [x] Version links are correct 🤖 Generated with [Claude Code](https://claude.ai/claude-code) Co-authored-by: Claude Opus 4.5 <[email protected]>

Fix bin/dev route argument format

9d0eed3

Pass --route as a single argument with = instead of two separate arguments. Without this, the DEFAULT_ROUTE value is treated as a standalone command rather than the value for --route, causing "Unknown argument: hello_world" error.

greptile-apps Bot reviewed Jan 17, 2026

View reviewed changes

coderabbitai Bot added bug review-needed labels Jan 17, 2026

coderabbitai Bot approved these changes Jan 17, 2026

View reviewed changes

justin808 merged commit ed02878 into shakacode:master Jan 18, 2026
2 checks passed

justin808 mentioned this pull request Jan 18, 2026

Update CHANGELOG for 16.2.1 release #2313

Merged

3 tasks

justin808 mentioned this pull request Jan 22, 2026

Fix bin/dev failing with 'Unknown argument' when using --route flag #2273

Merged

3 tasks

claude Bot mentioned this pull request Feb 26, 2026

fix: replace marker file with Thor-idiomatic force option (#2289) #2411

Merged

3 tasks

This was referenced Mar 15, 2026

Replace NDJSON envelope with length-prefixed streaming protocol #2615

Merged

Improve create/install validation flows and migration docs #2650

Merged

Docs: Add RSC landing, ExecJS limitations, debugging, and benchmarks pages #2785

Merged

This was referenced Mar 24, 2026

Raise docs version floor to 16.4.0 in install/demo guidance #2610

Merged

Add RSC Flight payload optimization guide (Article 7) #2827

Merged

This was referenced Apr 18, 2026

docs: address RSC pitfalls review follow-ups (#3155) #3156

Merged

refactor: unify renderer cache staging with mode: :copy / :symlink #3167

Merged

Fix Bencher reporting permanently broken on pushes to main #3148

Merged

This was referenced May 4, 2026

feat: add REACT_ON_RAILS_BASE_PORT for concurrent worktree port management #3142

Open

feat: rolling_deploy_adapter for seeding previous bundle hashes #3173

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix bin/dev route argument format#2309

Fix bin/dev route argument format#2309
justin808 merged 1 commit intoshakacode:masterfrom
K4sku:fix-bin-dev-route-argument

K4sku commented Jan 17, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

greptile-apps Bot left a comment

Uh oh!

coderabbitai Bot commented Jan 17, 2026 •

edited

Loading

Uh oh!

justin808 commented Jan 18, 2026

Uh oh!

claude Bot commented Jan 18, 2026 •

edited

Loading

Uh oh!

Uh oh!

justin808 commented Jan 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

K4sku commented Jan 17, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Problem

Solution

Test plan

Summary by CodeRabbit

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot commented Jan 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Poem

Uh oh!

justin808 commented Jan 18, 2026

Uh oh!

claude Bot commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

justin808 commented Jan 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

K4sku commented Jan 17, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jan 17, 2026 •

edited

Loading

claude Bot commented Jan 18, 2026 •

edited

Loading