Conversation
There was a problem hiding this comment.
Need a test to verify that it's there in the normal case.
There was a problem hiding this comment.
I believe the test above it should cover the normal case as it defaults to display: none, I didn't want to repeat the same line but I can add a test for default.
aaronvb
force-pushed
the
TangRufus-add-skip-display-none
branch
from
feb4787 to
0a4ef31
Compare
aaronvb
force-pushed
the
TangRufus-add-skip-display-none
branch
from
0a4ef31 to
ce9d3b0
Compare
|
@aaronvb I didn't see the test the specifies the basic case that the display: none is included if the config value is false. Can you point me to it? Reviewed 4 of 4 files at r1, 3 of 3 files at r2. Comments from the review on Reviewable.io |
|
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful. spec/dummy/spec/helpers/react_on_rails_helper_spec.rb, line 79 [r2] (raw file): we need a test if the option is false Comments from the review on Reviewable.io |
|
@justin808 Adding it now, will push in a few! |
aaronvb
force-pushed
the
TangRufus-add-skip-display-none
branch
from
ce9d3b0 to
22f0815
Compare
|
spec/dummy/spec/helpers/react_on_rails_helper_spec.rb, line 79 [r2] (raw file): Comments from the review on Reviewable.io |
|
Reviewed 1 of 1 files at r3. spec/dummy/spec/helpers/react_on_rails_helper_spec.rb, line 79 [r2] (raw file): Comments from the review on Reviewable.io |
Tang rufus add skip display none
|
Thanks @aaronvb and @tangrufus. I'll do a release in a little bit. |
|
@justin808 @tangrufus Good work, glad we got this PR finished! |
Bumps [browserslist](https://github.com/browserslist/browserslist) from 4.9.1 to 4.16.8. - [Release notes](https://github.com/browserslist/browserslist/releases) - [Changelog](https://github.com/browserslist/browserslist/blob/main/CHANGELOG.md) - [Commits](browserslist/browserslist@4.9.1...4.16.8) --- updated-dependencies: - dependency-name: browserslist dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [browserslist](https://github.com/browserslist/browserslist) from 4.9.1 to 4.16.8. - [Release notes](https://github.com/browserslist/browserslist/releases) - [Changelog](https://github.com/browserslist/browserslist/blob/main/CHANGELOG.md) - [Commits](browserslist/browserslist@4.9.1...4.16.8) --- updated-dependencies: - dependency-name: browserslist dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 participants
Merged PR #174 and added tests.