@DimaZab I've never seen that pattern. What's the use case? Jade?

@alexfedoseev any opinion?

@DimaZab Maybe push up small test repo demonstrating this?

Also never seen that pattern. Use case will be nice.

@justin808, @alexfedoseev https://github.com/DimaZab/example here is an example, see README.

And if we look in react source code we will see that render method return created react element.

  render: function (nextElement, container, callback) {
    return ReactMount._renderSubtreeIntoContainer(null, nextElement, container, callback);
  }

@DimaZab @justin808 It makes sense 👍

OK -- so no harm in doing this. Yikes, and yuck for mixing jQuery with React! 😄

@DimaZab can you please add a JS test for this. I think JS will be sufficient. rather than a full integration test.

@justin808 I agree about jQuery and React but it's only for the first time.

@justin808 I've try to write test for this method:

  render(name, props, domNodeId) {
    const reactElement = createReactElement({ name, props, domNodeId });
    return ReactDOM.render(reactElement, document.getElementById(domNodeId));
  },

But get an error: 'document is not defined'. So, can I use something like mock-browser (https://www.npmjs.com/package/mock-browser) or may be you know better way?

@DimaZab Sure -- you'll need to use something like that. Thanks!

@justin808 done =)

@DimaZab, I'd like to get the merged as soon as you complete the changes I've requested. Thanks.

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from the review on Reviewable.io

@justin808 done

Some additional small items.

Reviewed 5 of 5 files at r2.
Review status: all files reviewed at latest revision, 5 unresolved discussions, some commit checks failed.

docs/additional_reading/javascript_rendering.md, line 26 [r2] (raw file):
Need empty line at end of file per red marker.

node_package/src/ReactOnRails.js, line 31 [r2] (raw file):
we need to put the return value here, @DimaZab

node_package/tests/ReactOnRails.test.js, line 24 [r1] (raw file):
I'm not 100% sold that we're using the right terminology. However, it's not critical. @jbhatab?

README.md, line 380 [r2] (raw file):
Let's rename to

Rails View Rendering from Inline JavaScript

Comments from the review on Reviewable.io

Reviewed 5 of 6 files at r2.
Review status: 2 of 5 files reviewed at latest revision, 6 unresolved discussions.

docs/additional_reading/rails_view_rendering_from_inline_javascript.md, line 7 [r3] (raw file):
We need to state the return value here.

We should copy the jsdoc from the JS file.

node_package/src/ReactOnRails.js, line 32 [r3] (raw file):
This should go into the doc rails_view_rendering_from_inline_javascript.

Comments from the review on Reviewable.io

@robwise Thank you)