Walkthrough

The PR modifies generated component pack loading strategy handling to support async loading when Shakapacker version permits. The configuration validator now checks PackerUtils support and defaults to async for newer versions, sync for older versions with warnings, while retaining deprecation handling. Templates and tests are updated accordingly.

Changes

Sequence Diagram(s)

sequenceDiagram
    participant Config as Configuration<br/>(validate method)
    participant Utils as PackerUtils
    participant Log as Rails.logger
    
    Config->>Utils: supports_async_loading?
    alt Async supported (v8.2.0+)
        Utils-->>Config: true
        Note over Config: Default to :async
    else Async not supported (< v8.2.0)
        Utils-->>Config: false
        alt Strategy is nil
            Config->>Log: warn async not supported
            Note over Config: Default to :sync
        else Strategy is explicitly :async
            Config-->>Config: raise error
        end
    end
    
    Note over Config: Validate final strategy is one of<br/>:async, :defer, or :sync

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20–25 minutes

• lib/react_on_rails/configuration.rb: Multi-branch conditional logic with PackerUtils integration requires careful validation of all paths (supported/unsupported versions, explicit vs. implicit strategies).
• spec/react_on_rails/configuration_spec.rb: Test expectations reflect version-dependent defaults; verify warning message assertions match implementation.
• Template change (application.html.erb): Conditional rendering logic depends on uses_redux_shared_store?; ensure both branches produce expected output.

Possibly related PRs

• Fix invalid version checker warnings and add pre-release comparison #1742: Modifies PackerUtils version parsing and comparison logic that this PR depends on for PackerUtils.supports_async_loading? checks.
• Add configurable loading strategy for generated component packs #1712: Adds original generated_component_packs_loading_strategy configuration and related load_pack_for_generated_component async/defer handling.
• Fix component registration race condition with defer loading strategy #1972: Modifies the same validation method but with opposing async-first defaults, creating potential merge conflict or behavioral divergence.

Suggested labels

review-needed

Suggested reviewers

• AbanoubGhadban
• Judahmeek

Poem

🐰 Async or defer, the choice is now clear!
When Shakapacker's ready, we load without fear.
Version checks guide us down the right path,
No more warnings or mysterious wrath!
The strategy blooms with each config file's care. 🌱

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}