eslint.config.ts (1)

47-48: Global ignore makes template-specific ESLint overrides unreachable.

Adding '/templates//' to globalIgnores prevents later rules for 'lib/generators/react_on_rails/templates/**/' (Lines 151-160) from ever applying. Drop the global ignore or narrow it.

Apply this diff:

-    // generator templates
-    '**/templates/**/*',

lib/generators/react_on_rails/templates/redux/base/app/javascript/bundles/HelloWorld/components/HelloWorld.tsx (1)

1-30: Minor TS ergonomics for onChange.

Prefer e.currentTarget.value (better typings) and a ChangeEventHandler alias.

-          onChange={(e: React.ChangeEvent<HTMLInputElement>) => updateName(e.target.value)}
+          onChange={(e) => updateName(e.currentTarget.value)}

Optionally:

// above component
import type { ChangeEventHandler } from 'react';
const onNameChange: ChangeEventHandler<HTMLInputElement> = (e) => updateName(e.currentTarget.value);

lib/generators/react_on_rails/react_with_redux_generator.rb (1)

38-41: No-op gsub: safe to remove.

Search and replace string equals replacement; drop these lines or fix the pattern if something else was intended.

-        ror_client_file = "app/javascript/src/HelloWorldApp/ror_components/HelloWorldApp.client.#{extension}"
-        gsub_file(ror_client_file, "../store/helloWorldStore", "../store/helloWorldStore")
-        gsub_file(ror_client_file, "../containers/HelloWorldContainer",
-                  "../containers/HelloWorldContainer")
+        # Template already uses the correct relative imports; no path adjustments required.

lib/generators/react_on_rails/templates/base/base/app/javascript/src/HelloWorld/ror_components/HelloWorld.client.tsx (1)

1-30: Minor TS/React nits.

• Prefer e.currentTarget.value for stricter typings.
• useState(props.name) infers string; generic arg is optional.

-  const [name, setName] = useState<string>(props.name);
+  const [name, setName] = useState(props.name);
@@
-            onChange={(e: React.ChangeEvent<HTMLInputElement>) => setName(e.target.value)}
+            onChange={(e) => setName(e.currentTarget.value)}

lib/generators/react_on_rails/templates/redux/base/app/javascript/bundles/HelloWorld/startup/HelloWorldApp.client.tsx (1)

1-1: Use type-only React import with react-jsx runtime

No runtime React usage; keep React.FC typing via a type-only import to avoid an unnecessary bundle import.

-import React from 'react';
+import type React from 'react';

spec/react_on_rails/generators/install_generator_spec.rb (1)

1-5: Require JSON before parsing tsconfig content

Avoid NameError by requiring json in this spec file.

 # frozen_string_literal: true

+require "json"
 require_relative "../support/generator_spec_helper"
 require_relative "../support/version_test_helpers"

lib/generators/react_on_rails/install_generator.rb (4)

360-367: Broaden package-manager detection and align fallback behavior

Also detect Bun by CLI (not only lockfile) to match other PMs, improving first-run ergonomics.

       def detect_package_manager
         return "yarn" if File.exist?("yarn.lock")
         return "pnpm" if File.exist?("pnpm-lock.yaml")
-        return "bun" if File.exist?("bun.lockb")
-        return "npm" if File.exist?("package-lock.json") || cli_exists?("npm")
+        return "bun" if File.exist?("bun.lockb") || cli_exists?("bun")
+        return "npm" if File.exist?("package-lock.json") || cli_exists?("npm")
 
         nil
       end

---

360-367: Deduplicate detect_package_manager logic

A similar detect method exists elsewhere (generator_messages.rb). Centralize this in a shared helper to prevent drift.

---

400-432: configure_babel_for_typescript is unused

Either remove to reduce surface area or invoke it; you already install @babel/preset-typescript in install_typescript_dependencies.

-      def configure_babel_for_typescript
-        # Install Babel TypeScript preset
-        package_manager = detect_package_manager
-        return unless package_manager
-        babel_typescript_package = "@babel/preset-typescript"
-        install_command = case package_manager
-                          when "npm"  then "npm install --save-dev #{babel_typescript_package}"
-                          when "yarn" then "yarn add --dev #{babel_typescript_package}"
-                          when "pnpm" then "pnpm add --save-dev #{babel_typescript_package}"
-                          when "bun"  then "bun add --dev #{babel_typescript_package}"
-                          end
-        puts Rainbow("📝 Installing Babel TypeScript preset...").yellow
-        success = system(install_command)
-        return if success
-        warning = <<~MSG.strip
-          ⚠️  Failed to install Babel TypeScript preset automatically.
-          Please run manually:
-              #{install_command}
-          TypeScript compilation may not work without this preset.
-        MSG
-        GeneratorMessages.add_warning(warning)
-        nil
-      end
+      # def configure_babel_for_typescript; end # intentionally removed (handled in install_typescript_dependencies)

---

369-387: TSConfig defaults are fine; consider TS5-friendly tweaks (optional)

If targeting Node 18+ and modern bundlers, consider:

• target: ES2022
• lib: ["dom", "dom.iterable", "ES2022"]
• moduleResolution: "bundler" (or "node16") for improved ESM/node-res semantics.

-            "target" => "es2018",
-            "lib" => ["dom", "dom.iterable", "es6"],
+            "target" => "ES2022",
+            "lib" => ["dom", "dom.iterable", "ES2022"],
-            "moduleResolution" => "node",
+            "moduleResolution" => "bundler",

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Learnt from: theforestvn88
PR: shakacode/react_on_rails#1620
File: spec/dummy/client/app/startup/HelloTurboStream.jsx:3-3
Timestamp: 2024-07-27T10:08:35.868Z
Learning: The `RailsContext` import in `spec/dummy/client/app/startup/HelloTurboStream.jsx` is used later in the project, as clarified by the user theforestvn88.

Learnt from: CR
PR: shakacode/react_on_rails#0
File: CLAUDE.md:0-0
Timestamp: 2025-09-16T02:48:43.027Z
Learning: Applies to {coverage,tmp,gen-examples,node_package/lib,node_modules,spec/dummy/node_modules,spec/dummy/tmp,spec/dummy/app/assets/webpack,spec/dummy/log}/** : Exclude generated/build/vendor directories from IDE indexing to avoid slowdowns

Learnt from: alexeyr-ci2
PR: shakacode/react_on_rails#1732
File: spec/dummy/client/app-react16/startup/ReduxSharedStoreApp.client.jsx:40-44
Timestamp: 2025-04-26T21:55:55.874Z
Learning: In the react_on_rails project, files under `app-react16` directories are copied/moved to corresponding `/app` directories during the conversion process (removing the `-react16` suffix), which affects their relative import paths at runtime.

lib/generators/react_on_rails/install_generator.rb (3)

314-358: Deduplicate package install logic; reuse GeneratorHelper#add_npm_dependencies and standard fallback.

This re-implements package-manager detection and install commands. We already have helper flows using package_json and consistent failure handling. Please switch to the established pattern.

Apply this diff to simplify and align behavior:

 def install_typescript_dependencies
-  puts Rainbow("📝 Installing TypeScript dependencies...").yellow
-
-  # Determine the package manager to use
-  package_manager = detect_package_manager
-  return unless package_manager
-
-  # Install TypeScript and React type definitions
-  typescript_packages = %w[
-    typescript
-    @types/react
-    @types/react-dom
-    @babel/preset-typescript
-  ]
-
-  install_command = case package_manager
-                    when "npm"
-                      "npm install --save-dev #{typescript_packages.join(' ')}"
-                    when "yarn"
-                      "yarn add --dev #{typescript_packages.join(' ')}"
-                    when "pnpm"
-                      "pnpm add --save-dev #{typescript_packages.join(' ')}"
-                    when "bun"
-                      "bun add --dev #{typescript_packages.join(' ')}"
-                    end
-
-  success = system(install_command)
-  unless success
-    warning = <<~MSG.strip
-      ⚠️  Failed to install TypeScript dependencies automatically.
-
-      Please run manually:
-          #{install_command}
-
-      TypeScript files will still be generated.
-    MSG
-    GeneratorMessages.add_warning(warning)
-  end
+  puts Rainbow("📝 Installing TypeScript dependencies...").yellow
+  typescript_packages = %w[typescript @types/react @types/react-dom @babel/preset-typescript]
+  # Try helper (auto-detects PM and edits package.json via package_json). If it succeeds, we're done.
+  return if add_npm_dependencies(typescript_packages, dev: true)
+  # Fallback to npm (consistent with BaseGenerator pattern).
+  success = run "npm install --save-dev #{typescript_packages.join(' ')}"
+  handle_npm_failure("TypeScript dependencies", typescript_packages) unless success

---

360-367: Remove duplicated detect_package_manager; centralize detection.

We already have detection (see GeneratorHelper/GeneratorMessages). Keeping another copy risks drift (e.g., bun support here but not elsewhere). Prefer one source of truth.

- def detect_package_manager
-   return "yarn" if File.exist?("yarn.lock")
-   return "pnpm" if File.exist?("pnpm-lock.yaml")
-   return "bun" if File.exist?("bun.lockb")
-   return "npm" if File.exist?("package-lock.json") || cli_exists?("npm")
-
-   nil
- end
+ # Package manager detection is provided by existing helpers. Remove this method.

---

369-398: Don’t overwrite existing tsconfig; update defaults (moduleResolution, lib/target) and strengthen strictness.

• Guard: skip writing if tsconfig.json exists, or write tsconfig.react-on-rails.json and instruct users to extends it.
• Use moduleResolution: "bundler" for modern bundlers.
• Drop explicit lib unless you need to deviate; current mix (target: es2018, lib: es6) is inconsistent.
• Add noUncheckedIndexedAccess: true (good safety that’s not covered by strict).

Proposed change:

 def create_typescript_config
-  tsconfig_content = {
+  if File.exist?("tsconfig.json")
+    puts Rainbow("ℹ️  tsconfig.json exists; not overwriting. Please ensure jsx:'react-jsx' and moduleResolution:'bundler'.").blue
+    return
+  end
+
+  tsconfig_content = {
     "compilerOptions" => {
-      "target" => "es2018",
-      "lib" => ["dom", "dom.iterable", "es6"],
+      "target" => "ES2022",
       "allowJs" => true,
       "skipLibCheck" => true,
       "esModuleInterop" => true,
       "allowSyntheticDefaultImports" => true,
       "strict" => true,
+      "noUncheckedIndexedAccess" => true,
       "forceConsistentCasingInFileNames" => true,
       "noFallthroughCasesInSwitch" => true,
       "module" => "esnext",
-      "moduleResolution" => "node",
+      "moduleResolution" => "bundler",
       "resolveJsonModule" => true,
       "isolatedModules" => true,
       "noEmit" => true,
       "jsx" => "react-jsx"
     },
     "include" => [
       "app/javascript/**/*"
     ],
-    "exclude" => [
-      "node_modules"
-    ]
+    "exclude" => ["node_modules"]
   }

lib/generators/react_on_rails/templates/redux/base/app/javascript/bundles/HelloWorld/components/HelloWorld.tsx (1)

22-22: Inline handler can be simplified (duplicate of prior review).

Apply:

-          onChange={(e: React.ChangeEvent<HTMLInputElement>) => updateName(e.target.value)}
+          onChange={e => updateName(e.target.value)}

lib/generators/react_on_rails/react_with_redux_generator.rb (2)

104-132: De‑duplicate PM fallback logic; centralize in GeneratorHelper.

This file re‑implements install fallback and command builders. Consolidate into GeneratorHelper (single source of truth), then delete install_packages_with_fallback/build_install_command here.

Apply this diff after moving fallback into GeneratorHelper:

-      private
-
-      def install_packages_with_fallback(packages, dev:, package_manager:)
-        packages_str = packages.join(" ")
-        install_command = build_install_command(package_manager, dev, packages_str)
-
-        success = system(install_command)
-        return if success
-
-        warning = <<~MSG.strip
-          ⚠️  Failed to install Redux dependencies automatically.
-
-          Please run manually:
-              #{install_command}
-        MSG
-        GeneratorMessages.add_warning(warning)
-      end
-
-      def build_install_command(package_manager, dev, packages_str)
-        commands = {
-          "npm" => { dev: "npm install --save-dev", prod: "npm install" },
-          "yarn" => { dev: "yarn add --dev", prod: "yarn add" },
-          "pnpm" => { dev: "pnpm add --save-dev", prod: "pnpm add" },
-          "bun" => { dev: "bun add --dev", prod: "bun add" }
-        }
-
-        command_type = dev ? :dev : :prod
-        "#{commands[package_manager][command_type]} #{packages_str}"
-      end
+      private

If you prefer to keep local fallback, ensure a single place builds commands for all generators to avoid drift.

---

91-102: Undefined detect_package_manager here; inline detection or move to helper.

This class doesn’t define detect_package_manager, and it’s not in GeneratorHelper (per snippet). Calling it will raise at runtime.

Apply this minimal inline detection (avoids cross‑generator coupling):

-        package_manager = detect_package_manager
-        return unless package_manager
+        package_manager =
+          if File.exist?("yarn.lock")
+            "yarn"
+          elsif File.exist?("pnpm-lock.yaml")
+            "pnpm"
+          elsif File.exist?("bun.lockb")
+            "bun"
+          else
+            "npm"
+          end

Alternatively, move all fallback logic into GeneratorHelper and call only add_npm_dependencies from here. See next comment.

eslint.config.ts (1)

47-49: Templates ignore looks fine; consider also ignoring .d.ts and verify overlap with the templates override block.

Adding TS/TSX under templates to global ignores prevents type-aware linting and bypasses the templates-specific override below. If that's intended, LGTM. If you still want basic linting without type-checking, move these paths into a dedicated override and disable the type-checked config there instead of globally ignoring.

Add .d.ts to avoid stray typedefs being linted:

     // generator templates - exclude TypeScript templates that need tsconfig.json
     '**/templates/**/*.tsx',
     '**/templates/**/*.ts',
+    '**/templates/**/*.d.ts',

lib/generators/react_on_rails/templates/redux/base/app/javascript/bundles/HelloWorld/startup/HelloWorldApp.client.tsx (2)

1-1: Prefer type-only React import with the automatic JSX runtime.

Avoid default React import when using the automatic runtime.

-import React from 'react';
+import { useMemo, type FC } from 'react';

---

13-17: Memoize the store to avoid re-creating it on re-renders.

-const HelloWorldApp: React.FC<HelloWorldAppProps> = (props) => (
-  <Provider store={configureStore(props)}>
-    <HelloWorldContainer />
-  </Provider>
-);
+const HelloWorldApp: FC<HelloWorldAppProps> = (props) => {
+  const store = useMemo(() => configureStore(props), [props]);
+  return (
+    <Provider store={store}>
+      <HelloWorldContainer />
+    </Provider>
+  );
+};

lib/generators/react_on_rails/templates/redux/base/app/javascript/bundles/HelloWorld/store/helloWorldStore.ts (2)

5-8: Tighten Rails props typing; avoid any.

Model initial state precisely and keep extras typed as unknown.

Apply:

-export interface RailsProps {
-  name: string;
-  [key: string]: any; // Allow additional props from Rails
-}
+export type RailsProps = PreloadedState<HelloWorldState> & Record<string, unknown>;

---

13-14: Optional: prefer Redux Toolkit for TS ergonomics.

configureStore gives better types/devtools by default.

Example:

// import { configureStore } from '@reduxjs/toolkit';
// const configureStore = (railsProps: RailsProps) =>
//   configureStore({ reducer: helloWorldReducer, preloadedState: railsProps });
// export type HelloWorldStore = ReturnType<typeof configureStore>;

lib/generators/react_on_rails/templates/redux/base/app/javascript/bundles/HelloWorld/containers/HelloWorldContainer.ts (1)

19-19: Use stable docs URL.

Avoid master links that can drift.

Apply:

-// See https://github.com/reactjs/react-redux/blob/master/docs/api.md#examples
+// See https://react-redux.js.org/api/connect

lib/generators/react_on_rails/templates/redux/base/app/javascript/bundles/HelloWorld/components/HelloWorld.tsx (1)

15-15: Prevent form submit refresh.

Stops accidental page reload on Enter.

Apply:

-    <form>
+    <form onSubmit={e => e.preventDefault()}>

lib/generators/react_on_rails/react_with_redux_generator.rb (2)

41-45: No‑op gsubs; either remove or fix target/replacement.

Both gsub_file calls replace a string with itself. If paths don’t need updates, drop these lines; otherwise, correct the replacement.

Apply this diff to remove the dead code:

-        ror_client_file = "app/javascript/src/HelloWorldApp/ror_components/HelloWorldApp.client.#{extension}"
-        gsub_file(ror_client_file, "../store/helloWorldStore", "../store/helloWorldStore")
-        gsub_file(ror_client_file, "../containers/HelloWorldContainer",
-                  "../containers/HelloWorldContainer")
+        # Client imports already resolve correctly relative to ror_components.

Please confirm the imports inside the template already point to ../store/helloWorldStore and ../containers/HelloWorldContainer for both TSX/JSX.

---

106-121: Avoid hard failure when warning; ensure GeneratorMessages is loaded and improve text.

On failure, this path may raise NameError if GeneratorMessages wasn’t required yet. Also, the message should list the actual packages.

Apply this diff:

-        success = system(install_command)
+        success = system(install_command)
         return if success

-        warning = <<~MSG.strip
-          ⚠️  Failed to install Redux dependencies automatically.
-
-          Please run manually:
-              #{install_command}
-        MSG
+        require_relative "generator_messages" unless defined?(GeneratorMessages)
+        warning = <<~MSG.strip
+          ⚠️  Failed to install npm packages automatically: #{packages.join(' ')}
+
+          Please run manually:
+              #{install_command}
+        MSG
         GeneratorMessages.add_warning(warning)

Optionally prefer Thor’s run(...) over system(...) for consistent logging.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Learnt from: CR
PR: shakacode/react_on_rails#0
File: CLAUDE.md:0-0
Timestamp: 2025-09-16T02:48:43.027Z
Learning: Applies to **/*.{js,jsx,ts,tsx} : Use ESLint for all JavaScript/TypeScript code

Learnt from: CR
PR: shakacode/react_on_rails#0
File: CLAUDE.md:0-0
Timestamp: 2025-09-16T02:48:43.027Z
Learning: Applies to {coverage,tmp,gen-examples,node_package/lib,node_modules,spec/dummy/node_modules,spec/dummy/tmp,spec/dummy/app/assets/webpack,spec/dummy/log}/** : Exclude generated/build/vendor directories from IDE indexing to avoid slowdowns

Learnt from: Romex91
PR: shakacode/react_on_rails#1697
File: package-scripts.yml:28-28
Timestamp: 2025-02-12T16:38:06.537Z
Learning: The file `node_package/lib/ReactOnRails.full.js` is autogenerated during the build process and should not be present in the repository.

Learnt from: alexeyr-ci2
PR: shakacode/react_on_rails#1732
File: spec/dummy/client/app-react16/startup/ReduxSharedStoreApp.client.jsx:40-44
Timestamp: 2025-04-26T21:55:55.874Z
Learning: In the react_on_rails project, files under `app-react16` directories are copied/moved to corresponding `/app` directories during the conversion process (removing the `-react16` suffix), which affects their relative import paths at runtime.

Learnt from: theforestvn88
PR: shakacode/react_on_rails#1620
File: spec/dummy/client/app/startup/HelloTurboStream.jsx:3-3
Timestamp: 2024-07-27T10:08:35.868Z
Learning: The `RailsContext` import in `spec/dummy/client/app/startup/HelloTurboStream.jsx` is used later in the project, as clarified by the user theforestvn88.

lib/generators/react_on_rails/install_generator.rb (2)

335-364: Harden and modernize tsconfig: don’t overwrite, use bundler resolution, avoid overriding defaults, add noUncheckedIndexedAccess.

• Skip creation if tsconfig.json exists (don’t clobber user config).
• Use "moduleResolution": "bundler" (TS 5+ recommendation for bundlers).
• Drop "lib" override and exclude: ["node_modules"] (defaults suffice).
• Add "noUncheckedIndexedAccess": true.

Apply this diff:

 def create_typescript_config
-  tsconfig_content = {
+  # Do not overwrite an existing config; ask user to merge
+  if File.exist?("tsconfig.json")
+    GeneratorMessages.add_warning("⚠️  tsconfig.json already exists; skipping creation. Merge React on Rails settings manually if desired.")
+    return
+  end
+
+  tsconfig_content = {
     "compilerOptions" => {
-      "target" => "es2018",
-      "lib" => ["dom", "dom.iterable", "es6"],
+      "target" => "es2018",
       "allowJs" => true,
       "skipLibCheck" => true,
       "esModuleInterop" => true,
       "allowSyntheticDefaultImports" => true,
-      "strict" => true,
+      "strict" => true,
+      "noUncheckedIndexedAccess" => true,
       "forceConsistentCasingInFileNames" => true,
       "noFallthroughCasesInSwitch" => true,
       "module" => "esnext",
-      "moduleResolution" => "node",
+      "moduleResolution" => "bundler",
       "resolveJsonModule" => true,
       "isolatedModules" => true,
       "noEmit" => true,
       "jsx" => "react-jsx"
     },
     "include" => [
       "app/javascript/**/*"
-    ],
-    "exclude" => [
-      "node_modules"
     ]
   }
 
   File.write("tsconfig.json", JSON.pretty_generate(tsconfig_content))
   puts Rainbow("✅ Created tsconfig.json").green
 end

---

314-333: Fix NameError and redundant PM detection in install_typescript_dependencies.

CI failure shows detect_package_manager is undefined here; and the variable isn’t used anyway. Rely on add_npm_dependencies (package_json) with npm fallback and mark dev: true in the failure hint.

Apply this diff:

 def install_typescript_dependencies
   puts Rainbow("📝 Installing TypeScript dependencies...").yellow
-
-  # Determine the package manager to use
-  package_manager = detect_package_manager
-  return unless package_manager
-
   # Install TypeScript and React type definitions
   typescript_packages = %w[
     typescript
     @types/react
     @types/react-dom
     @babel/preset-typescript
   ]
 
-  return if add_npm_dependencies(typescript_packages, dev: true)
+  # Prefer package_json (via GeneratorHelper); fall back to npm if unavailable
+  return if add_npm_dependencies(typescript_packages, dev: true)
 
-  success = run "npm install --save-dev #{typescript_packages.join(' ')}"
-  handle_npm_failure("TypeScript dependencies", typescript_packages) unless success
+  success = run("npm install --save-dev #{typescript_packages.join(' ')}")
+  handle_npm_failure("TypeScript dependencies", typescript_packages, dev: true) unless success
 end

Run to confirm no remaining references:

#!/bin/bash
rg -n -C2 '\bdetect_package_manager\b'
rg -n -C2 '\bcreate_typescript_config\b'

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Learnt from: Romex91
PR: shakacode/react_on_rails#1697
File: package-scripts.yml:28-28
Timestamp: 2025-02-12T16:38:06.537Z
Learning: The file `node_package/lib/ReactOnRails.full.js` is autogenerated during the build process and should not be present in the repository.

lib/generators/react_on_rails/install_generator.rb (1)

372-401: Don’t overwrite existing tsconfig; prefer modern resolver; simplify libs.

• Skip creation if tsconfig.json already exists (avoid clobbering user config).
• Use "moduleResolution": "bundler" for TS 5+ with webpack/shakapacker.
• Omit explicit "lib"; defaults match target and avoid downgrading to "es6".
• Optional: enable noUncheckedIndexedAccess for safer types.

Apply this diff:

       def create_typescript_config
-        tsconfig_content = {
+        # Do not overwrite an existing user tsconfig
+        if File.exist?("tsconfig.json")
+          puts Rainbow("ℹ️ tsconfig.json already exists; skipping creation").cyan
+          return
+        end
+
+        tsconfig_content = {
           "compilerOptions" => {
-            "target" => "es2018",
-            "lib" => ["dom", "dom.iterable", "es6"],
+            "target" => "es2018",
             "allowJs" => true,
             "skipLibCheck" => true,
             "esModuleInterop" => true,
             "allowSyntheticDefaultImports" => true,
             "strict" => true,
+            "noUncheckedIndexedAccess" => true,
             "forceConsistentCasingInFileNames" => true,
             "noFallthroughCasesInSwitch" => true,
             "module" => "esnext",
-            "moduleResolution" => "node",
+            "moduleResolution" => "bundler",
             "resolveJsonModule" => true,
             "isolatedModules" => true,
             "noEmit" => true,
             "jsx" => "react-jsx"
           },

lib/generators/react_on_rails/react_with_redux_generator.rb (2)

41-46: Remove no‑op gsub_file calls.

Both replacements use identical from/to strings, so they do nothing. Safer to delete to avoid confusion.

Apply this diff:

-        # Update import paths in client component
-        ror_client_file = "app/javascript/src/HelloWorldApp/ror_components/HelloWorldApp.client.#{extension}"
-        gsub_file(ror_client_file, "../store/helloWorldStore", "../store/helloWorldStore")
-        gsub_file(ror_client_file, "../containers/HelloWorldContainer",
-                  "../containers/HelloWorldContainer")
+        # Client imports in the template are already correct; no path rewrites needed.

---

113-129: Builds safe, explicit PM commands.

Validated PM allowlist and explicit dev/prod maps look good. Consider moving these helpers into GeneratorHelper to DRY with other generators.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Learnt from: Romex91
PR: shakacode/react_on_rails#1697
File: package-scripts.yml:28-28
Timestamp: 2025-02-12T16:38:06.537Z
Learning: The file `node_package/lib/ReactOnRails.full.js` is autogenerated during the build process and should not be present in the repository.

Learnt from: alexeyr-ci2
PR: shakacode/react_on_rails#1732
File: spec/dummy/client/app-react16/startup/ReduxSharedStoreApp.client.jsx:40-44
Timestamp: 2025-04-26T21:55:55.874Z
Learning: In the react_on_rails project, files under `app-react16` directories are copied/moved to corresponding `/app` directories during the conversion process (removing the `-react16` suffix), which affects their relative import paths at runtime.